Added directives for JAVA SDK release for 2023-04-01 RecoveryServicesBackup #26172

ankur741999 · 2023-10-11T09:22:24Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-10-11T09:22:29Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-10-11T09:22:30Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v2.1.6)	new version	base version
default	default(5cace91)	default(main)

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-11T09:22:31Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup - Approved - 4.0.0

+	Operation `*ProtectionContainersClient.Register` has been changed to LRO, use `*ProtectionContainersClient.BeginRegister` instead.

❌azure-sdk-for-python-track2 - track2_azure-mgmt-recoveryservicesbackup - Approved - 7.0.0

+	Renamed operation ProtectionContainersOperations.register to ProtectionContainersOperations.begin_register

❌azure-sdk-for-js - @azure/arm-recoveryservicesbackup - Approved - 12.0.0

+	Removed operation ProtectionContainers.register

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2bb9500. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.RecoveryServicesBackup [View full logs] [Release SDK Changes] Breaking Change Detected
- Azure.ResourceManager.RecoveryServicesBackup.1.2.0-alpha.20231012.1.nupkg
```
info	[Changelog] Breaking Changes:
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 2bb9500. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-recoveryservicesbackup [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model BackupStatusResponse has a new parameter acquire_storage_account_lock
info	[Changelog]   - Model BackupStatusResponse has a new parameter protected_items_count
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Renamed operation ProtectionContainersOperations.register to ProtectionContainersOperations.begin_register

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 2bb9500. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-recoveryservicesbackup [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2bb9500. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Operation `*ProtectionContainersClient.Register` has been changed to LRO, use `*ProtectionContainersClient.BeginRegister` instead.
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `ExtendedLocation` in struct `IaasVMRecoveryPoint`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 1 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2bb9500. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-recoveryservicesbackup [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-recoveryservicesbackup-12.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation ProtectionContainers.beginRegister
info	[Changelog]   - Added operation ProtectionContainers.beginRegisterAndWait
info	[Changelog]   - Interface BackupStatusResponse has a new optional parameter acquireStorageAccountLock
info	[Changelog]   - Interface BackupStatusResponse has a new optional parameter protectedItemsCount
info	[Changelog]   - Interface IaasVMRecoveryPoint has a new optional parameter extendedLocation
info	[Changelog]   - Interface ProtectionContainersRegisterOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface ProtectionContainersRegisterOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation ProtectionContainers.register

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 2bb9500. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️recoveryservicesbackup [View full logs]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 2bb9500. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.recoveryservicesbackup.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.recoveryservicesbackup.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-11T09:22:32Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup	https://apiview.dev/Assemblies/Review/08b5e059074a4892b4234c36dc709276
.Net	Azure.ResourceManager.RecoveryServicesBackup	https://apiview.dev/Assemblies/Review/93db38c413ac41a3aea89980322ca01d
JavaScript	@azure/arm-recoveryservicesbackup	https://apiview.dev/Assemblies/Review/73194212904e4819acca64216e7e45eb
Java	azure-resourcemanager-recoveryservicesbackup	https://apiview.dev/Assemblies/Review/e974cb48c02840a99deb3aa1f73a0bff

specification/recoveryservicesbackup/resource-manager/readme.java.md

XiaofeiCao · 2023-10-12T04:02:47Z

test generation from the fix(ignore the SDK version, just for regen):
Azure/azure-sdk-for-java@cf450dd

XiaofeiCao · 2023-10-12T05:49:18Z

This PR only affects Java SDK.

openapi-pipeline-app · 2023-10-12T05:49:41Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

…Backup (#26172) * Added Breaking change for 2023-04-01 RecoveryServicesBackup JAVA * fix --------- Co-authored-by: xiaofeicao <[email protected]>

Added Breaking change for 2023-04-01 RecoveryServicesBackup JAVA

6bac2e4

openapi-assignment-bot bot assigned rkmanda Oct 11, 2023

hiaga changed the title ~~Added Breaking change for 2023-04-01 RecoveryServicesBackup JAVA~~ Added directives for java SDk release to counter breaking changes for 2023-04-01 RecoveryServicesBackup Oct 11, 2023

azure-sdk mentioned this pull request Oct 11, 2023

[AutoPR sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup] Added directives for JAVA SDK release for 2023-04-01 RecoveryServicesBackup azure-sdk/azure-sdk-for-go#7640

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Oct 11, 2023

AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 11, 2023

hiaga changed the title ~~Added directives for java SDk release to counter breaking changes for 2023-04-01 RecoveryServicesBackup~~ Added directives for JAVA SDK release for 2023-04-01 RecoveryServicesBackup Oct 11, 2023

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Oct 11, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Oct 11, 2023

weidongxu-microsoft approved these changes Oct 12, 2023

View reviewed changes

XiaofeiCao reviewed Oct 12, 2023

View reviewed changes

specification/recoveryservicesbackup/resource-manager/readme.java.md Outdated Show resolved Hide resolved

XiaofeiCao reviewed Oct 12, 2023

View reviewed changes

specification/recoveryservicesbackup/resource-manager/readme.java.md Outdated Show resolved Hide resolved

fix

5cace91

XiaofeiCao added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 12, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 12, 2023

XiaofeiCao added Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-Python Approved-SdkBreakingChange-JavaScript labels Oct 12, 2023

XiaofeiCao merged commit 2bb9500 into Azure:main Oct 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added directives for JAVA SDK release for 2023-04-01 RecoveryServicesBackup #26172

Added directives for JAVA SDK release for 2023-04-01 RecoveryServicesBackup #26172

Uh oh!

ankur741999 commented Oct 11, 2023 •

edited by openapi-workflow-bot bot

Loading

Uh oh!

openapi-pipeline-app bot commented Oct 11, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Oct 11, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Oct 11, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Oct 11, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

XiaofeiCao commented Oct 12, 2023

Uh oh!

XiaofeiCao commented Oct 12, 2023

Uh oh!

openapi-pipeline-app bot commented Oct 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Added directives for JAVA SDK release for 2023-04-01 RecoveryServicesBackup #26172

Added directives for JAVA SDK release for 2023-04-01 RecoveryServicesBackup #26172

Uh oh!

Conversation

ankur741999 commented Oct 11, 2023 • edited by openapi-workflow-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

Uh oh!

openapi-pipeline-app bot commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

Uh oh!

Uh oh!

XiaofeiCao commented Oct 12, 2023

Uh oh!

XiaofeiCao commented Oct 12, 2023

Uh oh!

openapi-pipeline-app bot commented Oct 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ankur741999 commented Oct 11, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-pipeline-app bot commented Oct 11, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 11, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 11, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 11, 2023 •

edited

Loading