From 017004b67856490b5c2c60b863ddc4b475292ef1 Mon Sep 17 00:00:00 2001 From: Konrad Jamrozik Date: Sat, 24 Jun 2023 16:58:29 -0700 Subject: [PATCH 1/3] Update pull_request_assignment.yml: remove armapireview as it is misconfigured --- .github/pull_request_assignment.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/pull_request_assignment.yml b/.github/pull_request_assignment.yml index 9a4a9e4dfdc3..8bf96b32aaad 100644 --- a/.github/pull_request_assignment.yml +++ b/.github/pull_request_assignment.yml @@ -15,7 +15,6 @@ - kazrael2119 - v-xuto - rkmanda - - armapireview - rule: # translator data-plane PR From 7f1702e7ed8bb76c9c25ee4903fd9a77829a0f08 Mon Sep 17 00:00:00 2001 From: Ray Chen Date: Mon, 26 Jun 2023 14:55:08 +0800 Subject: [PATCH 2/3] Update pull_request_assignment.yml Removed all other assignees for mgmt. plane PR. --- .github/pull_request_assignment.yml | 97 +---------------------------- 1 file changed, 3 insertions(+), 94 deletions(-) diff --git a/.github/pull_request_assignment.yml b/.github/pull_request_assignment.yml index 8bf96b32aaad..4e1807c1cd9d 100644 --- a/.github/pull_request_assignment.yml +++ b/.github/pull_request_assignment.yml @@ -7,13 +7,6 @@ - "specification/**/resource-manager/**" - "specification/common-types/resource-management/**" reviewers: - - JackTn - - keryul - - zedy-wj - - v-jiaodi - - Wzb123456789 - - kazrael2119 - - v-xuto - rkmanda - rule: @@ -102,108 +95,24 @@ paths: - "specification/network/**" reviewers: - - JackTn - - keryul + - rkmanda branches: - release-network-Microsoft.Network-official - rule: paths: "specification/sql/**" reviewers: - - v-xuto + - rkmanda branches: - dev-sql- - rule: paths: "specification/@(financialdataservices|standbypool)/**" reviewers: - - JackTn - - keryul + - rkmanda branches: - RPSaaSDev -- rule: - paths: "specification/compute/**" - reviewers: - - JackTn - - keryul - -- rule: - paths: - - "specification/machinelearningservices/**" - reviewers: - - zedy-wj - - v-jiaodi - -- rule: - paths: - - "specification/monitor/**" - reviewers: - - zedy-wj - - v-jiaodi - -- rule: - paths: - - "specification/@(azurestackhci|security)/**" - reviewers: - - Wzb123456789 - - kazrael2119 - -- rule: - paths: - - "specification/@(web|app)/**" - reviewers: - - Wzb123456789 - - kazrael2119 - -- rule: - paths: "specification/@(synapse|azurearcdata)/**" - reviewers: - - zedy-wj - - v-jiaodi - -- rule: - paths: "specification/@(workloads|apimanagement)/**" - reviewers: - - zedy-wj - - v-jiaodi - -- rule: - paths: "specification/@(securityinsights|impact)/**" - reviewers: - - JackTn - - keryul - -- rule: - paths: "specification/@(appcomplianceautomation|hybridnetwork)/**" - reviewers: - - zedy-wj - - v-jiaodi - -- rule: - paths: "specification/@(cost-management|hybridconnectivity)/**" - reviewers: - - JackTn - - keryul - -- rule: - paths: "specification/@(billing|resources)/**" - reviewers: - - Wzb123456789 - - kazrael2119 - -- rule: - paths: "specification/@(testbase|appplatform)/**" - reviewers: - - JackTn - - keryul - -- rule: - paths: "specification/@(containerservice|paloaltonetworks)/**" - reviewers: - - zedy-wj - - v-jiaodi - - rule: paths: - "documentation/**" From 8f919b6ec9a9fea20f98a180f3eedb57724c85c3 Mon Sep 17 00:00:00 2001 From: Ray Chen Date: Tue, 27 Jun 2023 08:08:33 +0800 Subject: [PATCH 3/3] Update pull_request_assignment.yml Moved the default mgmt. PR assignment rule. --- .github/pull_request_assignment.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/pull_request_assignment.yml b/.github/pull_request_assignment.yml index 4e1807c1cd9d..864741669e1f 100644 --- a/.github/pull_request_assignment.yml +++ b/.github/pull_request_assignment.yml @@ -1,14 +1,4 @@ --- -- rule: - # resource management plane PR's - paths: - - "specification/**/*Management/**" - - "specification/**/*Management.Shared/**" - - "specification/**/resource-manager/**" - - "specification/common-types/resource-management/**" - reviewers: - - rkmanda - - rule: # translator data-plane PR paths: @@ -129,7 +119,17 @@ reviewers: - weshaggard - konrad-jamrozik - + +- rule: + # resource management plane PR's + paths: + - "specification/**/*Management/**" + - "specification/**/*Management.Shared/**" + - "specification/**/resource-manager/**" + - "specification/common-types/resource-management/**" + reviewers: + - rkmanda + - rule: # temporary catchall paths: