Adding User Assigned MI Support for Azure Databricks Access Connector #22416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @mvvsubbu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| accessconnector.json | 2022-10-01-preview(e499ef1) | 2022-04-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2023-02-01 | package-2023-02-01(e499ef1) | package-2023-02-01(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
The resource name parameter 'connectorName' should be defined with a 'pattern' restriction. Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L37 |
|
An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L78 |
|
A 202 response should include an Location response header. Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L104 |
|
An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L122 |
|
A 202 response should include an Location response header. Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L216 |
|
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L343 |
|
The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L394 |
|
The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L401 |
| The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L78 |
|
| The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L122 |
|
| The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L181 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L328 |
|
| Schema should have a description or title. Location: Microsoft.Databricks/preview/2022-10-01-preview/accessconnector.json#L340 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/databricks/resource-manager/readme.md tag: specification/databricks/resource-manager/readme.md#tag-package-2023-02-01 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 15 Errors, 0 Warnings failed [Detail]
Tag package-2023-02-01; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 24, untested: 0, failed: 14, passed: 10
Service API Readiness Test failed. Check pipeline artifact for detail report.
| Rule | Message |
|---|---|
|
Additional properties not allowed: enableFedRampCertification Source: response OperationId: Workspaces_ListBySubscription |
|
Additional properties not allowed: enableFedRampCertification Source: response OperationId: Workspaces_Get |
|
Additional properties not allowed: enableFedRampCertification Source: response OperationId: Workspaces_ListByResourceGroup |
|
Additional properties not allowed: enableFedRampCertification Source: response OperationId: Workspaces_Update |
|
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.Databricks/workspaces/virtualNetworkPeerings/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-VBdPtj-22416/providers/Microsoft.Databricks/workspaces/workspacngo6s4/virtualNetworkPeerings/peeringnstfi1i'; however, it does not have permission to perform action 'peer/action' on the linked scope(s) '/subscriptions/0140911e-1040-48da-8bc9-b99fb3dd88a6/resourceGroups/subramantest/providers/Microsoft.Network/virtualNetworks/subramanvnet' or the linked scope(s) are invalid. Source: runtime OperationId: vNetPeering_CreateOrUpdate |
|
statusCode: 404, errorCode: NotFound, errorMessage: Resource /subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/myManagedapiTest-VBdPtj-22416/providers/Microsoft.Network/virtualNetworks/workers-vnet/virtualNetworkPeerings/peeringnstfi1i not found. Source: runtime OperationId: vNetPeering_Get |
|
statusCode: 400, errorCode: InvalidSkuForPrivateEndpoint, errorMessage: The workspace 'workspacngo6s4' has '' sku. Only premium workspaces can create private endpoint connection Source: runtime OperationId: PrivateEndpointConnections_Create |
|
statusCode: 400, errorCode: InvalidSkuForPrivateEndpoint, errorMessage: The workspace 'workspacngo6s4' has '' sku. Only premium workspaces can create private endpoint connection Source: runtime OperationId: PrivateEndpointConnections_List |
|
statusCode: 400, errorCode: InvalidSkuForPrivateEndpoint, errorMessage: The workspace 'workspacngo6s4' has '' sku. Only premium workspaces can create private endpoint connection Source: runtime OperationId: PrivateEndpointConnections_Get |
|
Additional properties not allowed: origin Source: response OperationId: Operations_List |
|
Additional properties not allowed: properties Source: response OperationId: Operations_List |
|
statusCode: 400, errorCode: NonVNetInjectedWorkspaceNotSupported, errorMessage: The workspace 'workspacngo6s4' is not VNet injected. Outbound network endpoints are only supported for VNET injected workspaces. Source: runtime OperationId: OutboundNetworkDependenciesEndpoints_List |
|
statusCode: 400, errorCode: InvalidSkuForPrivateEndpoint, errorMessage: The workspace 'workspacngo6s4' has '' sku. Only premium workspaces can create private endpoint connection Source: runtime OperationId: PrivateLinkResources_List |
|
statusCode: 400, errorCode: InvalidSkuForPrivateEndpoint, errorMessage: The workspace 'workspacngo6s4' has '' sku. Only premium workspaces can create private endpoint connection Source: runtime OperationId: PrivateLinkResources_Get |
|
statusCode: 404, errorCode: PrivateEndpointConnectionsNotFound, errorMessage: The private endpoint connection 'privatee42ixdq' is not found in the workspace 'workspacngo6s4' Source: runtime OperationId: PrivateEndpointConnections_Delete |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @mvvsubbu your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
Contributor
Author
|
These changes are already approved in Private Repository in the following PR https://github.com/Azure/azure-rest-api-specs-pr/pull/9319 And these are also approved in Public Repository in the following PR The Public Repository PR has been accidentally merged by the previous PR owner, so I had to revert and create new one. |
AzureRestAPISpecReview
added
CI-MissingBaseCommit
new-api-version
ReadyForApiTest
|
Hi, @mvvsubbu, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
This was referenced Feb 1, 2023
mvvsubbu
added
DoNotMerge
mvvsubbu
changed the title
sjanamma
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
mvvsubbu
changed the title
mvvsubbu
removed
the
DoNotMerge
mvvsubbu
changed the title
Contributor
Author
|
@leni-msft can you merge this PR, our service changes are deployed. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 15, 2023
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Feb 15, 2023
…bricks Access Connector (#2707) Create to sync Azure/azure-rest-api-specs#22416 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/databricks?expand=1)
This was referenced Feb 15, 2023
aviyerMSFT
pushed a commit
to aviyerMSFT/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2023
…Azure#22416) * Adding new API Version base line commit * Adding UA MI Public Preview Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.