Skip to content

Add api version 2022-10-01 #21856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add api version 2022-10-01 #21856

wants to merge 5 commits into from

Conversation

@utsrkr
Copy link
Contributor

@utsrkr utsrkr commented Dec 12, 2022 •
edited
Loading

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @utsrkr Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 12, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 1 Errors, 8 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.2)] new version base version
    databox.json 2022-10-01(d05fec8) 2022-09-01(main)
    databox.json 2022-10-01(d05fec8) 2021-08-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    ❌ 1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.DataBox/stable/2022-10-01/databox.json#L4844:7
    Old: Microsoft.DataBox/stable/2022-09-01/databox.json#L4786:7
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DataBox/stable/2022-10-01/databox.json#L1775:5
    Old: Microsoft.DataBox/stable/2022-09-01/databox.json#L1775:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DataBox/stable/2022-10-01/databox.json#L1958:5
    Old: Microsoft.DataBox/stable/2022-09-01/databox.json#L1902:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DataBox/stable/2022-10-01/databox.json#L3023:11
    Old: Microsoft.DataBox/stable/2022-09-01/databox.json#L2962:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DataBox/stable/2022-10-01/databox.json#L3108:11
    Old: Microsoft.DataBox/stable/2022-09-01/databox.json#L3047:11


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.DataBox/stable/2022-10-01/databox.json#L4844:7
    Old: Microsoft.DataBox/preview/2021-08-01-preview/databox.json#L4203:7
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DataBox/stable/2022-10-01/databox.json#L1775:5
    Old: Microsoft.DataBox/preview/2021-08-01-preview/databox.json#L1605:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DataBox/stable/2022-10-01/databox.json#L3023:11
    Old: Microsoft.DataBox/preview/2021-08-01-preview/databox.json#L2493:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DataBox/stable/2022-10-01/databox.json#L3108:11
    Old: Microsoft.DataBox/preview/2021-08-01-preview/databox.json#L2578:11
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-10 package-2022-10(d05fec8) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ ParametersOrder The parameters:jobName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L113
    ❌ ParametersOrder The parameters:jobName,resourceGroupName should be kept in the same order as they present in the path.
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L167
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L567
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L602
    ❌ CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L609
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L609
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L638
    ❌ PatchSkuProperty The patch operation body parameter schema should contains property 'sku'.
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L725
    ❌ ConsistentPatchProperties The property 'properties.details.returnToCustomerPackageDetails' in the request body either not apppear in the resource model or has the wrong level.
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L730
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L1084
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L1160
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L1299
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L1383
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L1395
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L1446
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L2224
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L2258
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L2899
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L2950
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L3020
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L3044
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L3069
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L3082
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L3105
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L3129
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L3168
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L3181
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L3298
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L3305
    ❌ XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DataBox/stable/2022-10-01/databox.json#L3521
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 12, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - sdk/resourcemanager/databox/armdatabox - Approved - 2.0.0
    +	Field `AccountName` of struct `DiskGranularCopyLogDetails` has been removed
    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-databox - 1.0.0
    +	Model DataBoxDiskJobDetails no longer has parameter expected_data_size_in_terabytes
+	Model DataBoxHeavyJobDetails no longer has parameter expected_data_size_in_terabytes
+	Model DataBoxJobDetails no longer has parameter expected_data_size_in_terabytes
+	Model DiskScheduleAvailabilityRequest has a new required parameter expected_data_size_in_tera_bytes
+	Model DiskScheduleAvailabilityRequest no longer has parameter expected_data_size_in_terabytes
+	Model JobDetails no longer has parameter expected_data_size_in_terabytes
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • ❌Failed [Logs] Generate from 298d7d9ea214770be4be314c316f198f5d3393c2. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:615
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 615 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • ❌Azure.ResourceManager.DataBox [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable<Azure.ResourceManager.DataBox.Models.TransportShipmentType> Azure.ResourceManager.DataBox.Models.DataBoxValidateAddressContent.TransportPreferencesPreferredShipmentType.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/databox/Azure.ResourceManager.DataBox/src/Azure.ResourceManager.DataBox.csproj],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.DataBox.Models.DataBoxValidateAddressContent.TransportPreferencesPreferredShipmentType.set(System.Nullable<Azure.ResourceManager.DataBox.Models.TransportShipmentType>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/databox/Azure.ResourceManager.DataBox/src/Azure.ResourceManager.DataBox.csproj],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.DataBox.Models.MitigateJobContent..ctor(Azure.ResourceManager.DataBox.Models.CustomerResolutionCode)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/databox/Azure.ResourceManager.DataBox/src/Azure.ResourceManager.DataBox.csproj],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.DataBox.Models.CustomerResolutionCode Azure.ResourceManager.DataBox.Models.MitigateJobContent.CustomerResolutionCode.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/databox/Azure.ResourceManager.DataBox/src/Azure.ResourceManager.DataBox.csproj],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.DataBox/Debug/netstandard2.0/Azure.ResourceManager.DataBox.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/databox/Azure.ResourceManager.DataBox/src/Azure.ResourceManager.DataBox.csproj]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 298d7d9ea214770be4be314c316f198f5d3393c2. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-databox [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation JobsOperations.mark_devices_shipped
info	[Changelog]   - Added operation group DataBoxManagementClientOperationsMixin
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter actions
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter data_center_code
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter datacenter_address
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter device_erasure_details
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter expected_data_size_in_tera_bytes
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter granular_copy_log_details
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter granular_copy_progress
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter last_mitigation_action_on_job
info	[Changelog]   - Model DataBoxDiskJobDetails has a new parameter reverse_shipping_details
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter actions
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter data_center_code
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter datacenter_address
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter device_erasure_details
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter expected_data_size_in_tera_bytes
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter last_mitigation_action_on_job
info	[Changelog]   - Model DataBoxHeavyJobDetails has a new parameter reverse_shipping_details
info	[Changelog]   - Model DataBoxJobDetails has a new parameter actions
info	[Changelog]   - Model DataBoxJobDetails has a new parameter data_center_code
info	[Changelog]   - Model DataBoxJobDetails has a new parameter datacenter_address
info	[Changelog]   - Model DataBoxJobDetails has a new parameter device_erasure_details
info	[Changelog]   - Model DataBoxJobDetails has a new parameter expected_data_size_in_tera_bytes
info	[Changelog]   - Model DataBoxJobDetails has a new parameter last_mitigation_action_on_job
info	[Changelog]   - Model DataBoxJobDetails has a new parameter reverse_shipping_details
info	[Changelog]   - Model DataImportDetails has a new parameter log_collection_level
info	[Changelog]   - Model JobDetails has a new parameter actions
info	[Changelog]   - Model JobDetails has a new parameter data_center_code
info	[Changelog]   - Model JobDetails has a new parameter datacenter_address
info	[Changelog]   - Model JobDetails has a new parameter device_erasure_details
info	[Changelog]   - Model JobDetails has a new parameter expected_data_size_in_tera_bytes
info	[Changelog]   - Model JobDetails has a new parameter last_mitigation_action_on_job
info	[Changelog]   - Model JobDetails has a new parameter reverse_shipping_details
info	[Changelog]   - Model JobResource has a new parameter reverse_shipping_details_update
info	[Changelog]   - Model JobResource has a new parameter reverse_transport_preference_update
info	[Changelog]   - Model JobResource has a new parameter system_data
info	[Changelog]   - Model Preferences has a new parameter reverse_transport_preferences
info	[Changelog]   - Model Preferences has a new parameter storage_account_access_tier_preferences
info	[Changelog]   - Model RegionConfigurationRequest has a new parameter datacenter_address_request
info	[Changelog]   - Model RegionConfigurationResponse has a new parameter datacenter_address_response
info	[Changelog]   - Model SkuInformation has a new parameter countries_within_commerce_boundary
info	[Changelog]   - Model TransportPreferences has a new parameter is_updated
info	[Changelog]   - Model UpdateJobDetails has a new parameter preferences
info	[Changelog]   - Model UpdateJobDetails has a new parameter return_to_customer_package_details
info	[Changelog]   - Model UpdateJobDetails has a new parameter reverse_shipping_details
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model DataBoxDiskJobDetails no longer has parameter expected_data_size_in_terabytes
info	[Changelog]   - Model DataBoxHeavyJobDetails no longer has parameter expected_data_size_in_terabytes
info	[Changelog]   - Model DataBoxJobDetails no longer has parameter expected_data_size_in_terabytes
info	[Changelog]   - Model DiskScheduleAvailabilityRequest has a new required parameter expected_data_size_in_tera_bytes
info	[Changelog]   - Model DiskScheduleAvailabilityRequest no longer has parameter expected_data_size_in_terabytes
info	[Changelog]   - Model JobDetails no longer has parameter expected_data_size_in_terabytes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 298d7d9ea214770be4be314c316f198f5d3393c2. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-databox [View full logs]  [Preview SDK Changes] 
      info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 298d7d9ea214770be4be314c316f198f5d3393c2. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/databox/armdatabox [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `AccountName` of struct `DiskGranularCopyLogDetails` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New type alias `ReverseShippingDetailsEditStatus` with values `ReverseShippingDetailsEditStatusDisabled`, `ReverseShippingDetailsEditStatusEnabled`, `ReverseShippingDetailsEditStatusNotSupported`
info	[Changelog] - New type alias `ReverseTransportPreferenceEditStatus` with values `ReverseTransportPreferenceEditStatusDisabled`, `ReverseTransportPreferenceEditStatusEnabled`, `ReverseTransportPreferenceEditStatusNotSupported`
info	[Changelog] - New struct `ContactInfo`
info	[Changelog] - New struct `CustomerInterventionStageProgress`
info	[Changelog] - New struct `ReverseShippingDetails`
info	[Changelog] - New field `ReverseShippingDetails` in struct `CommonJobDetails`
info	[Changelog] - New field `Actions` in struct `CopyProgress`
info	[Changelog] - New field `Error` in struct `CopyProgress`
info	[Changelog] - New field `Actions` in struct `CustomerDiskCopyProgress`
info	[Changelog] - New field `Error` in struct `CustomerDiskCopyProgress`
info	[Changelog] - New field `ReverseShippingDetails` in struct `CustomerDiskJobDetails`
info	[Changelog] - New field `AccountID` in struct `DiskGranularCopyLogDetails`
info	[Changelog] - New field `Actions` in struct `DiskGranularCopyProgress`
info	[Changelog] - New field `Error` in struct `DiskGranularCopyProgress`
info	[Changelog] - New field `GranularCopyLogDetails` in struct `DiskJobDetails`
info	[Changelog] - New field `ReverseShippingDetails` in struct `DiskJobDetails`
info	[Changelog] - New field `Actions` in struct `GranularCopyProgress`
info	[Changelog] - New field `Error` in struct `GranularCopyProgress`
info	[Changelog] - New field `ReverseShippingDetails` in struct `HeavyJobDetails`
info	[Changelog] - New field `ReverseShippingDetails` in struct `JobDetails`
info	[Changelog] - New field `ReverseShippingDetailsUpdate` in struct `JobProperties`
info	[Changelog] - New field `ReverseTransportPreferenceUpdate` in struct `JobProperties`
info	[Changelog] - New field `SerialNumberCustomerResolutionMap` in struct `MitigateJobRequest`
info	[Changelog] - New field `ReverseTransportPreferences` in struct `Preferences`
info	[Changelog] - New field `CountriesWithinCommerceBoundary` in struct `SKUProperties`
info	[Changelog] - New field `IsUpdated` in struct `TransportPreferences`
info	[Changelog] - New field `Preferences` in struct `UpdateJobDetails`
info	[Changelog] - New field `ReverseShippingDetails` in struct `UpdateJobDetails`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 30 additive change(s).
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 298d7d9ea214770be4be314c316f198f5d3393c2. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-databox [View full logs]  [Preview SDK Changes]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 298d7d9ea214770be4be314c316f198f5d3393c2. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️databox [View full logs]  [Preview Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 298d7d9ea214770be4be314c316f198f5d3393c2. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.DataBox [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 12, 2022 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    swagger Microsoft.DataBox Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Go sdk/resourcemanager/databox/armdatabox Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.DataBox Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-databox Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-databox Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Dec 12, 2022
    @ghost
    Copy link

    ghost commented Dec 12, 2022

    Thank you for your contribution utsrkr! We will review the pull request and get back to you soon.

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure CI-MissingBaseCommit new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 12, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @utsrkr, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @openapi-workflow-bot
    Copy link

    Hi @utsrkr, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @utsrkr, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @azure-sdk azure-sdk mentioned this pull request Dec 12, 2022
    Closed
    This was referenced Dec 12, 2022
    Draft
    Closed
    Closed
    This was referenced Dec 12, 2022
    Closed
    Closed
    Closed
    @AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed CI-FixRequiredOnFailure labels Dec 12, 2022
    @ArcturusZhang ArcturusZhang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Dec 13, 2022
    @ArcturusZhang
    Copy link
    Member

    approve breaking change because it has been approved in previous PRs: #21625

    @ArcturusZhang ArcturusZhang removed the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Dec 13, 2022
    @ArcturusZhang
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ArcturusZhang ArcturusZhang added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go labels Dec 13, 2022
    @zizw123
    Copy link

    zizw123 commented Dec 15, 2022

    Hi, @utsrkr, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    Please follow this guide for ARM review. Thanks

    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 15, 2022
    @mentat9
    Copy link
    Member

    mentat9 commented Jan 3, 2023

    @utsrkr - Your PR is labeled with ARMChangesRequested, which means it is not on ARM review's radar. Please address the previous reviewer's comment and resubmit your PR with the correct format.

    Note also, you haven't filled out the submission form above. This is a hard requirement for reviewers and automation to help handle your PR correctly, so be sure to do so when you resubmit.

    Be sure to follow these guidelines for preparing your PR for ARM review:
    https://armwiki.azurewebsites.net/rp_onboarding/process/api_review.html and carefully read and complete the entire submission checklist above. Skipping any of these requirements may significantly slow down the review process or require reworking your PR.

    @utsrkr utsrkr closed this Jan 4, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    @ArcturusZhang ArcturusZhang

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-MissingBaseCommit customer-reported Issues that are reported by GitHub users external to the Azure organization. new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    5 participants

    @utsrkr @ArcturusZhang @zizw123 @mentat9 @AzureRestAPISpecReview