From b191bd83334b22dd5faecd36cd4602d7b736d78c Mon Sep 17 00:00:00 2001 From: vimimrot Date: Sun, 9 Oct 2022 00:27:25 +0530 Subject: [PATCH 01/18] NSP Link API changes --- .../examples/NspLinkDelete.json | 14 + .../examples/NspLinkGet.json | 40 + .../examples/NspLinkList.json | 70 ++ .../examples/NspLinkPut.json | 73 ++ .../examples/NspLinkReconcile.json | 18 + .../examples/NspLinkReferenceDelete.json | 14 + .../examples/NspLinkReferenceGet.json | 38 + .../examples/NspLinkReferenceList.json | 67 ++ .../examples/NspLinkReferencePut.json | 50 ++ .../examples/NspLinkReferenceReconcile.json | 18 + .../networkSecurityPerimeter.json | 731 +++++++++++++++++- 11 files changed, 1125 insertions(+), 8 deletions(-) create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkDelete.json create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReconcile.json create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferencePut.json create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceReconcile.json diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkDelete.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkDelete.json new file mode 100644 index 000000000000..774c0a9ad813 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkDelete.json @@ -0,0 +1,14 @@ +{ + "title": "Delete NSP link", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp1", + "linkName": "link1" + }, + "responses": { + "200": {}, + "204": {} + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json new file mode 100644 index 000000000000..65c7e0e1db4f --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json @@ -0,0 +1,40 @@ +{ + "title": "Get NSP Link", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp1", + "linkName": "link1" + }, + "responses": { + "200": { + "body": { + "name": "link1", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link1", + "type": "Microsoft.Network/networkSecurityPerimeters/links", + "location": "resource location", + "properties": { + "provisioningState": "Succeeded", + "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", + "manualApprovedRemotePerimeterId": "", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Auto Approved", + "status": "Approved" + } + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json new file mode 100644 index 000000000000..7c6aa251eb4b --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json @@ -0,0 +1,70 @@ +{ + "title": "List NSP Links", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp1" + }, + "responses": { + "200": { + "body": { + "value": [ + { + "name": "link1", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link1", + "type": "Microsoft.Network/networkSecurityPerimeters/links", + "location": "resource location", + "properties": { + "provisioningState": "Succeeded", + "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", + "manualApprovedRemotePerimeterId": "", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Auto Approved", + "status": "Approved" + } + }, + { + "name": "link2", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link2", + "type": "Microsoft.Network/networkSecurityPerimeters/links", + "location": "resource location", + "properties": { + "provisioningState": "Succeeded", + "autoApprovedRemotePerimeterId": "", + "manualApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp3", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Please approve the request for link creation.", + "status": "Approved" + } + } + ], + "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links?api-version=2021-02-01-preview&$skipToken=10" + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json new file mode 100644 index 000000000000..00c6418bfe3c --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json @@ -0,0 +1,73 @@ +{ + "title": "Create/Update NSP link", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp1", + "linkName": "link1", + "parameters": { + "properties": { + "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2" + } + } + }, + "responses": { + "200": { + "body": { + "name": "link1", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link1", + "type": "Microsoft.Network/networkSecurityPerimeters/links", + "location": "resource location", + "properties": { + "provisioningState": "Succeeded", + "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", + "manualApprovedRemotePerimeterId": "", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Auto Approved", + "status": "Approved" + } + } + }, + "201": { + "body": { + "name": "link1", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link1", + "type": "Microsoft.Network/networkSecurityPerimeters/links", + "location": "resource location", + "properties": { + "provisioningState": "Succeeded", + "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", + "manualApprovedRemotePerimeterId": "", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Auto Approved", + "status": "Approved" + } + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReconcile.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReconcile.json new file mode 100644 index 000000000000..c74a891b5af7 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReconcile.json @@ -0,0 +1,18 @@ +{ + "title": "Reconcile NSP link", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp1", + "linkName": "link1", + "parameters": { + "properties": {} + } + }, + "responses": { + "200": { + "body": {} + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json new file mode 100644 index 000000000000..0ff1ecb9d2e0 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json @@ -0,0 +1,14 @@ +{ + "title": "Delete NSP linkReference", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp2", + "linkReferenceName": "link1-guid" + }, + "responses": { + "200": {}, + "204": {} + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json new file mode 100644 index 000000000000..08f1df55c621 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json @@ -0,0 +1,38 @@ +{ + "title": "Get NSP LinkReference", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp2", + "linkReferenceName": "link1-guid" + }, + "responses": { + "200": { + "body": { + "name": "link1-guid", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences/link1-guid", + "type": "Microsoft.Network/networkSecurityPerimeters/linkreferences", + "properties": { + "provisioningState": "Succeeded", + "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Auto Approved", + "status": "Approved" + } + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json new file mode 100644 index 000000000000..f12227617dd5 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json @@ -0,0 +1,67 @@ +{ + "title": "List NSP LinkReferences", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp2" + }, + "responses": { + "200": { + "body": { + "value": [ + { + "name": "link1-guid", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences/link1-guid", + "type": "Microsoft.Network/networkSecurityPerimeters/linkreferences", + "properties": { + "provisioningState": "Succeeded", + "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Auto Approved", + "status": "Approved" + } + }, + { + "name": "link2-guid", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences/link2-guid", + "type": "Microsoft.Network/networkSecurityPerimeters/linkreferences", + "properties": { + "provisioningState": "Succeeded", + "autoApprovedRemotePerimeterId": "", + "manualApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp3", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Approved link creation request.", + "status": "Approved" + } + } + ], + "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences?api-version=2021-02-01-preview&$skipToken=10" + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferencePut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferencePut.json new file mode 100644 index 000000000000..9cad393d565f --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferencePut.json @@ -0,0 +1,50 @@ +{ + "title": "Approve NSP link request", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp2", + "linkReferenceName": "link1-guid", + "parameters": { + "properties": { + "localInboundProfiles": [ + "Profile1", "Profile2" + ], + "localOutboundProfiles": [ + "Profile1", "Profile2" + ], + "description": "Request Approved", + "status": "Approved" + } + } + }, + "responses": { + "200": { + "body": { + "name": "link1-guid", + "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkReferences/link1-guid", + "type": "Microsoft.Network/networkSecurityPerimeters/linkReferences", + "properties": { + "provisioningState": "Succeeded", + "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "Profile1", "Profile2" + ], + "localOutboundProfiles": [ + "Profile1", "Profile2" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Request Approved.", + "status": "Approved" + } + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceReconcile.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceReconcile.json new file mode 100644 index 000000000000..1376dc99124d --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceReconcile.json @@ -0,0 +1,18 @@ +{ + "title": "Reconcile NSP linkreference", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp1", + "linkReferenceName": "link1-guid", + "parameters": { + "properties": {} + } + }, + "responses": { + "200": { + "body": {} + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index c9461e6bbc7a..7e42e25a3bc0 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -902,6 +902,460 @@ } } } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/links/{linkName}": { + "parameters": [ + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/NetworkSecurityPerimeterNameParameter" + }, + { + "$ref": "#/parameters/LinkNameParameter" + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + } + ], + "get": { + "tags": [ + "NspLinks" + ], + "operationId": "NspLinks_Get", + "description": "Gets the specified NSP link.", + "responses": { + "200": { + "description": "OK - Returns information about the NSP link.", + "schema": { + "$ref": "#/definitions/NspLink" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspLinksGet": { + "$ref": "./examples/NspLinkGet.json" + } + } + }, + "put": { + "tags": [ + "NspLinks" + ], + "operationId": "NspLinks_CreateOrUpdate", + "description": "Creates or updates a NSP link.", + "parameters": [ + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/NspLink" + }, + "description": "Parameters that hold the NspLink resource to be created/updated." + } + ], + "responses": { + "200": { + "description": "Updated - Existing access rule is updated. Returns the resource.", + "schema": { + "$ref": "#/definitions/NspLink" + } + }, + "201": { + "description": "Create - Returns the NspLink resource created.", + "schema": { + "$ref": "#/definitions/NspLink" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspLinksPut": { + "$ref": "./examples/NspLinkPut.json" + } + } + }, + "delete": { + "tags": [ + "NspLinks" + ], + "operationId": "NspLinks_Delete", + "description": "Deletes an NSP Link.", + "responses": { + "200": { + "description": "Delete Succeed." + }, + "202": { + "description": "Delete in progress.", + "headers": { + "location": { + "description": "location header", + "type": "string" + } + } + }, + "204": { + "description": "Request successful. The resource does not exist." + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspLinkDelete": { + "$ref": "./examples/NspLinkDelete.json" + } + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/links": { + "get": { + "tags": [ + "NspLinks" + ], + "operationId": "NspLinks_List", + "description": "Lists the NSP Links in the specified network security perimeter.", + "x-ms-pageable": { + "nextLinkName": "nextLink" + }, + "parameters": [ + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/NetworkSecurityPerimeterNameParameter" + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/ListTopParameter" + }, + { + "$ref": "#/parameters/ListSkipTokenParameter" + } + ], + "responses": { + "200": { + "description": "OK - Returns the list of NSP links.", + "schema": { + "$ref": "#/definitions/NspLinkListResult" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspProfilesList": { + "$ref": "./examples/NspLinkList.json" + } + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/links/{linkName}/reconcile": { + "parameters": [ + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/NetworkSecurityPerimeterNameParameter" + }, + { + "$ref": "#/parameters/LinkNameParameter" + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + } + ], + "post": { + "tags": [ + "NspLinkReconcile" + ], + "operationId": "NspLinkReconcile_Post", + "description": "Reconcile NSP link", + "parameters": [ + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/NspLinkReconcile" + }, + "description": "Parameters for NSP link reconcile" + } + ], + "responses": { + "200": { + "description": "Reconcile NSP link.", + "schema": { + "$ref": "#/definitions/NspLinkReconcile" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspLinkReconcile": { + "$ref": "./examples/NspLinkReconcile.json" + } + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/linkReferences/{linkReferenceName}": { + "parameters": [ + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/NetworkSecurityPerimeterNameParameter" + }, + { + "$ref": "#/parameters/LinkReferenceNameParameter" + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + } + ], + "get": { + "tags": [ + "NspLinkReferences" + ], + "operationId": "NspLinkReferences_Get", + "description": "Gets the specified NSP linkReference.", + "responses": { + "200": { + "description": "OK - Returns information about the NSP linkReference.", + "schema": { + "$ref": "#/definitions/NspLinkReference" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspLinkReferencesGet": { + "$ref": "./examples/NspLinkReferenceGet.json" + } + } + }, + "put": { + "tags": [ + "NspLinkReferences" + ], + "operationId": "NspLinkReferences_CreateOrUpdate", + "description": "Creates or updates a NSP linkReference.", + "parameters": [ + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/NspLinkReference" + }, + "description": "Parameters that hold the NspLinkReference resource to be created/updated." + } + ], + "responses": { + "200": { + "description": "Updated - Existing access rule is updated. Returns the resource.", + "schema": { + "$ref": "#/definitions/NspLinkReference" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspLinkReferencesPut": { + "$ref": "./examples/NspLinkReferencePut.json" + } + } + }, + "delete": { + "tags": [ + "NspLinkReferences" + ], + "operationId": "NspLinkReferences_Delete", + "description": "Deletes an NSP LinkReference.", + "responses": { + "200": { + "description": "Delete Succeed." + }, + "202": { + "description": "Delete in progress.", + "headers": { + "location": { + "description": "location header", + "type": "string" + } + } + }, + "204": { + "description": "Request successful. The resource does not exist." + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspLinkReferenceDelete": { + "$ref": "./examples/NspLinkReferenceDelete.json" + } + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/linkReferences": { + "get": { + "tags": [ + "NspLinkReferences" + ], + "operationId": "NspLinkReferences_List", + "description": "Lists the NSP LinkReferences in the specified network security perimeter.", + "x-ms-pageable": { + "nextLinkName": "nextLink" + }, + "parameters": [ + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/NetworkSecurityPerimeterNameParameter" + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/ListTopParameter" + }, + { + "$ref": "#/parameters/ListSkipTokenParameter" + } + ], + "responses": { + "200": { + "description": "OK - Returns the list of NSP linkreferences.", + "schema": { + "$ref": "#/definitions/NspLinkReferenceListResult" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspProfilesList": { + "$ref": "./examples/NspLinkReferenceList.json" + } + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/linkReferences/{linkReferenceName}/reconcile": { + "parameters": [ + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/NetworkSecurityPerimeterNameParameter" + }, + { + "$ref": "#/parameters/LinkReferenceNameParameter" + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + } + ], + "post": { + "tags": [ + "NspLinkReferenceReconcile" + ], + "operationId": "NspLinkReferenceReconcile_Post", + "description": "Reconcile NSP linkReference", + "parameters": [ + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/NspLinkReferenceReconcile" + }, + "description": "Parameters for NSP linkReference reconcile" + } + ], + "responses": { + "200": { + "description": "Reconcile NSP linkReference.", + "schema": { + "$ref": "#/definitions/NspLinkReferenceReconcile" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspLinkReferenceReconcile": { + "$ref": "./examples/NspLinkReferenceReconcile.json" + } + } + } } }, "definitions": { @@ -1343,6 +1797,259 @@ "type": "object", "properties": {}, "description": "Request object for NSP reconcile." + }, + "NspLink": { + "type": "object", + "properties": { + "properties": { + "x-ms-client-flatten": true, + "$ref": "#/definitions/NspLinkProperties", + "description": "Properties of the network security perimeter link" + }, + "name": { + "type": "string", + "description": "The name of the link resource that is unique within a perimeter. This name can be used to access the resource." + }, + "id": { + "readOnly": true, + "type": "string", + "description": "Identifier of the network security perimeter link in ARM id format." + }, + "type": { + "readOnly": true, + "type": "string", + "description": "Resource type." + } + }, + "allOf": [ + { + "$ref": "./network.json#/definitions/Resource" + } + ], + "description": "The network security perimeter link resource" + }, + "NspLinkListResult": { + "type": "object", + "properties": { + "value": { + "type": "array", + "items": { + "$ref": "#/definitions/NspLink" + }, + "description": "Gets a page of NSP Link" + }, + "nextLink": { + "type": "string", + "description": "Gets the URL to get the next page of results." + } + }, + "description": "Result of the request to list NSP link. Contains a list of NSP link and a URL link to get the next set of results." + }, + "NspLinkProperties": { + "type": "object", + "properties": { + "provisioningState": { + "readOnly": true, + "$ref": "#/definitions/NSPProvisioningState", + "description": "The provisioning state of the NSP Link resource." + }, + "autoApprovedRemotePerimeterId": { + "type": "string", + "description": "Perimeter ARM Id for the remote NSP with which the link gets created in Auto-approval mode. Used when the NSP admin have access to approve connections on the remote NSP resource." + }, + "manualApprovedRemotePerimeterId": { + "type": "string", + "description": "Perimeter ARM Id for the remote NSP with which the link gets created. Used when the NSP admin does not have access to approve connections on the remote NSP resource." + }, + "remotePerimeterGuid": { + "readOnly": true, + "type": "string", + "description": "Remote NSP Guid with which the link gets created." + }, + "localInboundProfiles": { + "type": "array", + "items": { + "type": "string" + }, + "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles.", + "default": ["*"] + }, + "localOutboundProfiles": { + "type": "array", + "items": { + "type": "string" + }, + "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles.", + "default": ["*"] + }, + "remoteInboundProfiles": { + "type": "array", + "items": { + "type": "string" + }, + "description": "Remote Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles. This property can only be updated in auto-approval mode.", + "default": ["*"] + }, + "remoteOutboundProfiles": { + "type": "array", + "items": { + "type": "string" + }, + "description": "Remote Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles. This property can only be updated in auto-approval mode.", + "default": ["*"] + }, + "description": { + "type": "string", + "description": "A message passed to the owner of the remote NSP link resource with this connection request. Restricted to 140 chars." + }, + "status": { + "type": "string", + "readOnly": true, + "description": "The NSP link state.", + "enum": [ + "Approved", + "Pending", + "Rejected", + "Disconnected" + ], + "x-ms-enum": { + "name": "nspLinkStatus", + "modelAsString": true + } + } + }, + "description": "Properties of NSP Link." + }, + "NspLinkReconcile": { + "type": "object", + "properties": {}, + "description": "Request object for NSP link reconcile." + }, + "NspLinkReference": { + "type": "object", + "properties": { + "properties": { + "x-ms-client-flatten": true, + "$ref": "#/definitions/NspLinkReferenceProperties", + "description": "Properties of the network security perimeter linkReference" + }, + "name": { + "type": "string", + "description": "The name of the linkReference resource that is unique within a perimeter. This name can be used to access the resource." + }, + "id": { + "readOnly": true, + "type": "string", + "description": "Identifier of the network security perimeter linkReference in ARM id format." + }, + "type": { + "readOnly": true, + "type": "string", + "description": "Resource type." + } + }, + "allOf": [ + { + "$ref": "./network.json#/definitions/Resource" + } + ], + "description": "The network security perimeter linkReference resource" + }, + "NspLinkReferenceListResult": { + "type": "object", + "properties": { + "value": { + "type": "array", + "items": { + "$ref": "#/definitions/NspLinkReference" + }, + "description": "Gets a page of NSP LinkReference" + }, + "nextLink": { + "type": "string", + "description": "Gets the URL to get the next page of results." + } + }, + "description": "Result of the request to list NSP linkReference. Contains a list of NSP linkReference and a URL link to get the next set of results." + }, + "NspLinkReferenceProperties": { + "type": "object", + "properties": { + "provisioningState": { + "readOnly": true, + "$ref": "#/definitions/NSPProvisioningState", + "description": "The provisioning state of the NSP LinkReference resource." + }, + "remotePerimeterId": { + "readOnly": true, + "type": "string", + "description": "Perimeter ARM Id for the remote NSP with which the link is created." + }, + "remotePerimeterGuid": { + "readOnly": true, + "type": "string", + "description": "Remote NSP Guid with which the link is created." + }, + "localInboundProfiles": { + "type": "array", + "items": { + "type": "string" + }, + "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles.", + "default": ["*"] + }, + "localOutboundProfiles": { + "type": "array", + "items": { + "type": "string" + }, + "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles.", + "default": ["*"] + }, + "remoteInboundProfiles": { + "type": "array", + "items": { + "type": "string" + }, + "readOnly": true, + "description": "Remote Inbound profile names to which Inbound is allowed. '*' value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from remote perimeter.", + "default": ["*"] + }, + "remoteOutboundProfiles": { + "type": "array", + "items": { + "type": "string" + }, + "readOnly": true, + "description": "Remote Outbound profile names from which Outbound is allowed. '*' value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from remote perimeter.", + "default": ["*"] + }, + "description": { + "type": "string", + "description": "A message can be send to the remote NSP link admin with the connection response. Restricted to 140 chars." + }, + "status": { + "type": "string", + "readOnly": true, + "description": "The NSP linkReference state.", + "enum": [ + "Approved", + "Pending", + "Rejected", + "Disconnected" + ], + "x-ms-enum": { + "name": "nspLinkStatus", + "modelAsString": true + } + } + }, + "description": "Properties of NSP LinkReference." + }, + "NspLinkReferenceReconcile": { + "type": "object", + "properties": {}, + "description": "Request object for NSP linkReference reconcile." } }, "parameters": { @@ -1386,6 +2093,22 @@ "description": "The name of the NSP association.", "x-ms-parameter-location": "method" }, + "LinkNameParameter": { + "name": "linkName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the NSP link.", + "x-ms-parameter-location": "method" + }, + "LinkReferenceNameParameter": { + "name": "linkReferenceName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the NSP linkReference.", + "x-ms-parameter-location": "method" + }, "ListTopParameter": { "name": "$top", "description": "An optional query parameter which specifies the maximum number of records to be returned by the server.", @@ -1405,14 +2128,6 @@ "type": "string", "x-ms-parameter-location": "method" }, - "NetworkSecurityPerimeterProfileParameter": { - "name": "networkSecurityPerimeterProfile", - "in": "path", - "required": true, - "type": "string", - "description": "The name of the network security perimeter profile.", - "x-ms-parameter-location": "method" - }, "LocationParameter": { "name": "location", "in": "path", From 9d3ea047a6b0415188cc97765c71c12c1e47e4ca Mon Sep 17 00:00:00 2001 From: vimimrot Date: Sun, 9 Oct 2022 01:01:09 +0530 Subject: [PATCH 02/18] minor fix --- .../preview/2021-02-01-preview/examples/NspLinkDelete.json | 5 +++++ .../examples/NspLinkReferenceDelete.json | 5 +++++ .../2021-02-01-preview/examples/NspLinkReferenceList.json | 3 +-- .../2021-02-01-preview/networkSecurityPerimeter.json | 7 +++---- 4 files changed, 14 insertions(+), 6 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkDelete.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkDelete.json index 774c0a9ad813..e174fd3b540f 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkDelete.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkDelete.json @@ -9,6 +9,11 @@ }, "responses": { "200": {}, + "202": { + "headers": { + "location": "https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/links/{linkName}/operationResults/{operationId}?api-version={api-version}" + } + }, "204": {} } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json index 0ff1ecb9d2e0..c8d7a0aba9de 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json @@ -9,6 +9,11 @@ }, "responses": { "200": {}, + "202": { + "headers": { + "location": "https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/links/{linkReferenceName}/operationResults/{operationId}?api-version={api-version}" + } + }, "204": {} } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json index f12227617dd5..7cd28b13f526 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json @@ -40,8 +40,7 @@ "type": "Microsoft.Network/networkSecurityPerimeters/linkreferences", "properties": { "provisioningState": "Succeeded", - "autoApprovedRemotePerimeterId": "", - "manualApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp3", + "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp3", "remotePerimeterGuid": "guid", "localInboundProfiles": [ "*" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 7e42e25a3bc0..9c40797dd63d 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1071,7 +1071,7 @@ } }, "x-ms-examples": { - "NspProfilesList": { + "NspLinkList": { "$ref": "./examples/NspLinkList.json" } } @@ -1282,7 +1282,7 @@ ], "responses": { "200": { - "description": "OK - Returns the list of NSP linkreferences.", + "description": "OK - Returns the list of NSP linkReferences.", "schema": { "$ref": "#/definitions/NspLinkReferenceListResult" } @@ -1295,7 +1295,7 @@ } }, "x-ms-examples": { - "NspProfilesList": { + "NspLinkReferenceList": { "$ref": "./examples/NspLinkReferenceList.json" } } @@ -2030,7 +2030,6 @@ }, "status": { "type": "string", - "readOnly": true, "description": "The NSP linkReference state.", "enum": [ "Approved", From bfbae277f6a1cc7669d81dd7a2a959e43971985c Mon Sep 17 00:00:00 2001 From: vimimrot Date: Sun, 9 Oct 2022 11:13:51 +0530 Subject: [PATCH 03/18] fix errors --- .../networkSecurityPerimeter.json | 26 +++++++++++++------ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 9c40797dd63d..0b13b0aa7503 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1019,6 +1019,7 @@ } } }, + "x-ms-long-running-operation": true, "x-ms-examples": { "NspLinkDelete": { "$ref": "./examples/NspLinkDelete.json" @@ -1243,6 +1244,7 @@ } } }, + "x-ms-long-running-operation": true, "x-ms-examples": { "NspLinkReferenceDelete": { "$ref": "./examples/NspLinkReferenceDelete.json" @@ -1872,7 +1874,8 @@ "type": "string" }, "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles.", - "default": ["*"] + "default": "[*]", + "uniqueItems": true }, "localOutboundProfiles": { "type": "array", @@ -1880,7 +1883,8 @@ "type": "string" }, "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles.", - "default": ["*"] + "default": "[ * ]", + "uniqueItems": true }, "remoteInboundProfiles": { "type": "array", @@ -1888,7 +1892,8 @@ "type": "string" }, "description": "Remote Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles. This property can only be updated in auto-approval mode.", - "default": ["*"] + "default": "[ * ]", + "uniqueItems": true }, "remoteOutboundProfiles": { "type": "array", @@ -1896,7 +1901,8 @@ "type": "string" }, "description": "Remote Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles. This property can only be updated in auto-approval mode.", - "default": ["*"] + "default": "[ * ]", + "uniqueItems": true }, "description": { "type": "string", @@ -1996,7 +2002,8 @@ "type": "string" }, "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles.", - "default": ["*"] + "default": "[ * ]", + "uniqueItems": true }, "localOutboundProfiles": { "type": "array", @@ -2004,7 +2011,8 @@ "type": "string" }, "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles.", - "default": ["*"] + "default": "[ * ]", + "uniqueItems": true }, "remoteInboundProfiles": { "type": "array", @@ -2013,7 +2021,8 @@ }, "readOnly": true, "description": "Remote Inbound profile names to which Inbound is allowed. '*' value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from remote perimeter.", - "default": ["*"] + "default": "[ * ]", + "uniqueItems": true }, "remoteOutboundProfiles": { "type": "array", @@ -2022,7 +2031,8 @@ }, "readOnly": true, "description": "Remote Outbound profile names from which Outbound is allowed. '*' value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from remote perimeter.", - "default": ["*"] + "default": "[ * ]", + "uniqueItems": true }, "description": { "type": "string", From 857cd086206bcc950d87e5556bec43afd3a38b89 Mon Sep 17 00:00:00 2001 From: vimimrot Date: Sun, 9 Oct 2022 12:08:28 +0530 Subject: [PATCH 04/18] fix error --- .../examples/NspLinkGet.json | 38 +++++----- .../examples/NspLinkList.json | 76 +++++++++---------- .../examples/NspLinkPut.json | 76 +++++++++---------- .../examples/NspLinkReferenceGet.json | 36 ++++----- .../examples/NspLinkReferenceList.json | 72 +++++++++--------- .../examples/NspLinkReferencePut.json | 46 ++++++----- 6 files changed, 174 insertions(+), 170 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json index 65c7e0e1db4f..af260ea1ec4c 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json @@ -15,25 +15,25 @@ "type": "Microsoft.Network/networkSecurityPerimeters/links", "location": "resource location", "properties": { - "provisioningState": "Succeeded", - "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", - "manualApprovedRemotePerimeterId": "", - "remotePerimeterGuid": "guid", - "localInboundProfiles": [ - "*" - ], - "localOutboundProfiles": [ - "*" - ], - "remoteInboundProfiles": [ - "*" - ], - "remoteOutboundProfiles": [ - "*" - ], - "description": "Auto Approved", - "status": "Approved" - } + "provisioningState": "Succeeded", + "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", + "manualApprovedRemotePerimeterId": "", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Auto Approved", + "status": "Approved" + } } } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json index 7c6aa251eb4b..bf1357fcd191 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json @@ -16,25 +16,25 @@ "type": "Microsoft.Network/networkSecurityPerimeters/links", "location": "resource location", "properties": { - "provisioningState": "Succeeded", - "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", - "manualApprovedRemotePerimeterId": "", - "remotePerimeterGuid": "guid", - "localInboundProfiles": [ - "*" - ], - "localOutboundProfiles": [ - "*" - ], - "remoteInboundProfiles": [ - "*" - ], - "remoteOutboundProfiles": [ - "*" - ], - "description": "Auto Approved", - "status": "Approved" - } + "provisioningState": "Succeeded", + "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", + "manualApprovedRemotePerimeterId": "", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Auto Approved", + "status": "Approved" + } }, { "name": "link2", @@ -42,25 +42,25 @@ "type": "Microsoft.Network/networkSecurityPerimeters/links", "location": "resource location", "properties": { - "provisioningState": "Succeeded", - "autoApprovedRemotePerimeterId": "", - "manualApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp3", - "remotePerimeterGuid": "guid", - "localInboundProfiles": [ - "*" - ], - "localOutboundProfiles": [ - "*" - ], - "remoteInboundProfiles": [ - "*" - ], - "remoteOutboundProfiles": [ - "*" - ], - "description": "Please approve the request for link creation.", - "status": "Approved" - } + "provisioningState": "Succeeded", + "autoApprovedRemotePerimeterId": "", + "manualApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp3", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Please approve the request for link creation.", + "status": "Approved" + } } ], "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links?api-version=2021-02-01-preview&$skipToken=10" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json index 00c6418bfe3c..be06b5984daf 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json @@ -20,25 +20,25 @@ "type": "Microsoft.Network/networkSecurityPerimeters/links", "location": "resource location", "properties": { - "provisioningState": "Succeeded", - "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", - "manualApprovedRemotePerimeterId": "", - "remotePerimeterGuid": "guid", - "localInboundProfiles": [ - "*" - ], - "localOutboundProfiles": [ - "*" - ], - "remoteInboundProfiles": [ - "*" - ], - "remoteOutboundProfiles": [ - "*" - ], - "description": "Auto Approved", - "status": "Approved" - } + "provisioningState": "Succeeded", + "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", + "manualApprovedRemotePerimeterId": "", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Auto Approved", + "status": "Approved" + } } }, "201": { @@ -48,25 +48,25 @@ "type": "Microsoft.Network/networkSecurityPerimeters/links", "location": "resource location", "properties": { - "provisioningState": "Succeeded", - "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", - "manualApprovedRemotePerimeterId": "", - "remotePerimeterGuid": "guid", - "localInboundProfiles": [ - "*" - ], - "localOutboundProfiles": [ - "*" - ], - "remoteInboundProfiles": [ - "*" - ], - "remoteOutboundProfiles": [ - "*" - ], - "description": "Auto Approved", - "status": "Approved" - } + "provisioningState": "Succeeded", + "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", + "manualApprovedRemotePerimeterId": "", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Auto Approved", + "status": "Approved" + } } } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json index 08f1df55c621..1e4514b65720 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json @@ -14,24 +14,24 @@ "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences/link1-guid", "type": "Microsoft.Network/networkSecurityPerimeters/linkreferences", "properties": { - "provisioningState": "Succeeded", - "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", - "remotePerimeterGuid": "guid", - "localInboundProfiles": [ - "*" - ], - "localOutboundProfiles": [ - "*" - ], - "remoteInboundProfiles": [ - "*" - ], - "remoteOutboundProfiles": [ - "*" - ], - "description": "Auto Approved", - "status": "Approved" - } + "provisioningState": "Succeeded", + "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Auto Approved", + "status": "Approved" + } } } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json index 7cd28b13f526..5fbcc91cfae4 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json @@ -15,48 +15,48 @@ "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences/link1-guid", "type": "Microsoft.Network/networkSecurityPerimeters/linkreferences", "properties": { - "provisioningState": "Succeeded", - "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", - "remotePerimeterGuid": "guid", - "localInboundProfiles": [ - "*" - ], - "localOutboundProfiles": [ - "*" - ], - "remoteInboundProfiles": [ - "*" - ], - "remoteOutboundProfiles": [ - "*" - ], - "description": "Auto Approved", - "status": "Approved" - } + "provisioningState": "Succeeded", + "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Auto Approved", + "status": "Approved" + } }, { "name": "link2-guid", "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences/link2-guid", "type": "Microsoft.Network/networkSecurityPerimeters/linkreferences", "properties": { - "provisioningState": "Succeeded", - "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp3", - "remotePerimeterGuid": "guid", - "localInboundProfiles": [ - "*" - ], - "localOutboundProfiles": [ - "*" - ], - "remoteInboundProfiles": [ - "*" - ], - "remoteOutboundProfiles": [ - "*" - ], - "description": "Approved link creation request.", - "status": "Approved" - } + "provisioningState": "Succeeded", + "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp3", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "*" + ], + "localOutboundProfiles": [ + "*" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Approved link creation request.", + "status": "Approved" + } } ], "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences?api-version=2021-02-01-preview&$skipToken=10" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferencePut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferencePut.json index 9cad393d565f..df7f0e39ac9e 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferencePut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferencePut.json @@ -9,13 +9,15 @@ "parameters": { "properties": { "localInboundProfiles": [ - "Profile1", "Profile2" + "Profile1", + "Profile2" ], "localOutboundProfiles": [ - "Profile1", "Profile2" + "Profile1", + "Profile2" ], "description": "Request Approved", - "status": "Approved" + "status": "Approved" } } }, @@ -26,24 +28,26 @@ "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkReferences/link1-guid", "type": "Microsoft.Network/networkSecurityPerimeters/linkReferences", "properties": { - "provisioningState": "Succeeded", - "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", - "remotePerimeterGuid": "guid", - "localInboundProfiles": [ - "Profile1", "Profile2" - ], - "localOutboundProfiles": [ - "Profile1", "Profile2" - ], - "remoteInboundProfiles": [ - "*" - ], - "remoteOutboundProfiles": [ - "*" - ], - "description": "Request Approved.", - "status": "Approved" - } + "provisioningState": "Succeeded", + "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", + "remotePerimeterGuid": "guid", + "localInboundProfiles": [ + "Profile1", + "Profile2" + ], + "localOutboundProfiles": [ + "Profile1", + "Profile2" + ], + "remoteInboundProfiles": [ + "*" + ], + "remoteOutboundProfiles": [ + "*" + ], + "description": "Request Approved.", + "status": "Approved" + } } } } From 46c53797f94e33133d1f0280d6ad097c6dfcf3dd Mon Sep 17 00:00:00 2001 From: vimimrot Date: Mon, 10 Oct 2022 11:52:47 +0530 Subject: [PATCH 05/18] fix error --- .../2021-02-01-preview/networkSecurityPerimeter.json | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 0b13b0aa7503..925f92cb41b4 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1809,6 +1809,7 @@ "description": "Properties of the network security perimeter link" }, "name": { + "readOnly": true, "type": "string", "description": "The name of the link resource that is unique within a perimeter. This name can be used to access the resource." }, @@ -1823,11 +1824,6 @@ "description": "Resource type." } }, - "allOf": [ - { - "$ref": "./network.json#/definitions/Resource" - } - ], "description": "The network security perimeter link resource" }, "NspLinkListResult": { @@ -1940,6 +1936,7 @@ "description": "Properties of the network security perimeter linkReference" }, "name": { + "readOnly": true, "type": "string", "description": "The name of the linkReference resource that is unique within a perimeter. This name can be used to access the resource." }, @@ -1954,11 +1951,6 @@ "description": "Resource type." } }, - "allOf": [ - { - "$ref": "./network.json#/definitions/Resource" - } - ], "description": "The network security perimeter linkReference resource" }, "NspLinkReferenceListResult": { From c681d5bd052b01a69426fa775fbaf5ce9d9ea4d2 Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Mon, 10 Oct 2022 15:31:10 +0530 Subject: [PATCH 06/18] fix lint error --- .../2021-02-01-preview/networkSecurityPerimeter.json | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 925f92cb41b4..f40c3ea50dde 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1824,6 +1824,11 @@ "description": "Resource type." } }, + "allOf": [ + { + "$ref": "./network.json#/definitions/ProxyResource" + } + ], "description": "The network security perimeter link resource" }, "NspLinkListResult": { @@ -1951,6 +1956,11 @@ "description": "Resource type." } }, + "allOf": [ + { + "$ref": "./network.json#/definitions/ProxyResource" + } + ], "description": "The network security perimeter linkReference resource" }, "NspLinkReferenceListResult": { From 853ac12ed40833b30158f4847f164b5f998cc0e9 Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Tue, 11 Oct 2022 11:23:39 +0530 Subject: [PATCH 07/18] skip location from proxy resource --- .../preview/2021-02-01-preview/examples/NspLinkGet.json | 1 - .../preview/2021-02-01-preview/examples/NspLinkList.json | 2 -- .../preview/2021-02-01-preview/examples/NspLinkPut.json | 2 -- 3 files changed, 5 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json index af260ea1ec4c..fc73db0c3532 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json @@ -13,7 +13,6 @@ "name": "link1", "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link1", "type": "Microsoft.Network/networkSecurityPerimeters/links", - "location": "resource location", "properties": { "provisioningState": "Succeeded", "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json index bf1357fcd191..9a438a110d25 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json @@ -14,7 +14,6 @@ "name": "link1", "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link1", "type": "Microsoft.Network/networkSecurityPerimeters/links", - "location": "resource location", "properties": { "provisioningState": "Succeeded", "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", @@ -40,7 +39,6 @@ "name": "link2", "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link2", "type": "Microsoft.Network/networkSecurityPerimeters/links", - "location": "resource location", "properties": { "provisioningState": "Succeeded", "autoApprovedRemotePerimeterId": "", diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json index be06b5984daf..6da01a29b562 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json @@ -18,7 +18,6 @@ "name": "link1", "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link1", "type": "Microsoft.Network/networkSecurityPerimeters/links", - "location": "resource location", "properties": { "provisioningState": "Succeeded", "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", @@ -46,7 +45,6 @@ "name": "link1", "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link1", "type": "Microsoft.Network/networkSecurityPerimeters/links", - "location": "resource location", "properties": { "provisioningState": "Succeeded", "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", From 105dd1f69ae4fa683ca6be584f30a6c479876d8a Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Tue, 11 Oct 2022 15:09:30 +0530 Subject: [PATCH 08/18] fix sdk error --- .../networkSecurityPerimeter.json | 32 ++++++++++++++----- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index f40c3ea50dde..b912638bc046 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1875,7 +1875,9 @@ "type": "string" }, "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles.", - "default": "[*]", + "default": [ + "*" + ], "uniqueItems": true }, "localOutboundProfiles": { @@ -1884,7 +1886,9 @@ "type": "string" }, "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles.", - "default": "[ * ]", + "default": [ + "*" + ], "uniqueItems": true }, "remoteInboundProfiles": { @@ -1893,7 +1897,9 @@ "type": "string" }, "description": "Remote Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles. This property can only be updated in auto-approval mode.", - "default": "[ * ]", + "default": [ + "*" + ], "uniqueItems": true }, "remoteOutboundProfiles": { @@ -1902,7 +1908,9 @@ "type": "string" }, "description": "Remote Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles. This property can only be updated in auto-approval mode.", - "default": "[ * ]", + "default": [ + "*" + ], "uniqueItems": true }, "description": { @@ -2004,7 +2012,9 @@ "type": "string" }, "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles.", - "default": "[ * ]", + "default": [ + "*" + ], "uniqueItems": true }, "localOutboundProfiles": { @@ -2013,7 +2023,9 @@ "type": "string" }, "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles.", - "default": "[ * ]", + "default": [ + "*" + ], "uniqueItems": true }, "remoteInboundProfiles": { @@ -2023,7 +2035,9 @@ }, "readOnly": true, "description": "Remote Inbound profile names to which Inbound is allowed. '*' value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from remote perimeter.", - "default": "[ * ]", + "default": [ + "*" + ], "uniqueItems": true }, "remoteOutboundProfiles": { @@ -2033,7 +2047,9 @@ }, "readOnly": true, "description": "Remote Outbound profile names from which Outbound is allowed. '*' value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from remote perimeter.", - "default": "[ * ]", + "default": [ + "*" + ], "uniqueItems": true }, "description": { From 04b7f77710efd61eab053b9eb5bf8700c91e82ad Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Tue, 11 Oct 2022 16:48:50 +0530 Subject: [PATCH 09/18] fix linter check --- .../networkSecurityPerimeter.json | 32 +++++-------------- 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index b912638bc046..8e8962c02e1c 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1875,9 +1875,7 @@ "type": "string" }, "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles.", - "default": [ - "*" - ], + "default": "['*']", "uniqueItems": true }, "localOutboundProfiles": { @@ -1886,9 +1884,7 @@ "type": "string" }, "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles.", - "default": [ - "*" - ], + "default": "['*']", "uniqueItems": true }, "remoteInboundProfiles": { @@ -1897,9 +1893,7 @@ "type": "string" }, "description": "Remote Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles. This property can only be updated in auto-approval mode.", - "default": [ - "*" - ], + "default": "['*']", "uniqueItems": true }, "remoteOutboundProfiles": { @@ -1908,9 +1902,7 @@ "type": "string" }, "description": "Remote Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles. This property can only be updated in auto-approval mode.", - "default": [ - "*" - ], + "default": "['*']", "uniqueItems": true }, "description": { @@ -2012,9 +2004,7 @@ "type": "string" }, "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles.", - "default": [ - "*" - ], + "default": "['*']", "uniqueItems": true }, "localOutboundProfiles": { @@ -2023,9 +2013,7 @@ "type": "string" }, "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles.", - "default": [ - "*" - ], + "default": "['*']", "uniqueItems": true }, "remoteInboundProfiles": { @@ -2035,9 +2023,7 @@ }, "readOnly": true, "description": "Remote Inbound profile names to which Inbound is allowed. '*' value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from remote perimeter.", - "default": [ - "*" - ], + "default": "['*']", "uniqueItems": true }, "remoteOutboundProfiles": { @@ -2047,9 +2033,7 @@ }, "readOnly": true, "description": "Remote Outbound profile names from which Outbound is allowed. '*' value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from remote perimeter.", - "default": [ - "*" - ], + "default": "['*']", "uniqueItems": true }, "description": { From c5e35fade3a2be88d2f1f8df81e2f9c9e262a710 Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Tue, 11 Oct 2022 20:02:22 +0530 Subject: [PATCH 10/18] immutability flag changes --- .../networkSecurityPerimeter.json | 52 +++++++++++++------ 1 file changed, 37 insertions(+), 15 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 8e8962c02e1c..a72b83438d66 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -966,7 +966,7 @@ ], "responses": { "200": { - "description": "Updated - Existing access rule is updated. Returns the resource.", + "description": "Updated - Existing NspLink resource is updated. Returns the resource.", "schema": { "$ref": "#/definitions/NspLink" } @@ -1183,7 +1183,7 @@ "NspLinkReferences" ], "operationId": "NspLinkReferences_CreateOrUpdate", - "description": "Creates or updates a NSP linkReference.", + "description": "Updates a NSP linkReference.", "parameters": [ { "name": "parameters", @@ -1197,7 +1197,7 @@ ], "responses": { "200": { - "description": "Updated - Existing access rule is updated. Returns the resource.", + "description": "Updated - Existing NSP linkReference is updated. Returns the resource.", "schema": { "$ref": "#/definitions/NspLinkReference" } @@ -1858,11 +1858,19 @@ }, "autoApprovedRemotePerimeterId": { "type": "string", - "description": "Perimeter ARM Id for the remote NSP with which the link gets created in Auto-approval mode. Used when the NSP admin have access to approve connections on the remote NSP resource." + "description": "Perimeter ARM Id for the remote NSP with which the link gets created in Auto-approval mode. Used when the NSP admin have access to approve connections on the remote NSP resource.", + "x-ms-mutability": [ + "read", + "create" + ] }, "manualApprovedRemotePerimeterId": { "type": "string", - "description": "Perimeter ARM Id for the remote NSP with which the link gets created. Used when the NSP admin does not have access to approve connections on the remote NSP resource." + "description": "Perimeter ARM Id for the remote NSP with which the link gets created. Used when the NSP admin does not have access to approve connections on the remote NSP resource.", + "x-ms-mutability": [ + "read", + "create" + ] }, "remotePerimeterGuid": { "readOnly": true, @@ -1875,7 +1883,9 @@ "type": "string" }, "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles.", - "default": "['*']", + "default": [ + "*" + ], "uniqueItems": true }, "localOutboundProfiles": { @@ -1884,7 +1894,9 @@ "type": "string" }, "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles.", - "default": "['*']", + "default": [ + "*" + ], "uniqueItems": true }, "remoteInboundProfiles": { @@ -1893,7 +1905,9 @@ "type": "string" }, "description": "Remote Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles. This property can only be updated in auto-approval mode.", - "default": "['*']", + "default": [ + "*" + ], "uniqueItems": true }, "remoteOutboundProfiles": { @@ -1902,7 +1916,9 @@ "type": "string" }, "description": "Remote Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles. This property can only be updated in auto-approval mode.", - "default": "['*']", + "default": [ + "*" + ], "uniqueItems": true }, "description": { @@ -2004,7 +2020,9 @@ "type": "string" }, "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles.", - "default": "['*']", + "default": [ + "*" + ], "uniqueItems": true }, "localOutboundProfiles": { @@ -2013,7 +2031,9 @@ "type": "string" }, "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles.", - "default": "['*']", + "default": [ + "*" + ], "uniqueItems": true }, "remoteInboundProfiles": { @@ -2023,8 +2043,9 @@ }, "readOnly": true, "description": "Remote Inbound profile names to which Inbound is allowed. '*' value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from remote perimeter.", - "default": "['*']", - "uniqueItems": true + "default": [ + "*" + ] }, "remoteOutboundProfiles": { "type": "array", @@ -2033,8 +2054,9 @@ }, "readOnly": true, "description": "Remote Outbound profile names from which Outbound is allowed. '*' value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from remote perimeter.", - "default": "['*']", - "uniqueItems": true + "default": [ + "*" + ] }, "description": { "type": "string", From 824cb7d2d8ec31e40fed255d82343c0761a6514a Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Wed, 12 Oct 2022 01:33:50 +0530 Subject: [PATCH 11/18] removed v2 properties. --- .../examples/NspLinkGet.json | 1 - .../examples/NspLinkList.json | 26 -------- .../examples/NspLinkReferenceDelete.json | 2 +- .../examples/NspLinkReferenceList.json | 24 -------- .../examples/NspLinkReferencePut.json | 54 ----------------- .../networkSecurityPerimeter.json | 60 ++++--------------- 6 files changed, 13 insertions(+), 154 deletions(-) delete mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferencePut.json diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json index fc73db0c3532..3754cc76fe97 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json @@ -16,7 +16,6 @@ "properties": { "provisioningState": "Succeeded", "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", - "manualApprovedRemotePerimeterId": "", "remotePerimeterGuid": "guid", "localInboundProfiles": [ "*" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json index 9a438a110d25..e45374f95816 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json @@ -17,7 +17,6 @@ "properties": { "provisioningState": "Succeeded", "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", - "manualApprovedRemotePerimeterId": "", "remotePerimeterGuid": "guid", "localInboundProfiles": [ "*" @@ -34,31 +33,6 @@ "description": "Auto Approved", "status": "Approved" } - }, - { - "name": "link2", - "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link2", - "type": "Microsoft.Network/networkSecurityPerimeters/links", - "properties": { - "provisioningState": "Succeeded", - "autoApprovedRemotePerimeterId": "", - "manualApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp3", - "remotePerimeterGuid": "guid", - "localInboundProfiles": [ - "*" - ], - "localOutboundProfiles": [ - "*" - ], - "remoteInboundProfiles": [ - "*" - ], - "remoteOutboundProfiles": [ - "*" - ], - "description": "Please approve the request for link creation.", - "status": "Approved" - } } ], "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links?api-version=2021-02-01-preview&$skipToken=10" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json index c8d7a0aba9de..28bdc542d0aa 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json @@ -11,7 +11,7 @@ "200": {}, "202": { "headers": { - "location": "https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/links/{linkReferenceName}/operationResults/{operationId}?api-version={api-version}" + "location": "https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/linkreferences/{linkReferenceName}/operationResults/{operationId}?api-version={api-version}" } }, "204": {} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json index 5fbcc91cfae4..b0ecd523bbe6 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json @@ -33,30 +33,6 @@ "description": "Auto Approved", "status": "Approved" } - }, - { - "name": "link2-guid", - "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences/link2-guid", - "type": "Microsoft.Network/networkSecurityPerimeters/linkreferences", - "properties": { - "provisioningState": "Succeeded", - "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp3", - "remotePerimeterGuid": "guid", - "localInboundProfiles": [ - "*" - ], - "localOutboundProfiles": [ - "*" - ], - "remoteInboundProfiles": [ - "*" - ], - "remoteOutboundProfiles": [ - "*" - ], - "description": "Approved link creation request.", - "status": "Approved" - } } ], "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences?api-version=2021-02-01-preview&$skipToken=10" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferencePut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferencePut.json deleted file mode 100644 index df7f0e39ac9e..000000000000 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferencePut.json +++ /dev/null @@ -1,54 +0,0 @@ -{ - "title": "Approve NSP link request", - "parameters": { - "api-version": "2021-02-01-preview", - "subscriptionId": "subId", - "resourceGroupName": "rg1", - "networkSecurityPerimeterName": "nsp2", - "linkReferenceName": "link1-guid", - "parameters": { - "properties": { - "localInboundProfiles": [ - "Profile1", - "Profile2" - ], - "localOutboundProfiles": [ - "Profile1", - "Profile2" - ], - "description": "Request Approved", - "status": "Approved" - } - } - }, - "responses": { - "200": { - "body": { - "name": "link1-guid", - "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkReferences/link1-guid", - "type": "Microsoft.Network/networkSecurityPerimeters/linkReferences", - "properties": { - "provisioningState": "Succeeded", - "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", - "remotePerimeterGuid": "guid", - "localInboundProfiles": [ - "Profile1", - "Profile2" - ], - "localOutboundProfiles": [ - "Profile1", - "Profile2" - ], - "remoteInboundProfiles": [ - "*" - ], - "remoteOutboundProfiles": [ - "*" - ], - "description": "Request Approved.", - "status": "Approved" - } - } - } - } -} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index a72b83438d66..b4991445a29a 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1178,43 +1178,6 @@ } } }, - "put": { - "tags": [ - "NspLinkReferences" - ], - "operationId": "NspLinkReferences_CreateOrUpdate", - "description": "Updates a NSP linkReference.", - "parameters": [ - { - "name": "parameters", - "in": "body", - "required": true, - "schema": { - "$ref": "#/definitions/NspLinkReference" - }, - "description": "Parameters that hold the NspLinkReference resource to be created/updated." - } - ], - "responses": { - "200": { - "description": "Updated - Existing NSP linkReference is updated. Returns the resource.", - "schema": { - "$ref": "#/definitions/NspLinkReference" - } - }, - "default": { - "description": "Error response describing why the operation failed.", - "schema": { - "$ref": "./network.json#/definitions/CloudError" - } - } - }, - "x-ms-examples": { - "NspLinkReferencesPut": { - "$ref": "./examples/NspLinkReferencePut.json" - } - } - }, "delete": { "tags": [ "NspLinkReferences" @@ -1858,15 +1821,7 @@ }, "autoApprovedRemotePerimeterId": { "type": "string", - "description": "Perimeter ARM Id for the remote NSP with which the link gets created in Auto-approval mode. Used when the NSP admin have access to approve connections on the remote NSP resource.", - "x-ms-mutability": [ - "read", - "create" - ] - }, - "manualApprovedRemotePerimeterId": { - "type": "string", - "description": "Perimeter ARM Id for the remote NSP with which the link gets created. Used when the NSP admin does not have access to approve connections on the remote NSP resource.", + "description": "Perimeter ARM Id for the remote NSP with which the link gets created in Auto-approval mode. Used when the NSP admin have access on the remote NSP resource.", "x-ms-mutability": [ "read", "create" @@ -2060,11 +2015,12 @@ }, "description": { "type": "string", - "description": "A message can be send to the remote NSP link admin with the connection response. Restricted to 140 chars." + "readOnly": true, + "description": "A message sent by the remote NSP link admin for connection request. In case of Auto-approved flow, it is default to 'Auto Approved'." }, "status": { "type": "string", - "description": "The NSP linkReference state.", + "description": "The NSP linkReference state. It cannot be changed if link is created in auto-approval mode.", "enum": [ "Approved", "Pending", @@ -2161,6 +2117,14 @@ "type": "string", "x-ms-parameter-location": "method" }, + "NetworkSecurityPerimeterProfileParameter": { + "name": "networkSecurityPerimeterProfile", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the network security perimeter profile.", + "x-ms-parameter-location": "method" + }, "LocationParameter": { "name": "location", "in": "path", From 0f3fbb089110389f620733cede27be9b1cce5778 Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Wed, 12 Oct 2022 01:41:23 +0530 Subject: [PATCH 12/18] minor fix --- .../preview/2021-02-01-preview/examples/NspLinkPut.json | 2 -- 1 file changed, 2 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json index 6da01a29b562..4a1120e0aaee 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json @@ -21,7 +21,6 @@ "properties": { "provisioningState": "Succeeded", "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", - "manualApprovedRemotePerimeterId": "", "remotePerimeterGuid": "guid", "localInboundProfiles": [ "*" @@ -48,7 +47,6 @@ "properties": { "provisioningState": "Succeeded", "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", - "manualApprovedRemotePerimeterId": "", "remotePerimeterGuid": "guid", "localInboundProfiles": [ "*" From 4dcdab0c4cea1414de0f4f3f44399c7d21b3d458 Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Wed, 12 Oct 2022 09:43:16 +0530 Subject: [PATCH 13/18] removed default value as it is not supported by swagger --- .../networkSecurityPerimeter.json | 40 ++++--------------- 1 file changed, 8 insertions(+), 32 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index b4991445a29a..c97311028f2a 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1837,10 +1837,7 @@ "items": { "type": "string" }, - "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles.", - "default": [ - "*" - ], + "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles. It's default value is [ '*' ].", "uniqueItems": true }, "localOutboundProfiles": { @@ -1848,10 +1845,7 @@ "items": { "type": "string" }, - "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles.", - "default": [ - "*" - ], + "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles. It's default value is [ '*' ].", "uniqueItems": true }, "remoteInboundProfiles": { @@ -1859,10 +1853,7 @@ "items": { "type": "string" }, - "description": "Remote Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles. This property can only be updated in auto-approval mode.", - "default": [ - "*" - ], + "description": "Remote Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles. This property can only be updated in auto-approval mode. It's default value is [ '*' ].", "uniqueItems": true }, "remoteOutboundProfiles": { @@ -1870,10 +1861,7 @@ "items": { "type": "string" }, - "description": "Remote Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles. This property can only be updated in auto-approval mode.", - "default": [ - "*" - ], + "description": "Remote Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles. This property can only be updated in auto-approval mode. It's default value is [ '*' ].", "uniqueItems": true }, "description": { @@ -1974,10 +1962,7 @@ "items": { "type": "string" }, - "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles.", - "default": [ - "*" - ], + "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles. It's default value is [ '*' ].", "uniqueItems": true }, "localOutboundProfiles": { @@ -1985,10 +1970,7 @@ "items": { "type": "string" }, - "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles.", - "default": [ - "*" - ], + "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles. It's default value is [ '*' ].", "uniqueItems": true }, "remoteInboundProfiles": { @@ -1997,10 +1979,7 @@ "type": "string" }, "readOnly": true, - "description": "Remote Inbound profile names to which Inbound is allowed. '*' value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from remote perimeter.", - "default": [ - "*" - ] + "description": "Remote Inbound profile names to which Inbound is allowed. '*' value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from remote perimeter." }, "remoteOutboundProfiles": { "type": "array", @@ -2008,10 +1987,7 @@ "type": "string" }, "readOnly": true, - "description": "Remote Outbound profile names from which Outbound is allowed. '*' value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from remote perimeter.", - "default": [ - "*" - ] + "description": "Remote Outbound profile names from which Outbound is allowed. '*' value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from remote perimeter." }, "description": { "type": "string", From 912bf70b44dd25cda4f8d0127a278183533913f9 Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Wed, 12 Oct 2022 15:18:33 +0530 Subject: [PATCH 14/18] make outbound profile read only --- .../examples/NspLinkPut.json | 6 ------ .../networkSecurityPerimeter.json | 19 +++++++++++-------- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json index 4a1120e0aaee..4108e119654a 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json @@ -25,15 +25,9 @@ "localInboundProfiles": [ "*" ], - "localOutboundProfiles": [ - "*" - ], "remoteInboundProfiles": [ "*" ], - "remoteOutboundProfiles": [ - "*" - ], "description": "Auto Approved", "status": "Approved" } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index c97311028f2a..2d656fe74a5a 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1837,7 +1837,7 @@ "items": { "type": "string" }, - "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles. It's default value is [ '*' ].", + "description": "Local Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles. It's default value is ['*'].", "uniqueItems": true }, "localOutboundProfiles": { @@ -1845,7 +1845,8 @@ "items": { "type": "string" }, - "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles. It's default value is [ '*' ].", + "readOnly": true, + "description": "Local Outbound profile names from which Outbound is allowed. In current version, it's value is set to ['*'] to allow outbound from all profiles. In later version, user will be able to modify it.", "uniqueItems": true }, "remoteInboundProfiles": { @@ -1853,7 +1854,7 @@ "items": { "type": "string" }, - "description": "Remote Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles. This property can only be updated in auto-approval mode. It's default value is [ '*' ].", + "description": "Remote Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles. This property can only be updated in auto-approval mode. It's default value is ['*'].", "uniqueItems": true }, "remoteOutboundProfiles": { @@ -1861,7 +1862,8 @@ "items": { "type": "string" }, - "description": "Remote Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles. This property can only be updated in auto-approval mode. It's default value is [ '*' ].", + "readOnly": true, + "description": "Remote Outbound profile names from which Outbound is allowed. In current version, it's value is set to ['*'] to allow outbound from all profiles. In later version, user will be able to modify it.", "uniqueItems": true }, "description": { @@ -1962,7 +1964,7 @@ "items": { "type": "string" }, - "description": "Local Inbound profile names to which Inbound is allowed. Use '*' to allow inbound to all profiles. It's default value is [ '*' ].", + "description": "Local Inbound profile names to which Inbound is allowed. Use ['*'] to allow inbound to all profiles. It's default value is ['*'].", "uniqueItems": true }, "localOutboundProfiles": { @@ -1970,7 +1972,8 @@ "items": { "type": "string" }, - "description": "Local Outbound profile names from which Outbound is allowed. Use '*' to allow outbound from all profiles. It's default value is [ '*' ].", + "readOnly": true, + "description": "Local Outbound profile names from which Outbound is allowed. Use ['*'] to allow outbound from all profiles. It's default value is ['*'].", "uniqueItems": true }, "remoteInboundProfiles": { @@ -1979,7 +1982,7 @@ "type": "string" }, "readOnly": true, - "description": "Remote Inbound profile names to which Inbound is allowed. '*' value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from remote perimeter." + "description": "Remote Inbound profile names to which Inbound is allowed. ['*'] value implies inbound is allowed to all profiles at remote perimeter. This property can only be updated from remote perimeter." }, "remoteOutboundProfiles": { "type": "array", @@ -1987,7 +1990,7 @@ "type": "string" }, "readOnly": true, - "description": "Remote Outbound profile names from which Outbound is allowed. '*' value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from remote perimeter." + "description": "Remote Outbound profile names from which Outbound is allowed. ['*'] value implies outbound is allowed from all profiles at remote perimeter. This property can only be updated from remote perimeter." }, "description": { "type": "string", From 9d6705e66779b8cdf70b79dd3fe77ccf2ca2f96c Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Wed, 12 Oct 2022 16:31:37 +0530 Subject: [PATCH 15/18] minor change --- .../preview/2021-02-01-preview/networkSecurityPerimeter.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 2d656fe74a5a..71b59d407be3 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1886,7 +1886,7 @@ } } }, - "description": "Properties of NSP Link." + "description": "Properties of NSP Link resource." }, "NspLinkReconcile": { "type": "object", From 576d99cdfb19898fa206085283d7260f030a3144 Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Thu, 13 Oct 2022 00:28:23 +0530 Subject: [PATCH 16/18] add x-ms-long-running-operation-options --- .../preview/2021-02-01-preview/examples/NspLinkPut.json | 6 ++++++ .../2021-02-01-preview/networkSecurityPerimeter.json | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json index 4108e119654a..4a1120e0aaee 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json @@ -25,9 +25,15 @@ "localInboundProfiles": [ "*" ], + "localOutboundProfiles": [ + "*" + ], "remoteInboundProfiles": [ "*" ], + "remoteOutboundProfiles": [ + "*" + ], "description": "Auto Approved", "status": "Approved" } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 71b59d407be3..412d690b36b8 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1020,6 +1020,9 @@ } }, "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "location" + }, "x-ms-examples": { "NspLinkDelete": { "$ref": "./examples/NspLinkDelete.json" @@ -1208,6 +1211,9 @@ } }, "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "location" + }, "x-ms-examples": { "NspLinkReferenceDelete": { "$ref": "./examples/NspLinkReferenceDelete.json" From 5f9a78b67433d1b4d4e860c1b1d79c3bcaaf95a0 Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Fri, 14 Oct 2022 15:21:02 +0530 Subject: [PATCH 17/18] Fix review comments --- .../examples/NspLinkGet.json | 2 +- .../examples/NspLinkList.json | 2 +- .../examples/NspLinkPut.json | 6 +- .../examples/NspLinkReconcile.json | 9 +- .../examples/NspLinkReferenceGet.json | 2 +- .../examples/NspLinkReferenceList.json | 2 +- .../examples/NspLinkReferenceReconcile.json | 9 +- .../networkSecurityPerimeter.json | 82 ++----------------- 8 files changed, 18 insertions(+), 96 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json index 3754cc76fe97..a8c33fbee2a7 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json @@ -15,7 +15,7 @@ "type": "Microsoft.Network/networkSecurityPerimeters/links", "properties": { "provisioningState": "Succeeded", - "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", + "autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", "remotePerimeterGuid": "guid", "localInboundProfiles": [ "*" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json index e45374f95816..16732e5d5c67 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json @@ -16,7 +16,7 @@ "type": "Microsoft.Network/networkSecurityPerimeters/links", "properties": { "provisioningState": "Succeeded", - "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", + "autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", "remotePerimeterGuid": "guid", "localInboundProfiles": [ "*" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json index 4a1120e0aaee..3f533340be96 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json @@ -8,7 +8,7 @@ "linkName": "link1", "parameters": { "properties": { - "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2" + "autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2" } } }, @@ -20,7 +20,7 @@ "type": "Microsoft.Network/networkSecurityPerimeters/links", "properties": { "provisioningState": "Succeeded", - "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", + "autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", "remotePerimeterGuid": "guid", "localInboundProfiles": [ "*" @@ -46,7 +46,7 @@ "type": "Microsoft.Network/networkSecurityPerimeters/links", "properties": { "provisioningState": "Succeeded", - "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", + "autoApprovedRemotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", "remotePerimeterGuid": "guid", "localInboundProfiles": [ "*" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReconcile.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReconcile.json index c74a891b5af7..6fac375ace10 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReconcile.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReconcile.json @@ -5,14 +5,9 @@ "subscriptionId": "subId", "resourceGroupName": "rg1", "networkSecurityPerimeterName": "nsp1", - "linkName": "link1", - "parameters": { - "properties": {} - } + "linkName": "link1" }, "responses": { - "200": { - "body": {} - } + "200": {} } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json index 1e4514b65720..b9a98caac80f 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json @@ -15,7 +15,7 @@ "type": "Microsoft.Network/networkSecurityPerimeters/linkreferences", "properties": { "provisioningState": "Succeeded", - "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", + "remotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", "remotePerimeterGuid": "guid", "localInboundProfiles": [ "*" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json index b0ecd523bbe6..8b9e470eb1ec 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json @@ -16,7 +16,7 @@ "type": "Microsoft.Network/networkSecurityPerimeters/linkreferences", "properties": { "provisioningState": "Succeeded", - "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", + "remotePerimeterResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", "remotePerimeterGuid": "guid", "localInboundProfiles": [ "*" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceReconcile.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceReconcile.json index 1376dc99124d..7ff98263239a 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceReconcile.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceReconcile.json @@ -5,14 +5,9 @@ "subscriptionId": "subId", "resourceGroupName": "rg1", "networkSecurityPerimeterName": "nsp1", - "linkReferenceName": "link1-guid", - "parameters": { - "properties": {} - } + "linkReferenceName": "link1-guid" }, "responses": { - "200": { - "body": {} - } + "200": {} } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 412d690b36b8..1e2faa2b9bbb 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1105,23 +1105,9 @@ ], "operationId": "NspLinkReconcile_Post", "description": "Reconcile NSP link", - "parameters": [ - { - "name": "parameters", - "in": "body", - "required": true, - "schema": { - "$ref": "#/definitions/NspLinkReconcile" - }, - "description": "Parameters for NSP link reconcile" - } - ], "responses": { "200": { - "description": "Reconcile NSP link.", - "schema": { - "$ref": "#/definitions/NspLinkReconcile" - } + "description": "OK" }, "default": { "description": "Error response describing why the operation failed.", @@ -1296,23 +1282,9 @@ ], "operationId": "NspLinkReferenceReconcile_Post", "description": "Reconcile NSP linkReference", - "parameters": [ - { - "name": "parameters", - "in": "body", - "required": true, - "schema": { - "$ref": "#/definitions/NspLinkReferenceReconcile" - }, - "description": "Parameters for NSP linkReference reconcile" - } - ], "responses": { "200": { - "description": "Reconcile NSP linkReference.", - "schema": { - "$ref": "#/definitions/NspLinkReferenceReconcile" - } + "description": "OK" }, "default": { "description": "Error response describing why the operation failed.", @@ -1776,21 +1748,6 @@ "x-ms-client-flatten": true, "$ref": "#/definitions/NspLinkProperties", "description": "Properties of the network security perimeter link" - }, - "name": { - "readOnly": true, - "type": "string", - "description": "The name of the link resource that is unique within a perimeter. This name can be used to access the resource." - }, - "id": { - "readOnly": true, - "type": "string", - "description": "Identifier of the network security perimeter link in ARM id format." - }, - "type": { - "readOnly": true, - "type": "string", - "description": "Resource type." } }, "allOf": [ @@ -1825,9 +1782,9 @@ "$ref": "#/definitions/NSPProvisioningState", "description": "The provisioning state of the NSP Link resource." }, - "autoApprovedRemotePerimeterId": { + "autoApprovedRemotePerimeterResourceId": { "type": "string", - "description": "Perimeter ARM Id for the remote NSP with which the link gets created in Auto-approval mode. Used when the NSP admin have access on the remote NSP resource.", + "description": "Perimeter ARM Id for the remote NSP with which the link gets created in Auto-approval mode. It should be used when the NSP admin have Microsoft.Network/networkSecurityPerimeters/linkPerimeter/action permission on the remote NSP resource.", "x-ms-mutability": [ "read", "create" @@ -1852,7 +1809,7 @@ "type": "string" }, "readOnly": true, - "description": "Local Outbound profile names from which Outbound is allowed. In current version, it's value is set to ['*'] to allow outbound from all profiles. In later version, user will be able to modify it.", + "description": "Local Outbound profile names from which Outbound is allowed. In current version, it is readonly property and it's value is set to ['*'] to allow outbound from all profiles. In later version, user will be able to modify it.", "uniqueItems": true }, "remoteInboundProfiles": { @@ -1869,7 +1826,7 @@ "type": "string" }, "readOnly": true, - "description": "Remote Outbound profile names from which Outbound is allowed. In current version, it's value is set to ['*'] to allow outbound from all profiles. In later version, user will be able to modify it.", + "description": "Remote Outbound profile names from which Outbound is allowed. In current version, it is readonly property and it's value is set to ['*'] to allow outbound from all profiles. In later version, user will be able to modify it.", "uniqueItems": true }, "description": { @@ -1894,11 +1851,6 @@ }, "description": "Properties of NSP Link resource." }, - "NspLinkReconcile": { - "type": "object", - "properties": {}, - "description": "Request object for NSP link reconcile." - }, "NspLinkReference": { "type": "object", "properties": { @@ -1906,21 +1858,6 @@ "x-ms-client-flatten": true, "$ref": "#/definitions/NspLinkReferenceProperties", "description": "Properties of the network security perimeter linkReference" - }, - "name": { - "readOnly": true, - "type": "string", - "description": "The name of the linkReference resource that is unique within a perimeter. This name can be used to access the resource." - }, - "id": { - "readOnly": true, - "type": "string", - "description": "Identifier of the network security perimeter linkReference in ARM id format." - }, - "type": { - "readOnly": true, - "type": "string", - "description": "Resource type." } }, "allOf": [ @@ -1955,7 +1892,7 @@ "$ref": "#/definitions/NSPProvisioningState", "description": "The provisioning state of the NSP LinkReference resource." }, - "remotePerimeterId": { + "remotePerimeterResourceId": { "readOnly": true, "type": "string", "description": "Perimeter ARM Id for the remote NSP with which the link is created." @@ -2019,11 +1956,6 @@ } }, "description": "Properties of NSP LinkReference." - }, - "NspLinkReferenceReconcile": { - "type": "object", - "properties": {}, - "description": "Request object for NSP linkReference reconcile." } }, "parameters": { From 7bd52349f9ff83af1cf1f034be5bd3b0529fca93 Mon Sep 17 00:00:00 2001 From: Vineet Mimrot Date: Fri, 14 Oct 2022 15:42:08 +0530 Subject: [PATCH 18/18] minor fix --- .../networkSecurityPerimeter.json | 42 +++++++++---------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 1e2faa2b9bbb..e03af63607c2 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -926,10 +926,10 @@ "NspLinks" ], "operationId": "NspLinks_Get", - "description": "Gets the specified NSP link.", + "description": "Gets the specified NSP link resource.", "responses": { "200": { - "description": "OK - Returns information about the NSP link.", + "description": "OK - Returns NSP link resource.", "schema": { "$ref": "#/definitions/NspLink" } @@ -952,7 +952,7 @@ "NspLinks" ], "operationId": "NspLinks_CreateOrUpdate", - "description": "Creates or updates a NSP link.", + "description": "Creates or updates NSP link resource.", "parameters": [ { "name": "parameters", @@ -995,7 +995,7 @@ "NspLinks" ], "operationId": "NspLinks_Delete", - "description": "Deletes an NSP Link.", + "description": "Deletes an NSP Link resource.", "responses": { "200": { "description": "Delete Succeed." @@ -1036,7 +1036,7 @@ "NspLinks" ], "operationId": "NspLinks_List", - "description": "Lists the NSP Links in the specified network security perimeter.", + "description": "Lists the NSP Link resources in the specified network security perimeter.", "x-ms-pageable": { "nextLinkName": "nextLink" }, @@ -1062,7 +1062,7 @@ ], "responses": { "200": { - "description": "OK - Returns the list of NSP links.", + "description": "OK - Returns the list of NSP link resources.", "schema": { "$ref": "#/definitions/NspLinkListResult" } @@ -1104,7 +1104,7 @@ "NspLinkReconcile" ], "operationId": "NspLinkReconcile_Post", - "description": "Reconcile NSP link", + "description": "Reconcile NSP link resource.", "responses": { "200": { "description": "OK" @@ -1146,10 +1146,10 @@ "NspLinkReferences" ], "operationId": "NspLinkReferences_Get", - "description": "Gets the specified NSP linkReference.", + "description": "Gets the specified NSP linkReference resource.", "responses": { "200": { - "description": "OK - Returns information about the NSP linkReference.", + "description": "OK - Returns the NSP linkReference resource.", "schema": { "$ref": "#/definitions/NspLinkReference" } @@ -1172,7 +1172,7 @@ "NspLinkReferences" ], "operationId": "NspLinkReferences_Delete", - "description": "Deletes an NSP LinkReference.", + "description": "Deletes an NSP LinkReference resource.", "responses": { "200": { "description": "Delete Succeed." @@ -1213,7 +1213,7 @@ "NspLinkReferences" ], "operationId": "NspLinkReferences_List", - "description": "Lists the NSP LinkReferences in the specified network security perimeter.", + "description": "Lists the NSP LinkReference resources in the specified network security perimeter.", "x-ms-pageable": { "nextLinkName": "nextLink" }, @@ -1239,7 +1239,7 @@ ], "responses": { "200": { - "description": "OK - Returns the list of NSP linkReferences.", + "description": "OK - Returns the list of NSP linkReference resources.", "schema": { "$ref": "#/definitions/NspLinkReferenceListResult" } @@ -1281,7 +1281,7 @@ "NspLinkReferenceReconcile" ], "operationId": "NspLinkReferenceReconcile_Post", - "description": "Reconcile NSP linkReference", + "description": "Reconcile NSP linkReference resource.", "responses": { "200": { "description": "OK" @@ -1747,7 +1747,7 @@ "properties": { "x-ms-client-flatten": true, "$ref": "#/definitions/NspLinkProperties", - "description": "Properties of the network security perimeter link" + "description": "Properties of the network security perimeter link resource." } }, "allOf": [ @@ -1765,14 +1765,14 @@ "items": { "$ref": "#/definitions/NspLink" }, - "description": "Gets a page of NSP Link" + "description": "Gets a page of NSP Link resources." }, "nextLink": { "type": "string", "description": "Gets the URL to get the next page of results." } }, - "description": "Result of the request to list NSP link. Contains a list of NSP link and a URL link to get the next set of results." + "description": "Result of the request to list NSP link resources. Contains a list of NSP link resources and a URL link to get the next set of results." }, "NspLinkProperties": { "type": "object", @@ -1831,7 +1831,7 @@ }, "description": { "type": "string", - "description": "A message passed to the owner of the remote NSP link resource with this connection request. Restricted to 140 chars." + "description": "A message passed to the owner of the remote NSP link resource with this connection request. In case of Auto-approved flow, it is default to 'Auto Approved'. Restricted to 140 chars." }, "status": { "type": "string", @@ -1857,7 +1857,7 @@ "properties": { "x-ms-client-flatten": true, "$ref": "#/definitions/NspLinkReferenceProperties", - "description": "Properties of the network security perimeter linkReference" + "description": "Properties of the network security perimeter linkReference resource." } }, "allOf": [ @@ -1875,14 +1875,14 @@ "items": { "$ref": "#/definitions/NspLinkReference" }, - "description": "Gets a page of NSP LinkReference" + "description": "Gets a page of NSP LinkReference resources." }, "nextLink": { "type": "string", "description": "Gets the URL to get the next page of results." } }, - "description": "Result of the request to list NSP linkReference. Contains a list of NSP linkReference and a URL link to get the next set of results." + "description": "Result of the request to list NSP linkReference resources. Contains a list of NSP linkReference resources and a URL link to get the next set of results." }, "NspLinkReferenceProperties": { "type": "object", @@ -1955,7 +1955,7 @@ } } }, - "description": "Properties of NSP LinkReference." + "description": "Properties of NSP LinkReference resource." } }, "parameters": {