Remove x-ms-external property for Redis 2022-05-01 and 2021-06-01 API versions #20837

austintolani · 2022-09-22T22:07:23Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
  Fixing issue in existing version (x-ms-external should not be set for OperationStatus).
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
These API versions already been deployed.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
Swagger to be published ASAP.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-09-22T22:07:26Z

Hi, @austintolani Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-09-22T22:07:27Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.9.7)]	new version	base version
redis.json	2021-06-01(6346d5c)	2021-06-01(main)
redis.json	2022-05-01(6346d5c)	2022-05-01(main)

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v1.13.0)	new version	base version
package-2022-05	package-2022-05(6346d5c)	package-2022-05(main)
package-2021-06	package-2021-06(6346d5c)	package-2021-06(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R3021 - PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability' Location: Microsoft.Cache/stable/2021-06-01/redis.json#L73
`❌` R3021 - PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability' Location: Microsoft.Cache/stable/2022-05-01/redis.json#L73
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2423
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Cache/stable/2022-05-01/redis.json#L2425
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L37
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Cache/stable/2022-05-01/redis.json#L37
`❌` R4037 - MissingTypeObject	The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L1842
`❌` R4037 - MissingTypeObject	The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L1882
`❌` R4037 - MissingTypeObject	The schema 'RedisCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2020
`❌` R4037 - MissingTypeObject	The schema 'RedisUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2063
`❌` R4037 - MissingTypeObject	The schema 'RedisProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2078
`❌` R4037 - MissingTypeObject	The schema 'RedisCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2161
`❌` R4037 - MissingTypeObject	The schema 'RedisUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2201
`❌` R4037 - MissingTypeObject	The schema 'RedisAccessKeys' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2222
`❌` R4037 - MissingTypeObject	The schema 'RedisFirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2237
`❌` R4037 - MissingTypeObject	The schema 'RedisFirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2263
`❌` R4037 - MissingTypeObject	The schema 'RedisFirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2280
`❌` R4037 - MissingTypeObject	The schema 'RedisResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2297
`❌` R4037 - MissingTypeObject	The schema 'RedisInstanceDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2326
`❌` R4037 - MissingTypeObject	The schema 'RedisListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2364
`❌` R4037 - MissingTypeObject	The schema 'RedisRegenerateKeyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2381
`❌` R4037 - MissingTypeObject	The schema 'RedisRebootParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2401
`❌` R4037 - MissingTypeObject	The schema 'ExportRDBParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2431
`❌` R4037 - MissingTypeObject	The schema 'ImportRDBParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2452
`❌` R4037 - MissingTypeObject	The schema 'ScheduleEntry' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2471
`❌` R4037 - MissingTypeObject	The schema 'ScheduleEntries' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2509
`❌` R4037 - MissingTypeObject	The schema 'RedisPatchSchedule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2526
`❌` R4037 - MissingTypeObject	The schema 'RedisPatchScheduleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2549
`❌` R4037 - MissingTypeObject	The schema 'RedisForceRebootResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2566
`❌` R4037 - MissingTypeObject	The schema 'RedisLinkedServer' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2576

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️~[Staging] TrafficValidation succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SDK Track2 Validation succeeded [Detail]

The following tags are being changed in this PR

"https://github.com/Azure/azure-rest-api-specs/blob/6346d5cba6cc3d44fcca572cbbe63850ee2257ad/specification/redis/resource-manager/readme.md#tag-package-2022-05">redis/resource-manager/readme.md#package-2022-05
"https://github.com/Azure/azure-rest-api-specs/blob/6346d5cba6cc3d44fcca572cbbe63850ee2257ad/specification/redis/resource-manager/readme.md#tag-package-2021-06">redis/resource-manager/readme.md#package-2021-06

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` PreCheck/DuplicateSchema	"readme":"redis/resource-manager/readme.md", "tag":"package-2022-05", "details":"Duplicate Schema named 'ErrorDetail' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:249" => "#/components/schemas/schemas:461"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌`	"readme":"redis/resource-manager/readme.md", "tag":"package-2022-05", "details":"Error: 1 errors occured -- cannot continue."
`❌` PreCheck/DuplicateSchema	"readme":"redis/resource-manager/readme.md", "tag":"package-2021-06", "details":"Duplicate Schema named 'ErrorDetail' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:247" => "#/components/schemas/schemas:459"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌`	"readme":"redis/resource-manager/readme.md", "tag":"package-2021-06", "details":"Error: 1 errors occured -- cannot continue."

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-09-22T22:07:28Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/redis/armredis - Approved - 3.0.0

+	Struct `CommonProperties` has been removed
+	Struct `CreateProperties` has been removed
+	Struct `Properties` has been removed
+	Struct `UpdateProperties` has been removed

❌azure-sdk-for-js - @azure/arm-rediscache - 8.0.0

+	Operation PatchSchedules.createOrUpdate has a new signature

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from be02f4e. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Redis [View full logs] [Release SDK Changes]
- Azure.ResourceManager.Redis.1.1.0-alpha.20221005.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from be02f4e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-redis [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model RedisLinkedServerCreateParameters has a new parameter geo_replicated_primary_host_name
info	[Changelog]   - Model RedisLinkedServerCreateParameters has a new parameter primary_host_name
info	[Changelog]   - Model RedisLinkedServerCreateProperties has a new parameter geo_replicated_primary_host_name
info	[Changelog]   - Model RedisLinkedServerCreateProperties has a new parameter primary_host_name
info	[Changelog]   - Model RedisLinkedServerProperties has a new parameter geo_replicated_primary_host_name
info	[Changelog]   - Model RedisLinkedServerProperties has a new parameter primary_host_name
info	[Changelog]   - Model RedisLinkedServerWithProperties has a new parameter geo_replicated_primary_host_name
info	[Changelog]   - Model RedisLinkedServerWithProperties has a new parameter primary_host_name

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from be02f4e. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-redis-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from be02f4e. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/redis/armredis [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Struct `CommonProperties` has been removed
info	[Changelog] - Struct `CreateProperties` has been removed
info	[Changelog] - Struct `OperationStatus` has been removed
info	[Changelog] - Struct `Properties` has been removed
info	[Changelog] - Struct `UpdateProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `PrimaryHostName` in struct `LinkedServerProperties`
info	[Changelog] - New field `GeoReplicatedPrimaryHostName` in struct `LinkedServerProperties`
info	[Changelog] - New field `GeoReplicatedPrimaryHostName` in struct `LinkedServerCreateProperties`
info	[Changelog] - New field `PrimaryHostName` in struct `LinkedServerCreateProperties`
info	[Changelog]
info	[Changelog] Total 10 breaking change(s), 2 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from be02f4e. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-rediscache [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-rediscache-8.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Interface RedisLinkedServerCreateParameters has a new optional parameter geoReplicatedPrimaryHostName
info	[Changelog]   - Interface RedisLinkedServerCreateParameters has a new optional parameter primaryHostName
info	[Changelog]   - Interface RedisLinkedServerCreateProperties has a new optional parameter geoReplicatedPrimaryHostName
info	[Changelog]   - Interface RedisLinkedServerCreateProperties has a new optional parameter primaryHostName
info	[Changelog]   - Interface RedisLinkedServerWithProperties has a new optional parameter geoReplicatedPrimaryHostName
info	[Changelog]   - Interface RedisLinkedServerWithProperties has a new optional parameter primaryHostName
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation PatchSchedules.createOrUpdate has a new signature

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from be02f4e. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️redis [View full logs]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from be02f4e. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.Redis [View full logs] [Release SDK Changes]
- Az.Redis.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-09-22T22:07:28Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/redis/armredis	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Python	track2_azure-mgmt-redis	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-redis-generated	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
.Net	Azure.ResourceManager.Redis	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-rediscache	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

akning-ms · 2022-09-23T09:43:58Z

specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json

          "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/OperationStatusResult"
        }
-      ],
-      "x-ms-external": true


Is there any reason to remove this?

@akning-ms its inclusion is creating problems when generating our .NET SDK. It seems like it should have never been set in the first place.

as it seems caused GO & JS breaking change. @tadelesh @qiaozha to confirm

The Go breaking is from code generator and could be ignored.

@qiaozha is the JS breaking change OK also?

austintolani · 2022-10-03T15:57:09Z

@akning-ms @tadelesh Thank you for reviewing this PR. Is there anything we need to do on our end to get this PR merged? Our .NET SDK release is dependent on these changes so we would like to get it merged ASAP.

… versions (Azure#20837) * remove x-ms-external tag for 2022-05-01 API version * remove x-ms-external tag for 2021-06-01 API version

austintolani added 2 commits September 22, 2022 14:56

remove x-ms-external tag for 2022-05-01 API version

141ac94

remove x-ms-external tag for 2021-06-01 API version

6346d5c

austintolani requested a review from TimLovellSmith as a code owner September 22, 2022 22:07

openapi-assignment-bot bot assigned akning-ms Sep 22, 2022

ghost added the Redis Cache label Sep 22, 2022

austintolani closed this Sep 22, 2022

austintolani reopened this Sep 22, 2022

austintolani closed this Sep 22, 2022

austintolani reopened this Sep 22, 2022

openapi-pipeline-app bot added the CI-BreakingChange-Go label Sep 22, 2022

AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager SuppressionReviewRequired labels Sep 22, 2022

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Sep 22, 2022

akning-ms reviewed Sep 23, 2022

View reviewed changes

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Sep 27, 2022

akning-ms approved these changes Oct 4, 2022

View reviewed changes

TimLovellSmith approved these changes Oct 4, 2022

View reviewed changes

akning-ms merged commit be02f4e into Azure:main Oct 5, 2022

austintolani mentioned this pull request Oct 5, 2022

Remove x-ms-external property for Redis 2022-06-01 API versions #21004

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove x-ms-external property for Redis 2022-05-01 and 2021-06-01 API versions #20837

Remove x-ms-external property for Redis 2022-05-01 and 2021-06-01 API versions #20837

Uh oh!

austintolani commented Sep 22, 2022 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Sep 22, 2022

Uh oh!

openapi-pipeline-app bot commented Sep 22, 2022 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Sep 22, 2022 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Sep 22, 2022 •

edited

Loading

Uh oh!

akning-ms Sep 23, 2022

Uh oh!

austintolani Sep 23, 2022

Uh oh!

akning-ms Sep 27, 2022

Uh oh!

tadelesh Sep 27, 2022

Uh oh!

TimLovellSmith Oct 4, 2022

Uh oh!

austintolani commented Oct 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Remove x-ms-external property for Redis 2022-05-01 and 2021-06-01 API versions #20837

Remove x-ms-external property for Redis 2022-05-01 and 2021-06-01 API versions #20837

Uh oh!

Conversation

austintolani commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Sep 22, 2022

Uh oh!

openapi-pipeline-app bot commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

akning-ms Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

austintolani Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

akning-ms Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

tadelesh Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

TimLovellSmith Oct 4, 2022

Choose a reason for hiding this comment

Uh oh!

austintolani commented Oct 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

austintolani commented Sep 22, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 22, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 22, 2022 •

edited

Loading

openapi-pipeline-app bot commented Sep 22, 2022 •

edited

Loading