From 972cf43341ca23e5d94509ebfe6f6ba85566a61e Mon Sep 17 00:00:00 2001 From: Lori Atar Date: Mon, 11 Jul 2022 16:19:36 +0300 Subject: [PATCH 1/3] Manual trigger API alignment - mark mandatory param as required --- .../preview/2021-10-01-preview/AutomationRules.json | 3 +++ .../preview/2022-01-01-preview/AutomationRules.json | 3 +++ .../preview/2022-04-01-preview/AutomationRules.json | 3 +++ .../preview/2022-05-01-preview/AutomationRules.json | 3 +++ .../preview/2022-06-01-preview/AutomationRules.json | 3 +++ .../preview/2022-07-01-preview/AutomationRules.json | 3 +++ 6 files changed, 18 insertions(+) diff --git a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview/AutomationRules.json b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview/AutomationRules.json index 0c65d9ee8180..2816f9003224 100644 --- a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview/AutomationRules.json +++ b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview/AutomationRules.json @@ -892,6 +892,9 @@ }, "ManualTriggerRequestBody": { "type": "object", + "required": [ + "logicAppsResourceId" + ], "properties": { "tenantId": { "format": "uuid", diff --git a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-01-01-preview/AutomationRules.json b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-01-01-preview/AutomationRules.json index 2cb7dbfbab49..b9d4aba9e0ec 100644 --- a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-01-01-preview/AutomationRules.json +++ b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-01-01-preview/AutomationRules.json @@ -901,6 +901,9 @@ }, "ManualTriggerRequestBody": { "type": "object", + "required": [ + "logicAppsResourceId" + ], "properties": { "tenantId": { "format": "uuid", diff --git a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-04-01-preview/AutomationRules.json b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-04-01-preview/AutomationRules.json index 52eb907e04ec..16fef308f9e3 100644 --- a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-04-01-preview/AutomationRules.json +++ b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-04-01-preview/AutomationRules.json @@ -901,6 +901,9 @@ }, "ManualTriggerRequestBody": { "type": "object", + "required": [ + "logicAppsResourceId" + ], "properties": { "tenantId": { "format": "uuid", diff --git a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-05-01-preview/AutomationRules.json b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-05-01-preview/AutomationRules.json index bfa7152f5860..d9dd75cc7274 100644 --- a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-05-01-preview/AutomationRules.json +++ b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-05-01-preview/AutomationRules.json @@ -1037,6 +1037,9 @@ }, "ManualTriggerRequestBody": { "type": "object", + "required": [ + "logicAppsResourceId" + ], "properties": { "tenantId": { "format": "uuid", diff --git a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-06-01-preview/AutomationRules.json b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-06-01-preview/AutomationRules.json index 35953ad58fc0..fb3f512b64c7 100644 --- a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-06-01-preview/AutomationRules.json +++ b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-06-01-preview/AutomationRules.json @@ -1037,6 +1037,9 @@ }, "ManualTriggerRequestBody": { "type": "object", + "required": [ + "logicAppsResourceId" + ], "properties": { "tenantId": { "format": "uuid", diff --git a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json index 156aa1ab8e04..dc646ef20db6 100644 --- a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json +++ b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json @@ -1042,6 +1042,9 @@ }, "ManualTriggerRequestBody": { "type": "object", + "required": [ + "logicAppsResourceId" + ], "properties": { "tenantId": { "format": "uuid", From 9e59becdd19f6cc07c6f112b7b6c371394f96f21 Mon Sep 17 00:00:00 2001 From: Lori Atar Date: Mon, 11 Jul 2022 17:30:08 +0300 Subject: [PATCH 2/3] Fixed missing identifier id in array item property --- .../preview/2021-10-01-preview/AutomationRules.json | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview/AutomationRules.json b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview/AutomationRules.json index 2816f9003224..c69148b0b20a 100644 --- a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview/AutomationRules.json +++ b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview/AutomationRules.json @@ -399,7 +399,8 @@ "type": "array", "items": { "$ref": "#/definitions/AutomationRuleAction" - } + }, + "x-ms-identifiers": [] }, "lastModifiedTimeUtc": { "format": "date-time", @@ -835,7 +836,10 @@ "type": "array", "items": { "$ref": "#/definitions/AutomationRuleCondition" - } + }, + "x-ms-identifiers": [ + "conditionType" + ] } } }, From 9561f652ec85327a4ffd829d4ff3db2b4681a463 Mon Sep 17 00:00:00 2001 From: Lori Atar Date: Tue, 12 Jul 2022 16:44:59 +0300 Subject: [PATCH 3/3] Removed redundant definition --- .../preview/2021-10-01-preview/Settings.json | 23 ------------------- .../preview/2022-01-01-preview/Settings.json | 23 ------------------- .../preview/2022-04-01-preview/Settings.json | 23 ------------------- 3 files changed, 69 deletions(-) diff --git a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview/Settings.json b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview/Settings.json index 5530653a6622..2f28c489d5ed 100644 --- a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview/Settings.json +++ b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview/Settings.json @@ -384,29 +384,6 @@ "modelAsString": true, "name": "UebaDataSources" } - }, - "Sku": { - "description": "The pricing tier of the solution", - "properties": { - "name": { - "description": "The kind of the tier", - "enum": [ - "PerGB", - "CapacityReservation" - ], - "type": "string", - "x-ms-enum": { - "modelAsString": true, - "name": "SkuKind" - } - }, - "capacityReservationLevel": { - "description": "The amount of reservation level", - "type": "integer", - "format": "int32" - } - }, - "type": "object" } }, "parameters": { diff --git a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-01-01-preview/Settings.json b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-01-01-preview/Settings.json index 3e21350b3246..8b39c0fa82f9 100644 --- a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-01-01-preview/Settings.json +++ b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-01-01-preview/Settings.json @@ -384,29 +384,6 @@ "modelAsString": true, "name": "UebaDataSources" } - }, - "Sku": { - "description": "The pricing tier of the solution", - "properties": { - "name": { - "description": "The kind of the tier", - "enum": [ - "PerGB", - "CapacityReservation" - ], - "type": "string", - "x-ms-enum": { - "modelAsString": true, - "name": "SkuKind" - } - }, - "capacityReservationLevel": { - "description": "The amount of reservation level", - "type": "integer", - "format": "int32" - } - }, - "type": "object" } }, "parameters": { diff --git a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-04-01-preview/Settings.json b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-04-01-preview/Settings.json index 64f6fad6c840..93731cb964a2 100644 --- a/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-04-01-preview/Settings.json +++ b/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2022-04-01-preview/Settings.json @@ -398,29 +398,6 @@ "modelAsString": true, "name": "UebaDataSources" } - }, - "Sku": { - "description": "The pricing tier of the solution", - "properties": { - "name": { - "description": "The kind of the tier", - "enum": [ - "PerGB", - "CapacityReservation" - ], - "type": "string", - "x-ms-enum": { - "modelAsString": true, - "name": "SkuKind" - } - }, - "capacityReservationLevel": { - "description": "The amount of reservation level", - "type": "integer", - "format": "int32" - } - }, - "type": "object" } }, "parameters": {