From 1688de95c676c45b05a15b513720a0dce6be3abe Mon Sep 17 00:00:00 2001 From: Ochi Date: Thu, 20 Jan 2022 00:57:17 -0800 Subject: [PATCH 1/2] s360 correctness: SubscriptionRP v2019-03-01-preview --- .../examples/cancelSubscription.json | 2 +- .../examples/enableSubscription.json | 2 +- .../examples/renameSubscription.json | 2 +- .../2019-03-01-preview/subscriptions.json | 30 +++++++++++++++---- 4 files changed, 27 insertions(+), 9 deletions(-) diff --git a/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/cancelSubscription.json b/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/cancelSubscription.json index 56fdb0884237..61126ab9c6d4 100644 --- a/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/cancelSubscription.json +++ b/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/cancelSubscription.json @@ -6,7 +6,7 @@ "responses": { "200": { "body": { - "value": "83aa47df-e3e9-49ff-877b-94304bf3d3ad" + "subscriptionId": "83aa47df-e3e9-49ff-877b-94304bf3d3ad" } } } diff --git a/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/enableSubscription.json b/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/enableSubscription.json index eb3b770d1e8a..38589e08919c 100644 --- a/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/enableSubscription.json +++ b/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/enableSubscription.json @@ -6,7 +6,7 @@ "responses": { "200": { "body": { - "value": "7948bcee-488c-47ce-941c-38e20ede803d" + "subscriptionId": "7948bcee-488c-47ce-941c-38e20ede803d" } } } diff --git a/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/renameSubscription.json b/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/renameSubscription.json index 8ab2abba3dae..37bff895f549 100644 --- a/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/renameSubscription.json +++ b/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/renameSubscription.json @@ -9,7 +9,7 @@ "responses": { "200": { "body": { - "value": "83aa47df-e3e9-49ff-877b-94304bf3d3ad" + "subscriptionId": "83aa47df-e3e9-49ff-877b-94304bf3d3ad" } } } diff --git a/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/subscriptions.json b/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/subscriptions.json index a374aa242204..3a48cb551a40 100644 --- a/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/subscriptions.json +++ b/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/subscriptions.json @@ -43,7 +43,7 @@ "default": { "description": "Describes the error if the operation is not successful.", "schema": { - "$ref": "#/definitions/ErrorResponse" + "$ref": "#/definitions/ErrorResponseBody" } } } @@ -79,7 +79,7 @@ "default": { "description": "Describes the error if the operation is not successful.", "schema": { - "$ref": "#/definitions/ErrorResponse" + "$ref": "#/definitions/ErrorResponseBody" } } } @@ -112,7 +112,7 @@ "default": { "description": "Describes the error if the operation is not successful.", "schema": { - "$ref": "#/definitions/ErrorResponse" + "$ref": "#/definitions/ErrorResponseBody" } } } @@ -134,10 +134,28 @@ } } }, + "ErrorResponseBody": { + "description": "Error response indicates that the service is not able to process the incoming request. The reason is provided in the error message.", + "type": "object", + "properties": { + "error": { + "description": "The details of the error.", + "$ref": "#/definitions/ErrorResponse" + }, + "code": { + "description": "Error code", + "type": "string" + }, + "message": { + "description": "Error message indicating why the operation failed.", + "type": "string" + } + } + }, "CanceledSubscriptionId": { "description": "The ID of the canceled subscription", "properties": { - "value": { + "subscriptionId": { "description": "The ID of the canceled subscription", "type": "string", "readOnly": true @@ -147,7 +165,7 @@ "RenamedSubscriptionId": { "description": "The ID of the subscriptions that is being renamed", "properties": { - "value": { + "subscriptionId": { "description": "The ID of the subscriptions that is being renamed", "type": "string", "readOnly": true @@ -157,7 +175,7 @@ "EnabledSubscriptionId": { "description": "The ID of the subscriptions that is being enabled", "properties": { - "value": { + "subscriptionId": { "description": "The ID of the subscriptions that is being enabled", "type": "string", "readOnly": true From 9b1c927e6e948defa71cf7e864a5c320d07bdcc7 Mon Sep 17 00:00:00 2001 From: Ochi Date: Thu, 20 Jan 2022 17:09:12 -0800 Subject: [PATCH 2/2] example for renameSubscription is corrected --- .../preview/2019-03-01-preview/examples/renameSubscription.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/renameSubscription.json b/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/renameSubscription.json index 37bff895f549..5c2078503361 100644 --- a/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/renameSubscription.json +++ b/specification/subscription/resource-manager/Microsoft.Subscription/preview/2019-03-01-preview/examples/renameSubscription.json @@ -3,7 +3,7 @@ "subscriptionId": "83aa47df-e3e9-49ff-877b-94304bf3d3ad", "api-version": "2019-03-01-preview", "body": { - "SubscriptionName": "Test Sub" + "subscriptionName": "Test Sub" } }, "responses": {