Enabling Customer Initiated Diagnostic Log Collection (#16071)

* Enabling Customer Initiated Log Collection

Enabling Customer Initiated Log Collection

* Update deviceupdate.json

* Update Instances_Create.json

* pretty

* Update deviceupdate.json

* Update readme.go.md

Author: visingl

specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json

@@ -1087,6 +1087,9 @@
             "enableDiagnostics": {
               "description": "Enables or Disables the diagnostic logs collection",
               "type": "boolean"
+            },
+            "diagnosticStorageProperties": {
+              "$ref": "#/definitions/DiagnosticStorageProperties"
             }
           }
         }
@@ -1095,6 +1098,37 @@
         "properties"
       ]
     },
+    "DiagnosticStorageProperties": {
+      "description": "Customer-initiated diagnostic log collection storage properties",
+      "type": "object",
+      "properties": {
+        "authenticationType": {
+          "description": "Authentication Type",
+          "enum": [
+            "KeyBased"
+          ],
+          "type": "string",
+          "readOnly": false,
+          "x-ms-enum": {
+            "name": "AuthenticationType",
+            "modelAsString": true
+          }
+        },
+        "connectionString": {
+          "description": "ConnectionString of the diagnostic storage account",
+          "x-ms-secret": true,
+          "type": "string"
+        },
+        "resourceId": {
+          "description": "ResourceId of the diagnostic storage account",
+          "type": "string"
+        }
+      },
+      "required": [
+        "authenticationType",
+        "resourceId"
+      ]
+    },
     "InstanceList": {
       "description": "List of Instances.",
       "type": "object",

specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/Instances/Instances_Create.json

@@ -15,7 +15,12 @@
             "eventHubConnectionString": "string"
           }
         ],
-        "enableDiagnostics": false
+        "enableDiagnostics": false,
+        "diagnosticStorageProperties": {
+          "authenticationType": "KeyBased",
+          "resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/adu-resource-group/providers/Microsoft.Storage/storageAccounts/testAccount",
+          "connectionString": "string"
+        }
       }
     }
   },
@@ -34,7 +39,11 @@
               "resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Devices/IotHubs/blue-contoso-hub"
             }
           ],
-          "enableDiagnostics": false
+          "enableDiagnostics": false,
+          "diagnosticStorageProperties": {
+            "authenticationType": "KeyBased",
+            "resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/adu-resource-group/providers/Microsoft.Storage/storageAccounts/testAccount"
+          }
         }
       }
     }

specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/Instances/Instances_Get.json

@@ -21,7 +21,11 @@
               "resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Devices/IotHubs/blue-contoso-hub"
             }
           ],
-          "enableDiagnostics": false
+          "enableDiagnostics": false,
+          "diagnosticStorageProperties": {
+            "authenticationType": "KeyBased",
+            "resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/adu-resource-group/providers/Microsoft.Storage/storageAccounts/testAccount"
+          }
         }
       }
     }

specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/Instances/Instances_ListByAccount.json

@@ -23,7 +23,11 @@
                   "resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Devices/IotHubs/blue-contoso-hub"
                 }
               ],
-              "enableDiagnostics": false
+              "enableDiagnostics": false,
+              "diagnosticStorageProperties": {
+                "authenticationType": "KeyBased",
+                "resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/adu-resource-group/providers/Microsoft.Storage/storageAccounts/testAccount"
+              }
             }
           },
           {
@@ -39,7 +43,11 @@
                   "resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Devices/IotHubs/red-contoso-hub"
                 }
               ],
-              "enableDiagnostics": false
+              "enableDiagnostics": false,
+              "diagnosticStorageProperties": {
+                "authenticationType": "KeyBased",
+                "resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/adu-resource-group/providers/Microsoft.Storage/storageAccounts/testAccount"
+              }
             }
           }
         ]

specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/Instances/Instances_Update.json

@@ -25,7 +25,11 @@
               "resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Devices/IotHubs/blue-contoso-hub"
             }
           ],
-          "enableDiagnostics": false
+          "enableDiagnostics": false,
+          "diagnosticStorageProperties": {
+            "authenticationType": "KeyBased",
+            "resourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/adu-resource-group/providers/Microsoft.Storage/storageAccounts/testAccount"
+          }
         },
         "tags": {
           "tagKey": "tagValue"

specification/deviceupdate/resource-manager/readme.go.md

@@ -5,6 +5,7 @@ These settings apply only when `--go` is specified on the command line.
 ```yaml $(go)
 go:
   license-header: MICROSOFT_MIT_NO_VERSION
+  namespace: deviceupdate
   clear-output-folder: true
 ```
 
@@ -21,6 +22,5 @@ These settings apply only when `--tag=package-2020-03-01-preview --go` is specif
 Please also specify `--go-sdks-folder=<path to the root directory of your azure-sdk-for-go clone>`.
 
 ```yaml $(tag) == 'package-2020-03-01-preview' && $(go)
-namespace: deviceupdate
 output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2020-03-01-preview/$(namespace)
 ```