Skip to content

Commit b063290

Browse files
authored
[Hub Generated] Review request for Microsoft.Insights to add version preview/2017-11-01-preview (#12234)
* Fixed swagger validations for version 2017-11-01 * reverted errorREsponse, suppession in another PR * added suppression rule * removed suppression as it exists in another PR * added back suppressoin rule * added missing timestamps * fixed suppression
1 parent 9b8310b commit b063290

File tree

3 files changed

+22
-1
lines changed

3 files changed

+22
-1
lines changed

specification/monitor/resource-manager/Microsoft.Insights/preview/2017-11-01-preview/baseline_API.json

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
}
3737
},
3838
"paths": {
39-
"/{resourceUri}/providers/microsoft.insights/baseline/{metricName}": {
39+
"/{resourceUri}/providers/Microsoft.Insights/baseline/{metricName}": {
4040
"get": {
4141
"tags": [
4242
"Baseline"
@@ -238,6 +238,15 @@
238238
"description": "A single high threshold value."
239239
},
240240
"description": "The high thresholds of the baseline."
241+
},
242+
"timestamps": {
243+
"type": "array",
244+
"items": {
245+
"type": "string",
246+
"format": "date-time",
247+
"description": "the timestamp for the baseline value in ISO 8601 format."
248+
},
249+
"description": "the array of timestamps of the baselines."
241250
}
242251
},
243252
"required": [

specification/monitor/resource-manager/Microsoft.Insights/preview/2017-11-01-preview/calculateBaseline_API.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,15 @@
195195
"description": "A single high threshold value."
196196
},
197197
"description": "The high thresholds of the baseline."
198+
},
199+
"timestamps": {
200+
"type": "array",
201+
"items": {
202+
"type": "string",
203+
"format": "date-time",
204+
"description": "the timestamp for the baseline value in ISO 8601 format."
205+
},
206+
"description": "the array of timestamps of the baselines."
198207
}
199208
},
200209
"required": [

specification/monitor/resource-manager/readme.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -618,6 +618,9 @@ directive:
618618
from: dataCollectionRuleAssociations_API.json
619619
where: $.paths
620620
reason: 'Operations API is defined in a separate swagger spec for Microsoft.Insights namespace (https://github.com/Azure/azure-rest-api-specs/blob/master/specification/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/operations_API.json)'
621+
- suppress: R4007
622+
from: baseline_API.json
623+
reason: 'Updating the error response to the new format would be a breaking change.'
621624
- suppress: R4007
622625
from: metricBaselines_API.json
623626
reason: 'Updating the error response to the new format would be a breaking change.'

0 commit comments

Comments
 (0)