Skip to content

Commit a941a86

Browse files
anat-gilensonAnat Gilenson
anat-gilenson
and
Anat Gilenson
authored
Correct stable 2020 01 01 (#15761)
* Remove definitions that don't exist in 2020-01-01 and extract Incident Severity to a definition. * Use IncidentSeverityEnum instead of defining an incorrect enum which have 'Critical' value. * Remove duplicate definition of IncidentInfo which is already defined in Bookmarks.json * Remove Settings from SecurityInsights.json * Make prettier Co-authored-by: Anat Gilenson <[email protected]>
1 parent b69b3fa commit a941a86

File tree

2 files changed

+35
-245
lines changed

2 files changed

+35
-245
lines changed

‎specification/securityinsights/resource-manager/Microsoft.SecurityInsights/stable/2020-01-01/Bookmarks.json‎

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -340,40 +340,8 @@
340340
},
341341
"severity": {
342342
"description": "The severity of the incident",
343-
"enum": [
344-
"Critical",
345-
"High",
346-
"Medium",
347-
"Low",
348-
"Informational"
349-
],
350343
"type": "string",
351-
"x-ms-enum": {
352-
"modelAsString": true,
353-
"name": "CaseSeverity",
354-
"values": [
355-
{
356-
"description": "Critical severity",
357-
"value": "Critical"
358-
},
359-
{
360-
"description": "High severity",
361-
"value": "High"
362-
},
363-
{
364-
"description": "Medium severity",
365-
"value": "Medium"
366-
},
367-
{
368-
"description": "Low severity",
369-
"value": "Low"
370-
},
371-
{
372-
"description": "Informational severity",
373-
"value": "Informational"
374-
}
375-
]
376-
}
344+
"$ref": "SecurityInsights.json#/definitions/IncidentSeverityEnum"
377345
},
378346
"title": {
379347
"description": "The title of the incident",

‎specification/securityinsights/resource-manager/Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json‎

Lines changed: 34 additions & 212 deletions
Original file line numberDiff line numberDiff line change
@@ -814,35 +814,8 @@
814814
},
815815
"severity": {
816816
"description": "The severity of the incident",
817-
"enum": [
818-
"High",
819-
"Medium",
820-
"Low",
821-
"Informational"
822-
],
823817
"type": "string",
824-
"x-ms-enum": {
825-
"modelAsString": true,
826-
"name": "IncidentSeverity",
827-
"values": [
828-
{
829-
"description": "High severity",
830-
"value": "High"
831-
},
832-
{
833-
"description": "Medium severity",
834-
"value": "Medium"
835-
},
836-
{
837-
"description": "Low severity",
838-
"value": "Low"
839-
},
840-
{
841-
"description": "Informational severity",
842-
"value": "Informational"
843-
}
844-
]
845-
}
818+
"$ref": "#/definitions/IncidentSeverityEnum"
846819
},
847820
"status": {
848821
"description": "The status of the incident",
@@ -883,6 +856,38 @@
883856
],
884857
"type": "object"
885858
},
859+
"IncidentSeverityEnum": {
860+
"description": "The severity of the incident",
861+
"enum": [
862+
"High",
863+
"Medium",
864+
"Low",
865+
"Informational"
866+
],
867+
"type": "string",
868+
"x-ms-enum": {
869+
"modelAsString": true,
870+
"name": "IncidentSeverity",
871+
"values": [
872+
{
873+
"description": "High severity",
874+
"value": "High"
875+
},
876+
{
877+
"description": "Medium severity",
878+
"value": "Medium"
879+
},
880+
{
881+
"description": "Low severity",
882+
"value": "Low"
883+
},
884+
{
885+
"description": "Informational severity",
886+
"value": "Informational"
887+
}
888+
]
889+
}
890+
},
886891
"OfficeConsent": {
887892
"allOf": [
888893
{
@@ -915,6 +920,7 @@
915920
"type": "array"
916921
}
917922
},
923+
"type": "object",
918924
"required": [
919925
"value"
920926
]
@@ -1038,37 +1044,6 @@
10381044
"type": "object",
10391045
"x-ms-azure-resource": true
10401046
},
1041-
"Settings": {
1042-
"allOf": [
1043-
{
1044-
"$ref": "#/definitions/ResourceWithEtag"
1045-
}
1046-
],
1047-
"description": "The Settings.",
1048-
"discriminator": "kind",
1049-
"required": [
1050-
"kind"
1051-
],
1052-
"properties": {
1053-
"kind": {
1054-
"$ref": "#/definitions/SettingsKind",
1055-
"description": "The data connector kind"
1056-
}
1057-
},
1058-
"type": "object"
1059-
},
1060-
"SettingsKind": {
1061-
"description": "The kind of the setting",
1062-
"enum": [
1063-
"UebaSettings",
1064-
"ToggleSettings"
1065-
],
1066-
"type": "string",
1067-
"x-ms-enum": {
1068-
"modelAsString": true,
1069-
"name": "SettingKind"
1070-
}
1071-
},
10721047
"ThreatIntelligence": {
10731048
"description": "ThreatIntelligence property bag.",
10741049
"properties": {
@@ -1106,86 +1081,6 @@
11061081
},
11071082
"type": "object"
11081083
},
1109-
"ToggleSettings": {
1110-
"allOf": [
1111-
{
1112-
"$ref": "#/definitions/Settings"
1113-
}
1114-
],
1115-
"description": "Settings with single toggle.",
1116-
"properties": {
1117-
"properties": {
1118-
"$ref": "#/definitions/ToggleSettingsProperties",
1119-
"description": "toggle properties",
1120-
"x-ms-client-flatten": true
1121-
}
1122-
},
1123-
"type": "object",
1124-
"x-ms-discriminator-value": "ToggleSettings"
1125-
},
1126-
"ToggleSettingsProperties": {
1127-
"description": "toggle property bag.",
1128-
"properties": {
1129-
"isEnabled": {
1130-
"description": "Determines whether the setting is enable or disabled.",
1131-
"type": "boolean"
1132-
}
1133-
},
1134-
"type": "object"
1135-
},
1136-
"UebaSettings": {
1137-
"allOf": [
1138-
{
1139-
"$ref": "#/definitions/Settings"
1140-
}
1141-
],
1142-
"description": "Represents settings for User and Entity Behavior Analytics enablement.",
1143-
"properties": {
1144-
"properties": {
1145-
"$ref": "#/definitions/UebaSettingsProperties",
1146-
"description": "User and Entity Behavior Analytics settings properties",
1147-
"x-ms-client-flatten": true
1148-
}
1149-
},
1150-
"type": "object",
1151-
"x-ms-discriminator-value": "UebaSettings"
1152-
},
1153-
"UebaSettingsProperties": {
1154-
"description": "User and Entity Behavior Analytics settings property bag.",
1155-
"properties": {
1156-
"atpLicenseStatus": {
1157-
"description": "Determines whether the tenant has ATP (Advanced Threat Protection) license.",
1158-
"enum": [
1159-
"Enabled",
1160-
"Disabled"
1161-
],
1162-
"readOnly": true,
1163-
"type": "string",
1164-
"x-ms-enum": {
1165-
"modelAsString": true,
1166-
"name": "LicenseStatus"
1167-
}
1168-
},
1169-
"isEnabled": {
1170-
"description": "Determines whether User and Entity Behavior Analytics is enabled for this workspace.",
1171-
"type": "boolean"
1172-
},
1173-
"statusInMcas": {
1174-
"description": "Determines whether User and Entity Behavior Analytics is enabled from MCAS (Microsoft Cloud App Security).",
1175-
"enum": [
1176-
"Enabled",
1177-
"Disabled"
1178-
],
1179-
"readOnly": true,
1180-
"type": "string",
1181-
"x-ms-enum": {
1182-
"modelAsString": true,
1183-
"name": "StatusInMcas"
1184-
}
1185-
}
1186-
},
1187-
"type": "object"
1188-
},
11891084
"UserInfo": {
11901085
"description": "User information that made some action",
11911086
"properties": {
@@ -1210,61 +1105,6 @@
12101105
"objectId"
12111106
],
12121107
"type": "object"
1213-
},
1214-
"IncidentInfo": {
1215-
"description": "Describes related incident information for the bookmark",
1216-
"properties": {
1217-
"incidentId": {
1218-
"description": "Incident Id",
1219-
"type": "string"
1220-
},
1221-
"severity": {
1222-
"description": "The severity of the incident",
1223-
"enum": [
1224-
"Critical",
1225-
"High",
1226-
"Medium",
1227-
"Low",
1228-
"Informational"
1229-
],
1230-
"type": "string",
1231-
"x-ms-enum": {
1232-
"modelAsString": true,
1233-
"name": "CaseSeverity",
1234-
"values": [
1235-
{
1236-
"description": "Critical severity",
1237-
"value": "Critical"
1238-
},
1239-
{
1240-
"description": "High severity",
1241-
"value": "High"
1242-
},
1243-
{
1244-
"description": "Medium severity",
1245-
"value": "Medium"
1246-
},
1247-
{
1248-
"description": "Low severity",
1249-
"value": "Low"
1250-
},
1251-
{
1252-
"description": "Informational severity",
1253-
"value": "Informational"
1254-
}
1255-
]
1256-
}
1257-
},
1258-
"title": {
1259-
"description": "The title of the incident",
1260-
"type": "string"
1261-
},
1262-
"relationName": {
1263-
"description": "Relation Name",
1264-
"type": "string"
1265-
}
1266-
},
1267-
"type": "object"
12681108
}
12691109
},
12701110
"parameters": {
@@ -1390,24 +1230,6 @@
13901230
"type": "string",
13911231
"x-ms-parameter-location": "method"
13921232
},
1393-
"Settings": {
1394-
"description": "The setting",
1395-
"in": "body",
1396-
"name": "settings",
1397-
"required": true,
1398-
"schema": {
1399-
"$ref": "#/definitions/Settings"
1400-
},
1401-
"x-ms-parameter-location": "method"
1402-
},
1403-
"SettingsName": {
1404-
"description": "The setting name. Supports- Fusion, UEBA",
1405-
"in": "path",
1406-
"name": "settingsName",
1407-
"required": true,
1408-
"type": "string",
1409-
"x-ms-parameter-location": "method"
1410-
},
14111233
"SubscriptionId": {
14121234
"description": "Azure subscription ID",
14131235
"in": "path",

0 commit comments

Comments
 (0)