[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 (#13196)

jiacheng-L · web-flow · commit 33f0337a7d01 · 2021-03-11T08:52:33.000+08:00
* Add missing property and annotation

* Fix typo

* Address PR comment

* Prettier Check
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/createVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/createVault.json
@@ -170,6 +170,7 @@
           "enabledForDeployment": true,
           "enabledForDiskEncryption": true,
           "enabledForTemplateDeployment": true,
+          "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
           "vaultUri": "https://sample-vault.vault.azure.net",
           "provisioningState": "Succeeded"
         }
@@ -243,6 +244,7 @@
           "enabledForDeployment": true,
           "enabledForDiskEncryption": true,
           "enabledForTemplateDeployment": true,
+          "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
           "vaultUri": "https://sample-vault.vault.azure.net",
           "provisioningState": "Succeeded"
         }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/createVaultWithNetworkAcls.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/createVaultWithNetworkAcls.json
@@ -69,6 +69,7 @@
           "enabledForDeployment": true,
           "enabledForDiskEncryption": true,
           "enabledForTemplateDeployment": true,
+          "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
           "vaultUri": "https://sample-vault.vault.azure.net"
         }
       }
@@ -106,6 +107,7 @@
           "enabledForDeployment": true,
           "enabledForDiskEncryption": true,
           "enabledForTemplateDeployment": true,
+          "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
           "vaultUri": "https://sample-vault.vault.azure.net"
         }
       }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/getVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/getVault.json
@@ -74,6 +74,7 @@
           "enabledForDeployment": true,
           "enabledForDiskEncryption": true,
           "enabledForTemplateDeployment": true,
+          "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
           "vaultUri": "https://sample-vault.vault.azure.net",
           "provisioningState": "Succeeded"
         }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/listVaultByResourceGroup.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/listVaultByResourceGroup.json
@@ -77,6 +77,7 @@
               "enabledForDiskEncryption": true,
               "enabledForTemplateDeployment": true,
               "enableSoftDelete": true,
+              "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
               "vaultUri": "https://sample-vault.vault.azure.net/",
               "provisioningState": "Succeeded"
             }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/listVaultBySubscription.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/listVaultBySubscription.json
@@ -76,6 +76,7 @@
               "enabledForDiskEncryption": true,
               "enabledForTemplateDeployment": true,
               "enableSoftDelete": true,
+              "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
               "vaultUri": "https://sample-vault.vault.azure.net/",
               "provisioningState": "Succeeded"
             }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/updateVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/updateVault.json
@@ -169,6 +169,7 @@
           "enabledForDeployment": true,
           "enabledForDiskEncryption": true,
           "enabledForTemplateDeployment": true,
+          "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
           "vaultUri": "https://sample-vault.vault.azure.net",
           "provisioningState": "Succeeded"
         }
@@ -243,6 +244,7 @@
           "enabledForDiskEncryption": true,
           "enabledForTemplateDeployment": true,
           "vaultUri": "https://sample-vault.vault.azure.net",
+          "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
           "provisioningState": "Succeeded"
         }
       }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keys.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keys.json
@@ -461,12 +461,14 @@
               "name": "JsonWebKeyOperation",
               "modelAsString": true
             }
-          }
+          },
+          "readOnly": true
         },
         "keySize": {
           "type": "integer",
           "format": "int32",
-          "description": "The key size in bits. For example: 2048, 3072, or 4096 for RSA."
+          "description": "The key size in bits. For example: 2048, 3072, or 4096 for RSA.",
+          "readOnly": true
         },
         "curveName": {
           "type": "string",
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json
@@ -1261,6 +1261,11 @@
           "type": "string",
           "description": "The URI of the vault for performing operations on keys and secrets. This property is readonly"
         },
+        "hsmPoolResourceId": {
+          "type": "string",
+          "description": "The resource id of HSM Pool.",
+          "readOnly": true
+        },
         "enabledForDeployment": {
           "type": "boolean",
           "description": "Property to specify whether Azure Virtual Machines are permitted to retrieve certificates stored as secrets from the key vault."
@@ -1299,7 +1304,11 @@
           "x-ms-enum": {
             "name": "CreateMode",
             "modelAsString": false
-          }
+          },
+          "x-ms-mutability": [
+            "create",
+            "update"
+          ]
         },
         "enablePurgeProtection": {
           "type": "boolean",

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,7 @@`
`69`	`69`	`"enabledForDeployment": true,`
`70`	`70`	`"enabledForDiskEncryption": true,`
`71`	`71`	`"enabledForTemplateDeployment": true,`
	`72`	`+ "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",`
`72`	`73`	`"vaultUri": "https://sample-vault.vault.azure.net"`
`73`	`74`	`}`
`74`	`75`	`}`
`@@ -106,6 +107,7 @@`
`106`	`107`	`"enabledForDeployment": true,`
`107`	`108`	`"enabledForDiskEncryption": true,`
`108`	`109`	`"enabledForTemplateDeployment": true,`
	`110`	`+ "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",`
`109`	`111`	`"vaultUri": "https://sample-vault.vault.azure.net"`
`110`	`112`	`}`
`111`	`113`	`}`
Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@`
`74`	`74`	`"enabledForDeployment": true,`
`75`	`75`	`"enabledForDiskEncryption": true,`
`76`	`76`	`"enabledForTemplateDeployment": true,`
	`77`	`+ "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",`
`77`	`78`	`"vaultUri": "https://sample-vault.vault.azure.net",`
`78`	`79`	`"provisioningState": "Succeeded"`
`79`	`80`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,7 @@`
`77`	`77`	`"enabledForDiskEncryption": true,`
`78`	`78`	`"enabledForTemplateDeployment": true,`
`79`	`79`	`"enableSoftDelete": true,`
	`80`	`+ "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",`
`80`	`81`	`"vaultUri": "https://sample-vault.vault.azure.net/",`
`81`	`82`	`"provisioningState": "Succeeded"`
`82`	`83`	`}`
Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,7 @@`
`76`	`76`	`"enabledForDiskEncryption": true,`
`77`	`77`	`"enabledForTemplateDeployment": true,`
`78`	`78`	`"enableSoftDelete": true,`
	`79`	`+ "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",`
`79`	`80`	`"vaultUri": "https://sample-vault.vault.azure.net/",`
`80`	`81`	`"provisioningState": "Succeeded"`
`81`	`82`	`}`
Original file line number	Diff line number	Diff line change
`@@ -169,6 +169,7 @@`
`169`	`169`	`"enabledForDeployment": true,`
`170`	`170`	`"enabledForDiskEncryption": true,`
`171`	`171`	`"enabledForTemplateDeployment": true,`
	`172`	`+ "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",`
`172`	`173`	`"vaultUri": "https://sample-vault.vault.azure.net",`
`173`	`174`	`"provisioningState": "Succeeded"`
`174`	`175`	`}`
`@@ -243,6 +244,7 @@`
`243`	`244`	`"enabledForDiskEncryption": true,`
`244`	`245`	`"enabledForTemplateDeployment": true,`
`245`	`246`	`"vaultUri": "https://sample-vault.vault.azure.net",`
	`247`	`+ "hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",`
`246`	`248`	`"provisioningState": "Succeeded"`
`247`	`249`	`}`
`248`	`250`	`}`