Skip to content

Commit 18a4efa

Browse files
rchlkmrchlkm
authored
[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2021-11-01-preview (#17252)
* Adds base for updating Microsoft.SqlVirtualMachine from version preview/2017-03-01-preview to version 2021-11-01-preview * Updates readme * Updates API version in new specs and examples * add 2021-11-01 swagger * add missing files, spellcheck, add MAXDOP to custom-words * prettier check * fix model validation errors * fix swagger avocado failures, SDK azure-sdk-for-net failures due to DaysOfWeek * add system data to AvailabilityGroupListener, SqlVirtualMachineGroup, SqlVirtualMachine * update list operation for 2021-11-01 * add ms-identifier to address lintdiff R4041 * remove x-ms-identifiers property as it is not available yet on .net sdk * add SqlVirtualMachines_StartAssessment * update ResourceIdentity enum from IdentityTypeWithNone to IdentityType * update list operations json * prettier check * re-add ms-identifier to address lintdiff R4041
1 parent b4d0463 commit 18a4efa

28 files changed

+3577
-13
lines changed

‎custom-words.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1185,6 +1185,7 @@ marketplacecatalog
11851185
marketplaceordering
11861186
maxclients
11871187
maxcoordinates
1188+
MAXDOP
11881189
MAXERRORS
11891190
maxfragmentationmemory
11901191
maximumblobsize

‎specification/sqlvirtualmachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/examples/CreateOrUpdateAvailabilityGroupListener.json‎

Lines changed: 77 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
1+
{
2+
"parameters": {
3+
"subscriptionId": "00000000-1111-2222-3333-444444444444",
4+
"resourceGroupName": "testrg",
5+
"sqlVirtualMachineGroupName": "testvmgroup",
6+
"availabilityGroupListenerName": "agl-test",
7+
"api-version": "2021-11-01-preview",
8+
"parameters": {
9+
"properties": {
10+
"availabilityGroupName": "ag-test",
11+
"loadBalancerConfigurations": [
12+
{
13+
"privateIpAddress": {
14+
"ipAddress": "10.1.0.112",
15+
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
16+
},
17+
"loadBalancerResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/loadBalancers/lb-test",
18+
"probePort": 59983,
19+
"sqlVirtualMachineInstances": [
20+
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2",
21+
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm3"
22+
]
23+
}
24+
],
25+
"port": 1433
26+
}
27+
}
28+
},
29+
"responses": {
30+
"200": {
31+
"body": {
32+
"properties": {
33+
"provisioningState": "Updating",
34+
"loadBalancerConfigurations": [
35+
{
36+
"privateIpAddress": {
37+
"ipAddress": "10.1.0.113",
38+
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
39+
},
40+
"sqlVirtualMachineInstances": [
41+
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2",
42+
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm3"
43+
]
44+
}
45+
],
46+
"port": 1433
47+
},
48+
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup/availabilityGroupListeners/agl-test",
49+
"name": "agl-test",
50+
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/availabilityGroupListeners"
51+
}
52+
},
53+
"201": {
54+
"body": {
55+
"properties": {
56+
"provisioningState": "Provisioning",
57+
"loadBalancerConfigurations": [
58+
{
59+
"privateIpAddress": {
60+
"ipAddress": "10.1.0.112",
61+
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
62+
},
63+
"sqlVirtualMachineInstances": [
64+
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2",
65+
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm3"
66+
]
67+
}
68+
],
69+
"port": 1433
70+
},
71+
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup/availabilityGroupListeners/agl-test",
72+
"name": "agl-test",
73+
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/availabilityGroupListeners"
74+
}
75+
}
76+
}
77+
}

‎specification/sqlvirtualmachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/examples/CreateOrUpdateSqlVirtualMachineAutomatedBackupWeekly.json‎

Lines changed: 96 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
1+
{
2+
"parameters": {
3+
"subscriptionId": "00000000-1111-2222-3333-444444444444",
4+
"resourceGroupName": "testrg",
5+
"sqlVirtualMachineName": "testvm",
6+
"api-version": "2021-11-01-preview",
7+
"parameters": {
8+
"location": "northeurope",
9+
"properties": {
10+
"sqlServerLicenseType": "PAYG",
11+
"sqlImageSku": "Enterprise",
12+
"sqlManagement": "Full",
13+
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
14+
"serverConfigurationsManagementSettings": {
15+
"sqlConnectivityUpdateSettings": {
16+
"connectivityType": "PRIVATE",
17+
"port": 1433,
18+
"sqlAuthUpdateUserName": "sqllogin",
19+
"sqlAuthUpdatePassword": "<password>"
20+
},
21+
"sqlStorageUpdateSettings": {
22+
"diskCount": 1,
23+
"startingDeviceId": 2,
24+
"diskConfigurationType": "NEW"
25+
},
26+
"sqlWorkloadTypeUpdateSettings": {
27+
"sqlWorkloadType": "OLTP"
28+
},
29+
"additionalFeaturesServerConfigurations": {
30+
"isRServicesEnabled": false
31+
}
32+
},
33+
"keyVaultCredentialSettings": {
34+
"enable": false
35+
},
36+
"autoPatchingSettings": {
37+
"enable": true,
38+
"dayOfWeek": "Sunday",
39+
"maintenanceWindowStartingHour": 2,
40+
"maintenanceWindowDuration": 60
41+
},
42+
"autoBackupSettings": {
43+
"enable": true,
44+
"retentionPeriod": 17,
45+
"enableEncryption": true,
46+
"password": "<Password>",
47+
"backupScheduleType": "Manual",
48+
"backupSystemDbs": true,
49+
"storageAccountUrl": "https://teststorage.blob.core.windows.net/",
50+
"storageContainerName": "testcontainer",
51+
"storageAccessKey": "<primary storage access key>",
52+
"fullBackupFrequency": "Weekly",
53+
"daysOfWeek": [
54+
"Monday",
55+
"Friday"
56+
],
57+
"fullBackupStartTime": 6,
58+
"fullBackupWindowHours": 11,
59+
"logBackupFrequency": 10
60+
}
61+
}
62+
}
63+
},
64+
"responses": {
65+
"200": {
66+
"body": {
67+
"properties": {
68+
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
69+
"provisioningState": "Updating",
70+
"sqlServerLicenseType": "PAYG",
71+
"sqlImageSku": "Enterprise",
72+
"sqlManagement": "Full"
73+
},
74+
"location": "northeurope",
75+
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
76+
"name": "testvm",
77+
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
78+
}
79+
},
80+
"201": {
81+
"body": {
82+
"properties": {
83+
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
84+
"provisioningState": "Provisioning",
85+
"sqlServerLicenseType": "PAYG",
86+
"sqlImageSku": "Unknown",
87+
"sqlManagement": "Full"
88+
},
89+
"location": "northeurope",
90+
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
91+
"name": "testvm",
92+
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
93+
}
94+
}
95+
}
96+
}

‎specification/sqlvirtualmachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/examples/CreateOrUpdateSqlVirtualMachineGroup.json‎

Lines changed: 67 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
1+
{
2+
"parameters": {
3+
"subscriptionId": "00000000-1111-2222-3333-444444444444",
4+
"resourceGroupName": "testrg",
5+
"sqlVirtualMachineGroupName": "testvmgroup",
6+
"api-version": "2021-11-01-preview",
7+
"parameters": {
8+
"location": "northeurope",
9+
"tags": {
10+
"mytag": "myval"
11+
},
12+
"properties": {
13+
"sqlImageOffer": "SQL2016-WS2016",
14+
"sqlImageSku": "Enterprise",
15+
"wsfcDomainProfile": {
16+
"domainFqdn": "testdomain.com",
17+
"ouPath": "OU=WSCluster,DC=testdomain,DC=com",
18+
"clusterBootstrapAccount": "testrpadmin",
19+
"clusterOperatorAccount": "[email protected]",
20+
"sqlServiceAccount": "[email protected]",
21+
"storageAccountUrl": "https://storgact.blob.core.windows.net/",
22+
"storageAccountPrimaryKey": "<primary storage access key>"
23+
}
24+
}
25+
}
26+
},
27+
"responses": {
28+
"200": {
29+
"body": {
30+
"properties": {
31+
"provisioningState": "UpdatingDomainful",
32+
"sqlImageOffer": "SQL2016-WS2016",
33+
"sqlImageSku": "Enterprise",
34+
"wsfcDomainProfile": {
35+
"storageAccountUrl": "https://storgact.blob.core.windows.net/"
36+
}
37+
},
38+
"location": "northeurope",
39+
"tags": {
40+
"mytag": "myval"
41+
},
42+
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup",
43+
"name": "testvmgroup",
44+
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups"
45+
}
46+
},
47+
"201": {
48+
"body": {
49+
"properties": {
50+
"provisioningState": "ProvisioningDomainful",
51+
"sqlImageOffer": "SQL2016-WS2016",
52+
"sqlImageSku": "Enterprise",
53+
"wsfcDomainProfile": {
54+
"storageAccountUrl": "https://storgact.blob.core.windows.net/"
55+
}
56+
},
57+
"location": "northeurope",
58+
"tags": {
59+
"mytag": "myval"
60+
},
61+
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup",
62+
"name": "testvmgroup",
63+
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups"
64+
}
65+
}
66+
}
67+
}

‎specification/sqlvirtualmachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/examples/CreateOrUpdateSqlVirtualMachineMAX.json‎

Lines changed: 110 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,110 @@
1+
{
2+
"parameters": {
3+
"subscriptionId": "00000000-1111-2222-3333-444444444444",
4+
"resourceGroupName": "testrg",
5+
"sqlVirtualMachineName": "testvm",
6+
"api-version": "2021-11-01-preview",
7+
"parameters": {
8+
"location": "northeurope",
9+
"properties": {
10+
"sqlServerLicenseType": "PAYG",
11+
"sqlImageSku": "Enterprise",
12+
"sqlManagement": "Full",
13+
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
14+
"serverConfigurationsManagementSettings": {
15+
"sqlConnectivityUpdateSettings": {
16+
"connectivityType": "PRIVATE",
17+
"port": 1433,
18+
"sqlAuthUpdateUserName": "sqllogin",
19+
"sqlAuthUpdatePassword": "<password>"
20+
},
21+
"sqlStorageUpdateSettings": {
22+
"diskCount": 1,
23+
"startingDeviceId": 2,
24+
"diskConfigurationType": "NEW"
25+
},
26+
"sqlWorkloadTypeUpdateSettings": {
27+
"sqlWorkloadType": "OLTP"
28+
},
29+
"additionalFeaturesServerConfigurations": {
30+
"isRServicesEnabled": false
31+
},
32+
"sqlInstanceSettings": {
33+
"collation": "SQL_Latin1_General_CP1_CI_AS",
34+
"maxDop": 8,
35+
"isOptimizeForAdHocWorkloadsEnabled": true,
36+
"minServerMemoryMB": 0,
37+
"maxServerMemoryMB": 128
38+
}
39+
},
40+
"keyVaultCredentialSettings": {
41+
"enable": false
42+
},
43+
"autoPatchingSettings": {
44+
"enable": true,
45+
"dayOfWeek": "Sunday",
46+
"maintenanceWindowStartingHour": 2,
47+
"maintenanceWindowDuration": 60
48+
},
49+
"autoBackupSettings": {
50+
"enable": true,
51+
"retentionPeriod": 17,
52+
"enableEncryption": true,
53+
"password": "<Password>",
54+
"backupScheduleType": "Manual",
55+
"backupSystemDbs": true,
56+
"storageAccountUrl": "https://teststorage.blob.core.windows.net/",
57+
"storageContainerName": "testcontainer",
58+
"storageAccessKey": "<primary storage access key>",
59+
"fullBackupFrequency": "Daily",
60+
"fullBackupStartTime": 6,
61+
"fullBackupWindowHours": 11,
62+
"logBackupFrequency": 10
63+
},
64+
"assessmentSettings": {
65+
"enable": true,
66+
"runImmediately": true,
67+
"schedule": {
68+
"enable": true,
69+
"weeklyInterval": 1,
70+
"monthlyOccurrence": null,
71+
"dayOfWeek": "Sunday",
72+
"startTime": "23:17"
73+
}
74+
}
75+
}
76+
}
77+
},
78+
"responses": {
79+
"200": {
80+
"body": {
81+
"properties": {
82+
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
83+
"provisioningState": "Updating",
84+
"sqlServerLicenseType": "PAYG",
85+
"sqlImageSku": "Enterprise",
86+
"sqlManagement": "Full"
87+
},
88+
"location": "northeurope",
89+
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
90+
"name": "testvm",
91+
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
92+
}
93+
},
94+
"201": {
95+
"body": {
96+
"properties": {
97+
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
98+
"provisioningState": "Provisioning",
99+
"sqlServerLicenseType": "PAYG",
100+
"sqlImageSku": "Unknown",
101+
"sqlManagement": "Full"
102+
},
103+
"location": "northeurope",
104+
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
105+
"name": "testvm",
106+
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
107+
}
108+
}
109+
}
110+
}

0 commit comments

Comments
 (0)