[Compute] update sdk package reference for Compute (#22459)

grizzlytheodore · Theodore Chang · web-flow · commit abf9130c5cc5 · 2023-08-11T19:44:28.000+08:00
* update SDK reference

* resolve breaking change

* update package reference

* breaking change mitigation

* breaking change suppression

* re-record ssh test with latest compute API call

---------

Co-authored-by: Theodore Chang &lt;theodore.l.chang@gmail.com&gt;
diff --git a/src/Compute/Compute.Test/Compute.Test.csproj b/src/Compute/Compute.Test/Compute.Test.csproj
@@ -12,7 +12,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Azure.Graph.RBAC" Version="3.4.0-preview" />
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="60.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="61.0.0" />
     <PackageReference Include="Microsoft.Azure.Management.KeyVault" Version="4.0.0-preview.1" />
   </ItemGroup>
 
diff --git a/src/Compute/Compute/Compute.csproj b/src/Compute/Compute/Compute.csproj
@@ -15,7 +15,7 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.Azure.PowerShell.AutoMapper" Version="6.2.2" />
     <PackageReference Include="Microsoft.Azure.Management.ResourceGraph" Version="2.1.0" />
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="60.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="61.0.0" />
     <PackageReference Include="System.Security.Permissions" Version="4.7.0" />
     <PackageReference Include="System.ServiceModel.Primitives" Version="4.7.0" />
     <PackageReference Include="WindowsAzure.Storage" Version="9.3.0" />
diff --git a/src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssIpConfigCommand.cs b/src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssIpConfigCommand.cs
@@ -129,7 +129,7 @@ private void Run()
             vIpConfigurations.Name = this.IsParameterBound(c => c.Name) ? this.Name : null;
             vIpConfigurations.Primary = this.Primary.IsPresent;
             vIpConfigurations.PrivateIPAddressVersion = this.IsParameterBound(c => c.PrivateIPAddressVersion) ? this.PrivateIPAddressVersion : null;
-            vIpConfigurations.Id = this.IsParameterBound(c => c.Id) ? this.Id : null;
+            //vIpConfigurations.Id = this.IsParameterBound(c => c.Id) ? this.Id : null;
 
             // SubnetId
             if (this.IsParameterBound(c => c.SubnetId))
diff --git a/src/Network/Network.Test/Network.Test.csproj b/src/Network/Network.Test/Network.Test.csproj
@@ -17,7 +17,7 @@
     <PackageReference Include="Microsoft.Azure.KeyVault" Version="3.0.5" />
     <PackageReference Include="Microsoft.Azure.Management.KeyVault" Version="4.0.0-preview.1" />
     <PackageReference Include="Microsoft.Azure.Insights" Version="0.16.0-preview" />
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="60.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="61.0.0" />
     <PackageReference Include="Microsoft.Azure.Management.PrivateDns" Version="1.0.0" />
     <PackageReference Include="Microsoft.Azure.Management.Redis" Version="4.4.1" />
     <PackageReference Include="Microsoft.Azure.Management.OperationalInsights" Version="0.25.0-preview" />
diff --git a/src/RecoveryServices/RecoveryServices.Backup.Test/RecoveryServices.Backup.Test.csproj b/src/RecoveryServices/RecoveryServices.Backup.Test/RecoveryServices.Backup.Test.csproj
@@ -11,7 +11,7 @@
 	</PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="60.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="61.0.0" />
     <PackageReference Include="Microsoft.Azure.Management.RecoveryServices" Version="4.3.3-preview" />
 	<PackageReference Include="Microsoft.Azure.Management.RecoveryServices.Backup" Version="5.0.0-preview" />
   </ItemGroup>
diff --git a/src/RecoveryServices/RecoveryServices.SiteRecovery.Test/RecoveryServices.SiteRecovery.Test.csproj b/src/RecoveryServices/RecoveryServices.SiteRecovery.Test/RecoveryServices.SiteRecovery.Test.csproj
@@ -12,7 +12,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Azure.Management.RecoveryServices" Version="4.3.3-preview" />
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="60.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="61.0.0" />
 	<PackageReference Include="Microsoft.Azure.Management.RecoveryServices.Backup" Version="5.0.0-preview" />
     <PackageReference Include="Microsoft.Azure.Management.Storage" Version="14.3.0" />
   </ItemGroup>
diff --git a/src/Security/Security.Test/Security.Test.csproj b/src/Security/Security.Test/Security.Test.csproj
@@ -42,7 +42,7 @@
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
     <PackageReference Include="Microsoft.Azure.Management.SecurityCenter" Version="3.0.0" />
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="60.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="61.0.0" />
     <PackageReference Include="Microsoft.Azure.Management.OperationalInsights" Version="0.25.0-preview" />
   </ItemGroup>
 </Project>
diff --git a/src/Ssh/Ssh.Test/ScenarioTests/SshTestRunner.cs b/src/Ssh/Ssh.Test/ScenarioTests/SshTestRunner.cs
@@ -26,7 +26,10 @@ protected SshTestRunner(ITestOutputHelper output)
                 })
                 .WithNewRecordMatcherArguments(
                     userAgentsToIgnore: new Dictionary<string, string>(),
-                    resourceProviders: new Dictionary<string, string>()
+                    resourceProviders: new Dictionary<string, string>
+                    {
+                        {"Microsoft.Compute", null }
+                    }
                 )
                 .Build();
         }
diff --git a/src/Ssh/Ssh.Test/SessionRecords/Microsoft.Azure.Commands.Ssh.Test.ScenarioTests.GetAzSshConfigTests/TestGetVmConfig.json b/src/Ssh/Ssh.Test/SessionRecords/Microsoft.Azure.Commands.Ssh.Test.ScenarioTests.GetAzSshConfigTests/TestGetVmConfig.json
diff --git a/src/Ssh/Ssh.Test/Ssh.Test.csproj b/src/Ssh/Ssh.Test/Ssh.Test.csproj
@@ -1,4 +1,4 @@
-﻿<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <PsModuleName>Ssh</PsModuleName>
@@ -19,7 +19,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="60.0.0" />
+    <PackageReference Include="Microsoft.Azure.Management.Compute" Version="61.0.0" />
   </ItemGroup>
 
 </Project>
diff --git a/tools/StaticAnalysis/Exceptions/Az.Compute/BreakingChangeIssues.csv b/tools/StaticAnalysis/Exceptions/Az.Compute/BreakingChangeIssues.csv
@@ -1,2 +1,6 @@
 "Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
 "Az.Compute","Microsoft.Azure.Commands.Compute.Automation.UpdateAzureRmVmss","Update-AzVmss","0","2050","A validate set has been added for parameter 'AutomaticRepairAction' for cmdlet 'Update-AzVmss'.","Remove the validate set from parameter 'AutomaticRepairAction'."
+"Az.Compute","Microsoft.Azure.Commands.Compute.AddAzureVMDataDiskCommand","Add-AzVMDataDisk","0","3010","The property 'Id' of type 'Microsoft.Azure.Management.Compute.Models.VirtualMachineScaleSetIPConfiguration' has been removed.","Add the property 'Id' back to type 'Microsoft.Azure.Management.Compute.Models.VirtualMachineScaleSetIPConfiguration'."
+"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.NewAzureRmVmssIpConfigCommand","New-AzVmssIpConfig","0","3010","The property 'Id' of type 'Microsoft.Azure.Management.Compute.Models.VirtualMachineScaleSetIPConfiguration' has been removed.","Add the property 'Id' back to type 'Microsoft.Azure.Management.Compute.Models.VirtualMachineScaleSetIPConfiguration'."
+"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.GetAzureRestorePoint","Get-AzRestorePoint","0","3000","The type of property 'DiskRestorePoint' of type 'Microsoft.Azure.Management.Compute.Models.RestorePointSourceVMOSDisk' has changed from 'Microsoft.Azure.Management.Compute.Models.ApiEntityReference' to 'Microsoft.Azure.Management.Compute.Models.DiskRestorePointAttributes'.","Change the type of property 'DiskRestorePoint' back to 'Microsoft.Azure.Management.Compute.Models.ApiEntityReference'."
+"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.GetAzureRestorePoint","Get-AzRestorePoint","0","3000","The type of property 'DiskRestorePoint' of type 'Microsoft.Azure.Management.Compute.Models.RestorePointSourceVMDataDisk' has changed from 'Microsoft.Azure.Management.Compute.Models.ApiEntityReference' to 'Microsoft.Azure.Management.Compute.Models.DiskRestorePointAttributes'.","Change the type of property 'DiskRestorePoint' back to 'Microsoft.Azure.Management.Compute.Models.ApiEntityReference'."1

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,10 @@ protected SshTestRunner(ITestOutputHelper output)`
`26`	`26`	`})`
`27`	`27`	`.WithNewRecordMatcherArguments(`
`28`	`28`	`userAgentsToIgnore: new Dictionary<string, string>(),`
`29`		`- resourceProviders: new Dictionary<string, string>()`
	`29`	`+ resourceProviders: new Dictionary<string, string>`
	`30`	`+ {`
	`31`	`+ {"Microsoft.Compute", null }`
	`32`	`+ }`
`30`	`33`	`)`
`31`	`34`	`.Build();`
`32`	`35`	`}`