Fixed Bot comments, Deleted -> Renamed + Recreated Session Test Records, Matched Logic in VM Strategy with VMSS

Author: ookoka

src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.cs

@@ -482,9 +482,9 @@ public void TestProxyAgentSetting()
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void TestVMSSAddProxyAgentExtension()
+        public void TestVirtualMachineScaleSetAddProxyAgentExtension()
         {
-            TestRunner.RunTestScript("Test-VMSSAddProxyAgentExtension");
+            TestRunner.RunTestScript("Test-VirtualMachineScaleSetAddProxyAgentExtension");
         }
     }
 }

src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1

@@ -5969,9 +5969,9 @@ function Test-ProxyAgentSetting
 
 <#
 .SYNOPSIS
-Test-VMSSAddProxyAgentExtension creates a VMSS with Enabled ProxyAgent and added ProxyAgentExtension
+Test-VirtualMachineScaleSetAddProxyAgentExtension creates a VMSS with Enabled ProxyAgent and added ProxyAgentExtension
 #>
-function Test-VMSSAddProxyAgentExtension
+function Test-VirtualMachineScaleSetAddProxyAgentExtension
 {
     # Setup
     $rgname = Get-ComputeTestResourceName;

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.cs

@@ -692,9 +692,9 @@ public void TestVirtualMachinePlacement()
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void TestVMAddProxyAgentExtension()
+        public void TestVirtualMachineAddProxyAgentExtension()
         {
-            TestRunner.RunTestScript("Test-VMAddProxyAgentExtension");
+            TestRunner.RunTestScript("Test-VirtualMachineAddProxyAgentExtension");
         }
     }
 }

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.ps1

@@ -7942,9 +7942,9 @@ function Test-VirtualMachinePlacement
 
 <#
 .SYNOPSIS
-Test-VMAddProxyAgentExtension creates a VM with Enabled ProxyAgent and added ProxyAgentExtension
+Test-VirtualMachineAddProxyAgentExtension creates a VM with Enabled ProxyAgent and added ProxyAgentExtension
 #>
-function Test-VMAddProxyAgentExtension
+function Test-VirtualMachineAddProxyAgentExtension
 {
     # Setup
     $resourceGroupName = Get-ComputeTestResourceName;

src/Compute/Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineScaleSetTests/TestVMSSAddProxyAgentExtension.json

@@ -164,7 +164,7 @@ public static ResourceConfig<VirtualMachine> CreateVirtualMachineConfig(
                             EncryptionAtHost = encryptionAtHostPresent,
                             UefiSettings = (enableVtpm != null || enableSecureBoot != null) ? new UefiSettings(enableSecureBoot, enableVtpm) : null,
                             SecurityType = securityType,
-                            ProxyAgentSettings = (enableProxyAgent == true || addProxyAgentExtension == true) ? new ProxyAgentSettings(enableProxyAgent) { AddProxyAgentExtension = addProxyAgentExtension } : null,
+                            ProxyAgentSettings = (enableProxyAgent != null || addProxyAgentExtension != null) ? new ProxyAgentSettings(enableProxyAgent) { AddProxyAgentExtension = addProxyAgentExtension } : null,
                         },
                         CapacityReservation = string.IsNullOrEmpty(capacityReservationGroupId) ? null : new CapacityReservationProfile
                         {

src/Compute/Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineScaleSetTests/TestVirtualMachineScaleSetAddProxyAgentExtension.json

@@ -106,7 +106,6 @@ public override void ExecuteCmdlet()
                 this.VM.SecurityProfile.ProxyAgentSettings.AddProxyAgentExtension = this.AddProxyAgentExtension;
             }
 
-
             WriteObject(this.VM);
         }
     }