Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip creating functions.metadata when source gen version of function metadata provider is enabled #1058

Open
kshyju opened this issue Sep 21, 2022 · 3 comments
Assignees
Labels
area: sdk blocked Items that cannot move forward at the moment. needs-discussion team-issue

Comments

@kshyju
Copy link
Member

kshyju commented Sep 21, 2022

When source generated version of function metadata provider is enabled, we do not need to create the functions.metadata file.

Currently the build task is creating an file with empty array as content.

@satvu
Copy link
Member

satvu commented Sep 21, 2022

We will need to add a condition that checks the FunctionsEnableWorkerIndexing MSBuild property to the 4 GenerateFunctionMetadata tasks in our MSBuild targets file (example here).

However, this is complicated by the fact that this task also contains the generation of the WorkerExtensions.csproj file (see line here). We'll have to separate out these tasks first then add the conditional checks.

Changes pending internal discussion/design in case these generation tasks were coupled together for a specific reason.

@jviau
Copy link
Contributor

jviau commented Dec 4, 2024

Currently the build task is creating an file with empty array as content.

This may have been a temporary bug you witnessed. Today the functions.metadata is fully populated even when source gen is enabled.

What is the value in skipping this generation? It will not impact runtime at all. The only 'value' I see is saving a bit of time during build. On the flip side, functions.metadata is a convenient file for customers to look at to see how their triggers are being processed. Is it worth skipping that generation?

@fabiocav fabiocav added the blocked Items that cannot move forward at the moment. label Dec 4, 2024
@fabiocav
Copy link
Member

fabiocav commented Dec 4, 2024

Blocked on #2763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sdk blocked Items that cannot move forward at the moment. needs-discussion team-issue
Projects
None yet
Development

No branches or pull requests

4 participants