Skip to content

[auto] docs: add reviewer-sourced rules to Copilot instructions (2026-06-22 → 2026-06-29) #8849

Description

@github-actions

Proposed by the Update Instructions From PR Reviews workflow.

Settings

Stats

PR comment themes promoted

  • Test goroutine safety: t.Fatal / require.NoError must not be called from non-test goroutines (httptest handlers, sync.Once closures, etc.) — #8790
  • Duplicate extension helpers: export from owning package, don't copy function bodies#8794, #8809
  • User-provided path validation: azure.yaml fields must not escape the service directory#8779, #8599
  • Cross-extension test isolation: skip when sibling files absent; add CODEOWNERS for extension functional tests#8809, #8754

Generated by Update Instructions From PR Reviews · 791 AIC · ⌖ 19.6 AIC · ⊞ 36.3K ·


Note

This was originally intended as a pull request, but GitHub Actions is not permitted to create or approve pull requests in this repository.
The changes have been pushed to branch automated/update-instructions-from-pr-reviews.

Click here to create the pull request

To fix the permissions issue, go to SettingsActionsGeneral and enable Allow GitHub Actions to create and approve pull requests. See also: gh-aw FAQ

Show patch preview (124 of 124 lines)
From b7ec586eaa2413a75c6b98903e2df3e1f858e508 Mon Sep 17 00:00:00 2001
From: "github-actions[bot]" <github-actions[bot]@users.noreply.github.com>
Date: Mon, 29 Jun 2026 10:18:34 +0000
Subject: [PATCH] docs: add reviewer-sourced rules to Copilot instructions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Four recurring themes promoted from PR reviews merged since 2026-06-22:

1. go.instructions.md: Test goroutine safety — t.Fatal/require.NoError must
   not be called from httptest handler goroutines or other non-test goroutines;
   HTTP headers must be set before WriteHeader. (Source: #8790)

2. extensions.instructions.md: Duplicate helper detection — export shared
   helpers from the owning package instead of copying function bodies across
   extension packages. (Source: #8794, #8809)

3. extensions.instructions.md: User-provided path validation — paths from
   azure.yaml fields (instructions, entryPoint, etc.) must be validated to
   stay within the expected root directory. (Source: #8779, #8599)

4. extensions.instructions.md: Cross-extension test isolation — tests loading
   sibling-extension files must skip when absent; extension functional tests
   should have dedicated CODEOWNERS entries. (Source: #8809, #8754)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 .../instructions/extensions.instructions.md   | 37 +++++++++++++++++++
 .github/instructions/go.instructions.md       | 32 ++++++++++++++++
 2 files changed, 69 insertions(+)

diff --git a/.github/instructions/extensions.instructions.md b/.github/instructions/extensions.instructions.md
index f46a73d..9fa70ba 100644
--- a/.github/instructions/extensions.instructions.md
+++ b/.github/instructions/extensions.instructions.md
@@ -16,3 +16,40 @@ applyTo:
 - Follow extension guidelines in: cli/azd/docs/extensions/extensions-style-guide.md. If the work
   violates any of these principles, include a link to the guide so the user can read it and 
... (truncated)

Metadata

Metadata

Assignees

No one assigned

    Type

    No fields configured for Task.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions