Skip to content

Commit 4ff4fe4

Browse files
hemarinaCopilot
andcommitted
docs: address jongio round 4 — add ai_model_quota check, shell→kind, fix IoC regression, update glossary
- provisioning-pipeline.md: add ai_model_quota as second preflight check - azure-yaml-schema.md: shell→kind in hook example, add infracreate/infradelete hooks - system-overview.md: fix IoC example regression (MustRegisterTransient→MustRegisterSingleton) - glossary.md: update preflight description to match implemented checks Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 2601fe7 commit 4ff4fe4

4 files changed

Lines changed: 9 additions & 6 deletions

File tree

docs/architecture/provisioning-pipeline.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,9 @@ For Bicep, azd can generate a fully resolved deployment snapshot using `bicep sn
2626
Client-side validation that runs after compilation but before deployment:
2727

2828
- **Role assignment permissions** — Checks if the user has required RBAC roles for role assignments in the template
29+
- **AI model quota** — Validates that sufficient AI model capacity is available in the target region
2930

30-
The preflight framework is pluggable — new checks can be added via `AddCheck()`. Currently only role assignment permissions is implemented; additional checks (e.g., resource conflicts, quota validation) can be added as needed.
31+
The preflight framework is pluggable — new checks can be added via `AddCheck()`.
3132

3233
**UX behavior:**
3334

docs/architecture/system-overview.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ See [Command Execution Model](command-execution-model.md) for details.
5252
All services are registered in `cmd/container.go` using the IoC container (`pkg/ioc`). Services are resolved at runtime — never instantiated directly.
5353

5454
```go
55-
container.MustRegisterTransient(resolveFn any)
55+
container.MustRegisterSingleton(func(dep *Dependency) *MyService {
56+
return &MyService{dep: dep}
57+
})
5658
```
5759

5860
### Infrastructure Provisioning

docs/concepts/glossary.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ A hash-based mechanism that tracks whether the IaC template has changed since th
4848

4949
### Preflight Checks
5050

51-
Client-side validation that runs after Bicep compilation but before server-side deployment. Checks resource availability, permissions, and potential conflicts to surface issues early.
51+
Client-side and server-side validation that runs after Bicep compilation but before deployment. Validates role assignment permissions and AI model quotas to surface issues early.
5252

5353
## Extensions
5454

docs/reference/azure-yaml-schema.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,16 +65,16 @@ Hooks run user-defined scripts at lifecycle points:
6565
```yaml
6666
hooks:
6767
preprovision:
68-
shell: sh
68+
kind: sh
6969
run: ./scripts/setup.sh
7070
postdeploy:
71-
shell: sh
71+
kind: sh
7272
run: ./scripts/smoke-test.sh
7373
```
7474

7575
Available hook points (each supports `pre` and `post` prefixes):
7676

77-
- **Command hooks (project-level):** `provision`, `deploy`, `down`, `up`, `restore`, `package`, `publish`
77+
- **Command hooks (project-level):** `provision`, `deploy`, `down`, `up`, `restore`, `package`, `infracreate`, `infradelete`, `publish`
7878
- **Service lifecycle hooks (service-level):** `restore`, `build`, `package`, `publish`, `deploy`
7979

8080
For example, `preprovision` runs before provisioning, `postdeploy` runs after deployment. Service-level hooks are defined under a service's `hooks` section in `azure.yaml` and apply only to that service.

0 commit comments

Comments
 (0)