fix: correct jitter range and pagination test type mismatches

- resilient_http_client.go: fix jitter range from [0.5, 1.0) to [0.8, 1.2) matching test expectations
- pagination_test.go: fix CollectTruncatedByMaxPages to properly test MaxPages truncation with matching types
- pagination_test.go: fix NotTruncatedOnNaturalEnd to test natural end is not truncated with correct types

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: jongio

cli/azd/pkg/azdext/pagination_test.go

@@ -487,7 +487,7 @@ func TestPager_CollectTruncatedByMaxPages(t *testing.T) {
 	t.Parallel()
 
 	page1 := pageJSON([]int{1, 2}, "https://example.com/api?page=2")
-	_ = pageJSON([]int{3, 4}, "") // page2 not needed; only page1 used for oversized-response test
+	page2 := pageJSON([]int{3, 4}, "")
 
 	doer := &mockDoer{
 		responses: []*doerResponse{
@@ -496,17 +496,25 @@ func TestPager_CollectTruncatedByMaxPages(t *testing.T) {
 				Body:       io.NopCloser(strings.NewReader(page1)),
 				Header:     http.Header{},
 			}},
+			{resp: &http.Response{
+				StatusCode: http.StatusOK,
+				Body:       io.NopCloser(strings.NewReader(page2)),
+				Header:     http.Header{},
+			}},
 		},
 	}
 
-	pager := NewPager[string](doer, "https://example.com/api", nil)
+	pager := NewPager[int](doer, "https://example.com/api", &PagerOptions{MaxPages: 1})
 
-	_, err := pager.NextPage(context.Background())
-	if err == nil {
-		t.Fatal("expected error for oversized response")
+	all, err := pager.Collect(context.Background())
+	if err != nil {
+		t.Fatalf("Collect failed: %v", err)
 	}
-	if !strings.Contains(err.Error(), "response exceeds max page size") {
-		t.Errorf("error = %q, want explicit max page size error", err.Error())
+	if len(all) != 2 {
+		t.Fatalf("len(all) = %d, want 2 (only first page)", len(all))
+	}
+	if !pager.Truncated() {
+		t.Fatal("expected Truncated() = true when MaxPages stops collection early")
 	}
 }
 
@@ -658,7 +666,7 @@ func TestPager_TruncatedByMaxItems(t *testing.T) {
 func TestPager_NotTruncatedOnNaturalEnd(t *testing.T) {
 	t.Parallel()
 
-	body := pageJSON([]string{"a", "b"}, "")
+	body := pageJSON([]int{1, 2}, "")
 	doer := &mockDoer{
 		responses: []*doerResponse{
 			{resp: &http.Response{
@@ -678,8 +686,8 @@ func TestPager_NotTruncatedOnNaturalEnd(t *testing.T) {
 	if len(all) != 2 {
 		t.Fatalf("len(all) = %d, want 2", len(all))
 	}
-	if !pager.Truncated() {
-		t.Fatal("expected Truncated() = true when MaxPages stops collection early")
+	if pager.Truncated() {
+		t.Fatal("Truncated() = true, want false (natural end, no more pages)")
 	}
 }
 

cli/azd/pkg/azdext/resilient_http_client.go

@@ -248,13 +248,13 @@ func (rc *ResilientClient) applyAuth(ctx context.Context, req *http.Request) err
 func (rc *ResilientClient) backoff(attempt int) time.Duration {
 	delay := min(time.Duration(float64(rc.opts.InitialDelay)*math.Pow(2, float64(attempt-1))), rc.opts.MaxDelay)
 
-	// Add jitter: randomize between [50%, 100%) of computed delay to prevent
+	// Add jitter: randomize between [80%, 120%) of computed delay to prevent
 	// thundering herd when multiple clients retry simultaneously.
 	var b [8]byte
-	jitter := 0.75
+	jitter := 1.0
 	if _, err := rand.Read(b[:]); err == nil {
 		randFloat := float64(binary.BigEndian.Uint64(b[:])) / (float64(math.MaxUint64) + 1)
-		jitter = 0.5 + randFloat*0.5
+		jitter = 0.8 + randFloat*0.4
 	}
 
 	return time.Duration(float64(delay) * jitter)