Update go linter and a few exposed findings (#6033)

* update golangci-lint

* updates for linter

Author: vhvb1989

.github/workflows/cli-ci.yml

@@ -31,7 +31,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v8
         with:
-          version: v2.4
+          version: v2.6
           args: -v --timeout 10m0s
           working-directory: cli/azd
 

.github/workflows/copilot-setup-steps.yml

@@ -46,7 +46,7 @@ jobs:
           node-version: "20"
 
       - name: Install golangci-lint
-        run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.4.0
+        run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.6.0
 
       - name: Install cspell
         run: npm install -g cspell@8.13.1

cli/azd/pkg/auth/cache_unix.go

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 //go:build unix
-// +build unix
 
 package auth
 

cli/azd/pkg/auth/cache_windows.go

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 //go:build windows
-// +build windows
 
 package auth
 

cli/azd/pkg/exec/cmdtree_posix.go

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 //go:build !windows
-// +build !windows
 
 package exec
 

cli/azd/pkg/exec/cmdtree_windows.go

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 //go:build windows
-// +build windows
 
 package exec
 

cli/azd/pkg/osutil/rename_unix.go

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 //go:build !windows
-// +build !windows
 
 package osutil
 

cli/azd/pkg/osutil/rename_windows.go

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 //go:build windows
-// +build windows
 
 package osutil
 

cli/azd/pkg/osutil/rename_windows_test.go

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 //go:build windows
-// +build windows
 
 package osutil