Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigureRefresh: support for watching a group of keys #153

Open
cannehag opened this issue Sep 27, 2019 · 5 comments
Open

ConfigureRefresh: support for watching a group of keys #153

cannehag opened this issue Sep 27, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request .NET Config Provider Issues related to the AppConfig .NET Core configuration provider. service Issues related to the AppConfig service

Comments

@cannehag
Copy link

Hi, I'm use App Configuration registration as follows:

builder.AddAzureAppConfiguration(configure =>
{
var label = $"{config["Config:AppName"]}-{config["Config:ConfigName"]}";
configure.Connect("xyz")
.Use(KeyFilter.Any, label)
});

This is working perfectly fine. But when adding a ConfigureRefresh with the same key/label filter. I don't get any updates.
.ConfigureRefresh(refresh =>
{
refresh.Register(KeyFilter.Any, label, true);
});

I would expect this to work. I have seen the workaround using a sentinel key. But thats really just a workaround and not the ideal solution. Is a more configurable solution in the roadmap ?

@drago-draganov
Copy link
Contributor

Currently we support watching keys individually. The sentinel key approach is also to avoid getting intermediate states during update of multiple keys.
We plan to extend the refresh to allow the scenario you mentioned, indeed.

@drago-draganov drago-draganov added enhancement New feature or request service Issues related to the AppConfig service .NET Config Provider Issues related to the AppConfig .NET Core configuration provider. labels Sep 27, 2019
@Tankatronic
Copy link

Is this feature planned for the near future?

@zhenlan zhenlan changed the title ConfigureRefresh need better options ConfigureRefresh: support for watching a group of keys Feb 16, 2021
@zhenlan
Copy link
Contributor

zhenlan commented Feb 16, 2021

@Tankatronic this is something we want to do but not planned for the near future due to other priorities.

@Edgaras91
Copy link

Curious if the priorities have changed for this? Seems like the "sentinel" key way should be an optional feature to achieve all key refresh, and by default, it should allow for all keys to be monitored and refreshed as per original post using KeyFilter.Any.

Is there a way around this? for example by enumerating the IConfiguration Azure provider's keys? And subscribe to each of them?

image

@drago-draganov
Copy link
Contributor

@Edgaras91 This is still on our radar. We are looking into service side solutions. Subscribing for individual keys on the client side would lead to significant amount of poll requests. I'm also thinking of instances with hundreds and thousands of key-values. That can easily go above the request quotas and result into unexpected overage charge and/or throttling.
In addition, client side may have issues when new keys are being added to the specific set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request .NET Config Provider Issues related to the AppConfig .NET Core configuration provider. service Issues related to the AppConfig service
Projects
Development

No branches or pull requests

5 participants