Skip to content

Conversation

@sephilli
Copy link

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

2. Run app locally : `mvn spring-boot:run`

3. Use postman or any debugging tool and open url - http://localhost:8080
3. Use [Postman](https://www.postman.com/) or any debugging tool and open url - http://localhost:8080
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravithanneeru - I just went through this as well.
I think that advising to 'open url - http://localhost:8080' is insufficient instructions.
Firstly, that just returns a 404 as there is no default route.
Secondly, all of the controller endpoints require a parameter - e.g. serverCallId in .....

@GetMapping("/startRecording")
public StartCallRecordingResult startRecording(String serverCallId)

I tried a few different ways to reference serverCallId, but since it is not directly stated here, I wasn't sure how. When I went to reference Spring Boot, it seems that serverCallId would need to be specified in the GetMapping via something like @GetMapping("/startRecording/{serverCallId}")

I fixed similar things to what I suggested and what was fixed in the C# quickstart, but can you please continue this based on my comments above?

cc @bharat-kalyan-namburi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant