-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added constructors to allow multiple running instances of FFmpeg #50
Open
evandixon
wants to merge
9
commits into
AydinAdn:master
Choose a base branch
from
evandixon:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Aug 23, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 35e0ae3 - Browse repository at this point
Copy the full SHA 35e0ae3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e34b9a1 - Browse repository at this point
Copy the full SHA e34b9a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cea70d - Browse repository at this point
Copy the full SHA 9cea70dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fa81fe - Browse repository at this point
Copy the full SHA 4fa81feView commit details -
Configuration menu - View commit details
-
Copy full SHA for a194876 - Browse repository at this point
Copy the full SHA a194876View commit details
Commits on Nov 8, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 6f4150e - Browse repository at this point
Copy the full SHA 6f4150eView commit details -
Revert "Deleted nuspec file in preparation for PR"
This reverts commit a194876.
Configuration menu - View commit details
-
Copy full SHA for 81ca42a - Browse repository at this point
Copy the full SHA 81ca42aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 47801c4 - Browse repository at this point
Copy the full SHA 47801c4View commit details
Commits on Feb 8, 2017
-
Fixed threading issues & improved code quality
- There is no longer a singular FFmpeg process, because outside of the conversion function, it was only used during EngineBase.Dispose, where nothing happened because the conversion function disposes it - Added thread safety to EnsureFFmpegFileExists - Changed default path of the ffmpeg executable to be in the temporary directory, to avoid littering the root of the drive. Included in this path is a new Guid, which will allow it to be cleaned up without affecting other instances of Engine - Removed the event handler from FFmpegProcess.ErroDataReceived. In general (I don't know about this particular case), not removing event handlers can prevent the garbage collector from cleaning up the class
Configuration menu - View commit details
-
Copy full SHA for cd911ca - Browse repository at this point
Copy the full SHA cd911caView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.