Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added constructors to allow multiple running instances of FFmpeg #50

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Commits on Aug 23, 2016

  1. Configuration menu
    Copy the full SHA
    35e0ae3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e34b9a1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9cea70d View commit details
    Browse the repository at this point in the history
  4. Added more constructors

    evandixon committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    4fa81fe View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a194876 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2016

  1. Removed packages folder

    evandixon committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    6f4150e View commit details
    Browse the repository at this point in the history
  2. Revert "Deleted nuspec file in preparation for PR"

    This reverts commit a194876.
    evandixon committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    81ca42a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    47801c4 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2017

  1. Fixed threading issues & improved code quality

    - There is no longer a singular FFmpeg process, because outside of the conversion function, it was only used during EngineBase.Dispose, where nothing happened because the conversion function disposes it
    - Added thread safety to EnsureFFmpegFileExists
    - Changed default path of the ffmpeg executable to be in the temporary directory, to avoid littering the root of the drive.  Included in this path is a new Guid, which will allow it to be cleaned up without affecting other instances of Engine
    - Removed the event handler from FFmpegProcess.ErroDataReceived.  In general (I don't know about this particular case), not removing event handlers can prevent the garbage collector from cleaning up the class
    evandixon committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    cd911ca View commit details
    Browse the repository at this point in the history