Skip to content

Add PocketPay Contracts meaningful change threshold guide #545

Description

@El-swaggerito

Description

Difficulty: Hard

Type: Documentation

Summary

Create a meaningful change threshold guide for PocketPay Contracts PRs.

Current Behaviour

Some PRs may only include very small code changes without solving the underlying issue.

Expected Behaviour

The repo should explain that line count alone is not the standard, but the change must be complete, tested, and aligned with the issue requirements.

Suggested Implementation

Document examples of meaningful changes, insufficient changes, and how reviewers should assess scope.

Files or Areas Likely Affected

  • contracts/
  • src/
  • tests/
  • docs/
  • README.md
  • Makefile

Acceptance Criteria

  • Meaningful change threshold guide is added.
  • Guide explains that line count alone is not the only measure.
  • Small but complete changes are distinguished from small incomplete changes.
  • Insufficient examples are included.
  • Reviewer assessment guidance is included.
  • README links to the guide.

Additional Notes

This responds to concerns about very small merged PRs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    GrantFox OSSIssue tracked for GrantFox OSS contributionMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Official GrantFox campaign labelcontractSmart contract related workdeveloper-experienceDeveloper experience workdocumentationDocumentation workexpertExpert difficultysorobanSoroban smart contract work

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions