Setting IsVisible = false closes dialog instead of hiding

[AnastassiaP]

Describe the bug

Showing dialog and then setting its visibility to false closes the dialog window, then on calling ShowDialog again the following exception is received:

Unhandled exception. System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.InvalidOperationException: Cannot re-show a closed window.

To Reproduce

1. create new dialog window:
   private DialogWindow dialogWindow = new DialogWindow();

2. show dialog window
   dialogWindow.ShowDialog(this);

3. set:
   IsVisible = false;

4. re-show dialog
   dialogWindow.ShowDialog(this);

5. Exception is thrown

Expected behavior

1. Dialog window is not actually closed, but is just hidden
2. No exception is thrown on dialog re-open

Avalonia version

11.2.3

OS

macOS, Windows, Linux

Additional context

as an alternative Hide() is hiding window as expected

[grokys]

This check causes setting IsVisible = false to close the window:

Avalonia/src/Avalonia.Controls/Window.cs

Lines 648 to 651 in fdadfb8

	if (_showingAsDialog)
	{
	Close(false);
	}

However Using Window.Hide() takes a completely different code path which doesn't have this check:

Avalonia/src/Avalonia.Controls/Window.cs

Line 596 in fdadfb8

public override void Hide()

And it seems to work fine. I think the check in IsVisibleChanged can be removed.

There does seem to be another problem (at least on Windows) where hiding a modal window causes the parent window to be sent behind the previously activated application.