Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add the goals step back to site-setup on staging #97255

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

p-jackson
Copy link
Member

@p-jackson p-jackson commented Dec 9, 2024

The goals step was unintentionally removed from all flows on staging in #96866. But we only want it removed when the user began on the onboarding flow.

Another approach from @arthur791004 was #97219 which simply disabled the feature flag on staging. This would be good too, but we want internal stakeholders to be able to see the onboarding changes as easily as possible.

Related to #

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@p-jackson p-jackson self-assigned this Dec 9, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 9, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~2 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +12 B  (+0.0%)       +2 B  (+0.0%)
entry-main           +12 B  (+0.0%)       +2 B  (+0.0%)
entry-login          +12 B  (+0.0%)       +2 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~282 bytes removed 📉 [gzipped])

name             parsed_size           gzip_size
site-setup-wg         -462 B  (-0.4%)     -160 B  (-0.6%)
site-setup-flow       -462 B  (-0.4%)     -160 B  (-0.7%)
onboarding-flow       -305 B  (-0.4%)     -122 B  (-1.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/site-setup-flow-staging on your sandbox.

The goals step was unintentionally removed from all flows on staging in
#96866. But we only want it removed when the user began on the
`onboarding` flow.
@p-jackson p-jackson force-pushed the fix/site-setup-flow-staging branch from e62f8b9 to 4d784d3 Compare December 9, 2024 19:31
@p-jackson p-jackson requested a review from a team December 9, 2024 19:39
@p-jackson p-jackson merged commit 4993887 into trunk Dec 9, 2024
13 checks passed
@p-jackson p-jackson deleted the fix/site-setup-flow-staging branch December 9, 2024 20:18
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants