Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Implement WPCOM hosting section v3. #97230

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

jkguidaven
Copy link
Contributor

@jkguidaven jkguidaven commented Dec 9, 2024

This PR implements the new WPCOM hosting section v3 (feature list, testimonials, and client relationship contents).

Screenshot 2024-12-09 at 6 24 24 PM Screenshot 2024-12-09 at 6 24 35 PM Screenshot 2024-12-09 at 6 24 47 PM

Depends on #97162
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1547
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1548
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1549

Proposed Changes

  • Implement the 'Feature list', 'Testimonials', and 'Client relationship' sections.

Why are these changes being made?

  • This is part of the In-product hosting page v3 project.

Testing Instructions

  • Use the A4A live link and go to the /marketplace/hosting/wpcom page.
  • Confirm you see the new sections.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven self-assigned this Dec 9, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 9, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a/wpcom-hosting-page-v3 on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 9, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~975 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-marketplace      +5873 B  (+0.7%)     +902 B  (+0.4%)
a8c-for-agencies-migrations        +247 B  (+0.0%)      +73 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jkguidaven jkguidaven requested a review from a team December 9, 2024 10:36
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2024
@jkguidaven jkguidaven marked this pull request as ready for review December 9, 2024 10:38
@jkguidaven jkguidaven force-pushed the add/a4a/hosting-page-v3-header branch from cf57e33 to 408ad0e Compare December 11, 2024 04:38
Base automatically changed from add/a4a/hosting-page-v3-header to trunk December 11, 2024 04:58
@jkguidaven jkguidaven force-pushed the add/a4a/wpcom-hosting-page-v3 branch from f90e481 to eca52f2 Compare December 11, 2024 05:03
Copy link
Contributor

@cleacos cleacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and I can see the new sections.

LGTM!

@jkguidaven jkguidaven merged commit 9f9112a into trunk Dec 11, 2024
11 checks passed
@jkguidaven jkguidaven deleted the add/a4a/wpcom-hosting-page-v3 branch December 11, 2024 08:16
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 11, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 11, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17058001

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @jkguidaven for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants