Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed strictly typed checkbox labels #97204

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Conversation

p-jackson
Copy link
Member

@p-jackson p-jackson commented Dec 8, 2024

Fixes e2e tests that broke when #97203 was merged. I don't know why these tests ran during canary but not during CI ...

#97203 changes the goal checkbox labels, so the e2e selectors were no longer correct.

There are many more checkbox labels now
These goals now have new names
@p-jackson p-jackson self-assigned this Dec 8, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@p-jackson p-jackson merged commit 640bfe8 into trunk Dec 8, 2024
10 of 12 checks passed
@p-jackson p-jackson deleted the fix/e2e-test-new-goal-labels branch December 8, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants