Purchases: Highlight Upgrades Owned by Other Administrators #97198
+51
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #96328
Proposed Changes
Provides an informational notice when the user goes to manage their upgrades, and sees the "no purchases
EmptyContent
" because the subscriptions on the sites for which they are an admin are managed by somebody else.NOTE: this only works when the user has no purchases (as opposed to having their own sites with purchases). I imagine that would capture most the use cases in practice, but the problem is that when the user has their own sites, we need to check whether they own that specific purchase. This would require checking the individual site purchases (as opposed to the general
getSites
data), but without owning the purchase, they don't have the authorisation to do so. I think that might, therefore, require an endpoint change. As such, this only implements one of the two designs in the original issue.Why are these changes being made?
See original issue - lots of users apparently face confusion over why they can't manage an upgrade.
Testing Instructions
cc @sirbrillig, @DavidRothstein