-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arrows to switch dates for the post details page #97196
Add arrows to switch dates for the post details page #97196
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~4 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~308 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
235ec2a
to
f929be6
Compare
f929be6
to
b211b9a
Compare
onPeriodChange={ this.onPeriodChange } | ||
disablePreviousArrow={ disablePreviousArrow } | ||
disableNextArrow={ disableNextArrow } | ||
date={ null } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix the isToday check in a follow-up PR, which would make passing Null
date unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described! Thanks for the work, @mavegaf. 👍🏼
Related to # https://github.com/Automattic/red-team/issues/257
Proposed Changes
days
, there are more dates that can be shown, so logic was added to navigate over them using the current data.arrows-in-post-details-page.mov
Why are these changes being made?
Testing Instructions
days
you can go to older dataPre-merge Checklist