Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrows to switch dates for the post details page #97196

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

mavegaf
Copy link
Contributor

@mavegaf mavegaf commented Dec 6, 2024

Related to # https://github.com/Automattic/red-team/issues/257

Proposed Changes

  • Add arrows to switch dates for the post details page
  • For the period days, there are more dates that can be shown, so logic was added to navigate over them using the current data.
arrows-in-post-details-page.mov

Why are these changes being made?

  • Consistency with the design

Testing Instructions

  • Use the arrows to navigate the data
  • For the period days you can go to older data

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Dec 6, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/arrows-to-switch-dates-for-the-post-details-page on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 6, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~4 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats        +24 B  (+0.0%)       +4 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~308 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-calypso-my-sites-stats-stats-post-detail      +1043 B  (+3.3%)     +304 B  (+3.3%)
async-load-store-app-store-stats-listview                  +24 B  (+0.0%)       +4 B  (+0.0%)
async-load-store-app-store-stats                           +24 B  (+0.0%)       +4 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mavegaf mavegaf force-pushed the add/arrows-to-switch-dates-for-the-post-details-page branch from 235ec2a to f929be6 Compare December 9, 2024 14:27
@mavegaf mavegaf force-pushed the add/arrows-to-switch-dates-for-the-post-details-page branch from f929be6 to b211b9a Compare December 10, 2024 00:05
@mavegaf mavegaf marked this pull request as ready for review December 10, 2024 13:51
@mavegaf mavegaf requested a review from kangzj December 10, 2024 13:51
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 10, 2024
@mavegaf mavegaf requested a review from a team December 10, 2024 13:52
@mavegaf mavegaf self-assigned this Dec 10, 2024
@mavegaf mavegaf added the [Feature] Stats Everything related to our analytics product at /stats/ label Dec 10, 2024
onPeriodChange={ this.onPeriodChange }
disablePreviousArrow={ disablePreviousArrow }
disableNextArrow={ disableNextArrow }
date={ null }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix the isToday check in a follow-up PR, which would make passing Null date unnecessary.

Copy link
Contributor

@dognose24 dognose24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! Thanks for the work, @mavegaf. 👍🏼

@kangzj kangzj merged commit 954a731 into trunk Dec 11, 2024
16 checks passed
@kangzj kangzj deleted the add/arrows-to-switch-dates-for-the-post-details-page branch December 11, 2024 02:00
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants