Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain management: Match upsell page with the new context design #97186

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented Dec 6, 2024

Closes #96819

Proposed Changes

  • Extend the EmailComparison component to support adding container className
  • Customize the EmailComparison component to match Figma design in context when the calypso/all-domain-management flag is ON

Why are these changes being made?

  • We are reusing the same component in the all-domain-management context

Testing Instructions

  • Go to /domains/manage?flags=calypso/all-domain-management
  • Make sure you have your domain (you can purchase a .blog)
  • Select your domain and choose the Email tab
  • Check if there is an Upsell component without internal navigation (back button)
  • Check if the card component has rounded corner
Before After
Screenshot 2024-12-06 at 19 19 54 Screenshot 2024-12-06 at 19 20 05

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bogiii bogiii requested a review from a team December 6, 2024 18:13
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 6, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~66 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
email         +142 B  (+0.0%)      +66 B  (+0.0%)
domains       +142 B  (+0.0%)      +66 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/domains-management-email on your sandbox.

@bogiii bogiii marked this pull request as ready for review December 6, 2024 18:26
@bogiii bogiii requested a review from a team as a code owner December 6, 2024 18:26
@Imran92 Imran92 assigned Imran92 and bogiii and unassigned Imran92 Dec 9, 2024
Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall 👍 Just commented about a bug

client/my-sites/email/email-management/email-home.tsx Outdated Show resolved Hide resolved
@bogiii bogiii requested a review from Imran92 December 10, 2024 11:38
@bogiii bogiii merged commit 25d5189 into trunk Dec 10, 2024
11 checks passed
@bogiii bogiii deleted the update/domains-management-email branch December 10, 2024 17:33
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show emails page tab content for the case when no mailbox is there - upsell page
4 participants