Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Fix the bug with bundle licenses not showing on the licenses page correctly. #97169

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jkguidaven
Copy link
Contributor

This PR addresses a regression on the licenses page that prevents the rendering of the bundle license preview for bundle licenses.

Context: p1733478916071639-slack-C06JY8QL0TU

Proposed Changes

  • Make sure we always pass the license ID as the parent license ID in the root of our list.

Why are these changes being made?

  • User is unable to view the bundle licenses correctly in the Licenses page.

Testing Instructions

  • Use the A4A live link and go to the /marketplace page.
  • Purchase any bundle licenses.
  • Go to the /licenses page
  • Confirm the bundle license is rendered correctly.
Screenshot 2024-12-06 at 6 36 47 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven requested a review from a team December 6, 2024 10:37
@jkguidaven jkguidaven self-assigned this Dec 6, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
@jkguidaven jkguidaven marked this pull request as ready for review December 6, 2024 10:37
@jkguidaven jkguidaven changed the title A4A: Fix bug with bundle licenses not showing in the licenses page correctly. A4A: Fix the bug with bundle licenses not showing on the licenses page correctly. Dec 6, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/a4a/bug-with-license-bundle-not-showing on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 6, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~6 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
a8c-for-agencies-purchases        +28 B  (+0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@vitozev vitozev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing it so quickly.

@jkguidaven jkguidaven force-pushed the fix/a4a/bug-with-license-bundle-not-showing branch from 8389750 to 09e6a2d Compare December 6, 2024 10:48
@jkguidaven jkguidaven merged commit db6e07b into trunk Dec 6, 2024
11 checks passed
@jkguidaven jkguidaven deleted the fix/a4a/bug-with-license-bundle-not-showing branch December 6, 2024 10:59
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants