-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move big sky button from nav-container to filters container #97165
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
@madhusudhand note that the design spec has changed. See https://github.com/Automattic/dotcom-forge/issues/10093. |
30a3ba0
to
cddeb6a
Compare
Updated the layout as per the new design spec. |
@madhusudhand could we update the button following the design spec? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be taken care in https://github.com/Automattic/dotcom-forge/issues/10091 |
Got it, thanks, I missed the context 😄 |
@fditrapani I have used the component without any overrides. However, few styles differ from the design spec as mentioned by @taipeicoder. |
3212895
to
c25ac4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not get caught on bikeshedding! We can adjust later according to @fditrapani's feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping! I couldn't get the button to show because I'm not sure which conditions to show it in.
What you have looks good from the screenshots. Let's go with common components without any updates for now. We can adjust later if necessary.
c25ac4b
to
baaef9f
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Fixes: https://github.com/Automattic/dotcom-forge/issues/10093
Proposed Changes
Create yours with AI
toDesign with AI
Why are these changes being made?
Testing Instructions
Pre-merge Checklist