Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move big sky button from nav-container to filters container #97165

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

madhusudhand
Copy link
Member

@madhusudhand madhusudhand commented Dec 6, 2024

Fixes: https://github.com/Automattic/dotcom-forge/issues/10093

Proposed Changes

  • Updated label of the button Create yours with AI to Design with AI
  • Moved the button from header navigation to filters area
  • Button is visible in the header area in small screens instead of in filters.
image image

Why are these changes being made?

  • To match new designs

Testing Instructions

  • Verify the design picker UI in large and small screens

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@madhusudhand madhusudhand requested a review from a team December 6, 2024 09:08
@madhusudhand madhusudhand self-assigned this Dec 6, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
@madhusudhand madhusudhand changed the title Move big buttons from nav-container to setup-container Move big sky button from nav-container to setup-container Dec 6, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@taipeicoder
Copy link
Contributor

@madhusudhand note that the design spec has changed. See https://github.com/Automattic/dotcom-forge/issues/10093.

@madhusudhand madhusudhand force-pushed the fix/big-sky-small-screens branch 2 times, most recently from 30a3ba0 to cddeb6a Compare December 9, 2024 08:40
@madhusudhand
Copy link
Member Author

Updated the layout as per the new design spec.

@madhusudhand madhusudhand changed the title Move big sky button from nav-container to setup-container Move big sky button from nav-container to filters container Dec 9, 2024
@taipeicoder
Copy link
Contributor

@madhusudhand could we update the button following the design spec?

Screenshot 2024-12-09 at 5 03 48 PM

Screenshot 2024-12-09 at 5 04 26 PM

Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On ~700-ish screen width, the button layout looks as follows, is this intended? 🤔

image

@madhusudhand
Copy link
Member Author

On ~700-ish screen width, the button layout looks as follows, is this intended? 🤔

It will be taken care in https://github.com/Automattic/dotcom-forge/issues/10091

@fushar
Copy link
Contributor

fushar commented Dec 9, 2024

On ~700-ish screen width, the button layout looks as follows, is this intended? 🤔

It will be taken care in Automattic/dotcom-forge#10091

Got it, thanks, I missed the context 😄

@taipeicoder
Copy link
Contributor

taipeicoder commented Dec 10, 2024

Updated the layout as per the new design spec.

Font weight and text color are still different from the design spec.

Screenshot 2024-12-10 at 9 44 57 AM

Screenshot 2024-12-10 at 9 45 17 AM

@madhusudhand
Copy link
Member Author

Font weight and text color are still different from the design spec.

@fditrapani I have used the component without any overrides. However, few styles differ from the design spec as mentioned by @taipeicoder.
It would be recommended to use common styles across the app. Let us know if we need to update the style of the button component as per the current design so that it reflects everywhere in Calypso UI.

@madhusudhand madhusudhand force-pushed the fix/big-sky-small-screens branch from 3212895 to c25ac4b Compare December 10, 2024 06:55
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not get caught on bikeshedding! We can adjust later according to @fditrapani's feedback.

Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good 👍

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping! I couldn't get the button to show because I'm not sure which conditions to show it in.

What you have looks good from the screenshots. Let's go with common components without any updates for now. We can adjust later if necessary.

@madhusudhand madhusudhand force-pushed the fix/big-sky-small-screens branch from c25ac4b to baaef9f Compare December 11, 2024 04:46
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/big-sky-small-screens on your sandbox.

@madhusudhand madhusudhand merged commit 287fe55 into trunk Dec 11, 2024
11 checks passed
@madhusudhand madhusudhand deleted the fix/big-sky-small-screens branch December 11, 2024 07:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants