-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: Implement Hosting page v3 header. #97162
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1104 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
a5b2847
to
8fe5480
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Looking good, @jkguidaven! Just adding a few notes: As I scroll down, I see z-index issues (in Arc (Chrome)): Also noticing the tab color is different on small breakpoints: Finally, is there a way to bring the content back in once the user scrolls up (similar to the prototype)? |
Thanks, James! Just tested and looks good. Thanks for working with Noam to make that scroll behavior more graceful. Just two items I noticed with the header:
|
@madebynoam @jeffgolenski thank you both for catching bugs and areas to improve.
Done ✅
Fixed ✅
Fixed ✅
Both are fixed ✅ |
I plan to address the overlapping issues in a separate PR where I handle the Plan selector component. |
The code looks good. I can see the header and the scroll works well, except some overlapping elements and a scroll-down effect that seems the tab is not scrolling synchronous and smoothly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The current issues will be fixed in a follow-up PR.
Thanks for the review 🙇 Do you have some screencaps with the scrolling issue? I'd like to confirm if this is a performance issue related. |
cf57e33
to
408ad0e
Compare
@cleacos Ohh nvm saw what you mean.. @madebynoam I think the .35s animation kinda makes this more obvious. Should we revert to .2s? |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17057530 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Hi @jkguidaven, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
This PR implements the new Hosting Page v3 header.
Screen.Recording.2024-12-09.at.4.29.00.PM.mov
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1545
Proposed Changes
Why are these changes being made?
Testing Instructions
/marketplace/hosting
page.Pre-merge Checklist