Add statTypeToPlan to map stat types to plan in stats upsells #97159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
lsl
added
the
[Feature] Stats
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~98 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Initsogar
reviewed
Dec 6, 2024
| // Clicks is a paid stats feature that requires the personal plan | ||
| expect( statTypeToPlan( STAT_TYPE_CLICKS ) ).toEqual( PLAN_PERSONAL ); | ||
| // 7 Days is a free plan feature, this should not be gated but test we default to personal when the stat type doesn't make sense to query | ||
| expect( statTypeToPlan( STATS_FEATURE_DATE_CONTROL_LAST_7_DAYS ) ).toEqual( PLAN_PERSONAL ); |
Initsogar
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
LGTM!
Tests
| # | Plan | Site | Scenario | v3 flag | Expected result | Test result |
|---|---|---|---|---|---|---|
| 1 | Free | initsogarfree.* | Premium feature (e.g., search terms) | Yes | Should see premium upsell | ✅ |
| 2 | Free | initsogarfree.* | Premium feature (e.g., search terms) | No | Should see premium upsell | ✅ |
| 3 | Free | initsogarfree.* | Personal feature (e.g., clicks) | Yes | Should see personal upsell | ✅ |
| 4 | Free | initsogarfree.* | Personal feature (e.g., clicks) | No | Should see premium upsell | ✅ |
| 5 | Personal | initsogarpersonal.* | Premium feature (e.g., search terms) | Yes | Should see premium upsell | ✅ |
| 6 | Personal | initsogarpersonal.* | Premium feature (e.g., search terms) | No | Should see premium upsell | ✅ |
- v3 flag enabled: passing
?flags=stats/paid-wpcom-v3to the request. - v3 flag disabled: passing
?flags=-stats/paid-wpcom-v3to the request. Mimics the current production behavior.
Unit test
yarn run test-client client/my-sites/stats/test/stat-type-to-plan.ts
PASS client/my-sites/stats/test/stat-type-to-plan.ts
Test Suites: 1 passed, 1 total
Tests: 2 passed, 2 total
Snapshots: 0 total
Time: 3.448 s
Ran all test suites matching /client\/my-sites\/stats\/test\/stat-type-to-plan.ts/i.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #
Proposed Changes
stats/paid-wpcom-v3is enabled we want to upsell to the premium or personal plan depending on the stat. These stats will be split between STATS_PAID and STATS_COMMERCIAL site features with Add new paid stats site features: STATS_FREE, STATS_COMMERCIAL #97041.Testing Instructions
Personal site looking at search terms (commercial feature) should see premium upsell with and without the flag:
Free site looking at search terms should see premium upsell with and without the flag:
Free site looking at clicks should se personal upsell with the flag, premium upsell without the flag:
Unit tests:
Main change adds the premium link when looking at a premium feature
But upsells to personal when looking at a personal feature