Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Onboarding: Add a flag to force the onboarding to display #97147

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Dec 5, 2024

Related to pe7F0s-2eo-p2#comment-3074

Proposed Changes

  • Adds a check for a reader/force-onboarding flag to force the Reader onboarding flow to appear on /read regardless of any other condition.

Why are these changes being made?

  • Creates a way for folks to see the onboarding flow regardless of other conditions.
  • I thought this would be an easy way to share the Reader onborder with folks while we iterate on it.

Testing Instructions

  • Use Calypso Live
  • Go to /read?flags=reader/force-onboarding
  • You should see the Onboarding flow at the top
  • Go to /read
  • Assuming you're on an older account, you should not see the Onboarding flow.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@DustyReagan DustyReagan changed the title Add reader/force-onboarding flag Reader Onboarding: Add a flag to force the onboarding to display Dec 5, 2024
@DustyReagan DustyReagan self-assigned this Dec 5, 2024
@DustyReagan DustyReagan marked this pull request as ready for review December 5, 2024 22:46
@DustyReagan DustyReagan requested a review from a team as a code owner December 5, 2024 22:46
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/reader-force-onboarding-flag on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~18 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader        +37 B  (+0.0%)      +18 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! It won't work with the new feed layout, but as long as you're in the Stream layout you can see onboarding.

@DustyReagan DustyReagan merged commit bcb509f into trunk Dec 5, 2024
16 checks passed
@DustyReagan DustyReagan deleted the add/reader-force-onboarding-flag branch December 5, 2024 23:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants