Paid stats: Update Upsell to match design

[jwebbdev]

Related to https://github.com/Automattic/red-team/issues/304

Proposed Changes

• Add Lock Icon
• Updated copy
• Adjusts width / spacing to more closely match line breaks
• Remove NavigationPeriod arrows when viewing Upsell state

Didn't remove the arrows for the non-new date filtering. Just toggling off showArrows looks bad and wasn't sure fixing it up was necessary with the upcoming changes.

Why are these changes being made?

Latest Design:

Updates here:

Testing Instructions

• Open a calypso live branch and navigate to a free site's stats
• Compare the Upsell element to the Design above
• Ensure the Navigation period elements are hidden for new date filtering on upsell screen (may need to use the ?flags=stats/new-date-filtering)

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-126707

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-126707&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-126707&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-upsell-copy on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~47 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +267 B  (+0.0%)      +47 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[ederrengifo]

Thank you @jwebbdev ! A have two minor comments:

• Could we apply consistent spacing among the elements from the left side?
• I think the image gets distorted when reducing the browser width, could we avoid that?

[ederrengifo]

We can use these assets at 2x for the images to solve the image quality issue, and remove the align-self: stretch property so the image doesn't get distorted by the container height

[Initsogar]

Looks good!

I just noticed that we have some issues with borders that don’t look right. You can try addressing it in this PR if you’d like.

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17048911

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @jwebbdev for including a screenshot in the description! This is really helpful for our translators.