Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jetpack masterbar animations and missing icons #97128

Merged

Conversation

CodeyGuyDylan
Copy link
Contributor

Proposed Changes

  • Add missing icons for Growth bundle in Jetpack header
  • Fix animation for sections on header

Why are these changes being made?

  • The current header does not match the jetpack.com one and the animations are not working right

Testing Instructions

  1. Use the Calypso live link to go to /pricing
  2. Open up the header and ensure the animation of the items loading in looks good and that the Growth bundle has all it's icons
    image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~475 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
plans                                  +1706 B  (+0.1%)     +475 B  (+0.1%)
jetpack-connect                        +1706 B  (+0.1%)     +475 B  (+0.1%)
jetpack-cloud-pricing                  +1706 B  (+0.2%)     +475 B  (+0.2%)
jetpack-cloud-plugin-management        +1706 B  (+0.1%)     +475 B  (+0.1%)
jetpack-cloud-partner-portal           +1706 B  (+0.2%)     +475 B  (+0.2%)
jetpack-cloud-manage-pricing           +1706 B  (+0.5%)     +475 B  (+0.4%)
jetpack-cloud-features-comparison      +1706 B  (+0.3%)     +475 B  (+0.2%)
jetpack-cloud-agency-sites-v2          +1706 B  (+0.1%)     +475 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/jetpack-masterbar-animations-and-missing-icons on your sandbox.

Copy link
Contributor

@elliottprogrammer elliottprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix and improvement! Tested, works good.
LGTM! 👍

Comment on lines +744 to +759
@for $column from 1 through 5 {
&:nth-of-type(#{$column}) {
animation-delay: calc(
calc(#{$delay} * #{$column}) + calc(#{$duration} / #{$delay-ratio})
);

@for $i from 1 through 6 {
.header__submenu-links-list > li:nth-of-type(#{$i}) > a,
.header__submenu-links-list > li:nth-of-type(#{$i}) > p {
animation-delay: calc(
calc(#{$delay} * #{$i + 1 + $column}) +
calc(#{$duration} / #{$delay-ratio})
);
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor! Using Scss @for loops!! 🙌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't take too much credit, I mostly copied from jetpack.com and I made the original, terrible, SCSS here 😆 But thank you!

@CodeyGuyDylan CodeyGuyDylan merged commit 357fdd0 into trunk Dec 6, 2024
12 checks passed
@CodeyGuyDylan CodeyGuyDylan deleted the fix/jetpack-masterbar-animations-and-missing-icons branch December 6, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants