-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jetpack masterbar animations and missing icons #97128
Fix jetpack masterbar animations and missing icons #97128
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~475 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix and improvement! Tested, works good.
LGTM! 👍
@for $column from 1 through 5 { | ||
&:nth-of-type(#{$column}) { | ||
animation-delay: calc( | ||
calc(#{$delay} * #{$column}) + calc(#{$duration} / #{$delay-ratio}) | ||
); | ||
|
||
@for $i from 1 through 6 { | ||
.header__submenu-links-list > li:nth-of-type(#{$i}) > a, | ||
.header__submenu-links-list > li:nth-of-type(#{$i}) > p { | ||
animation-delay: calc( | ||
calc(#{$delay} * #{$i + 1 + $column}) + | ||
calc(#{$duration} / #{$delay-ratio}) | ||
); | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor! Using Scss @for loops!! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't take too much credit, I mostly copied from jetpack.com and I made the original, terrible, SCSS here 😆 But thank you!
Proposed Changes
Why are these changes being made?
Testing Instructions
/pricing
Pre-merge Checklist