Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Center: Update navigation logic for recent conversations #97124

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Dec 5, 2024

Fixes: https://github.com/Automattic/dotcom-forge/issues/10055

Proposed Changes

  • Open "Recent conversation" directly if only one conversation exists.

Why are these changes being made?

  • Less clicks for user to view conversation

Testing Instructions

  • Checkout branch or use live link
  • Navigate to /home?flags=help-center-experience
  • Make sure you only have one support conversation available ( you can create a new user ).
  • Under recent conversations, click on the conversation, and verify it opens the conversation directly.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@agrullon95 agrullon95 requested a review from a team as a code owner December 5, 2024 16:52
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 5, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~7 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
async-load-automattic-help-center        +14 B  (+0.0%)       +7 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@agrullon95 agrullon95 self-assigned this Dec 5, 2024
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and effective 👍

@agrullon95 agrullon95 merged commit 6a74c11 into trunk Dec 5, 2024
16 of 17 checks passed
@agrullon95 agrullon95 deleted the update/navigate-directly-to-only-convo branch December 5, 2024 22:07
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants