Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats-authors: toggle the "authors" module when there is only one to be displayed #97079

Closed
wants to merge 1 commit into from

Conversation

macbre
Copy link
Member

@macbre macbre commented Dec 4, 2024

Resolves #80534

Proposed Changes

  • This PR toggles the stats "Authors" module when only a single author statistic can be rendered there.

Testing Instructions

Find a site with just a single author active and a site with more active authors:

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@macbre macbre added the [Feature] Stats Everything related to our analytics product at /stats/ label Dec 4, 2024
@macbre macbre requested a review from Initsogar December 4, 2024 19:00
@macbre macbre self-assigned this Dec 4, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~83 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +124 B  (+0.0%)      +83 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug stats/hide-authors-components on your sandbox.

@@ -45,6 +46,14 @@ const StatAuthors: React.FC< StatsDefaultModuleProps > = ( {
getSiteStatsNormalizedData( state, siteId, statType, query )
) as [ id: number, label: string ];

// toggle the module if it's going to show just a single author
const isSingleAuthor = data?.length === 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid even if there is only one author in the response, but it wouldn't necessarily mean the site only has one author.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What condition should I use instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a useUsersQuery that can take a author_only: 1 option which may be able to get a list of authors on the site that you can check the size of.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment in the issue:

#80534 (comment)

@macbre
Copy link
Member Author

macbre commented Dec 9, 2024

Will be implemented in the backend code.

@macbre macbre closed this Dec 9, 2024
@macbre macbre deleted the stats/hide-authors-components branch December 9, 2024 15:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats: Hide author box until site has multiple authors
4 participants