-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats-authors: toggle the "authors" module when there is only one to be displayed #97079
Conversation
…be displayed Resolves #80534
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~83 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@@ -45,6 +46,14 @@ const StatAuthors: React.FC< StatsDefaultModuleProps > = ( { | |||
getSiteStatsNormalizedData( state, siteId, statType, query ) | |||
) as [ id: number, label: string ]; | |||
|
|||
// toggle the module if it's going to show just a single author | |||
const isSingleAuthor = data?.length === 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid even if there is only one author in the response, but it wouldn't necessarily mean the site only has one author.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What condition should I use instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a useUsersQuery
that can take a author_only: 1
option which may be able to get a list of authors on the site that you can check the size of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment in the issue:
Will be implemented in the backend code. |
Resolves #80534
Proposed Changes
Testing Instructions
Find a site with just a single author active and a site with more active authors:
Pre-merge Checklist