Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: remove subscribe label in sidebar #97076

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

eoigal
Copy link
Contributor

@eoigal eoigal commented Dec 4, 2024

Fixes https://github.com/Automattic/loop/issues/235

Proposed Changes

  • Hides the 'Subscribe' label when showing list of sites to follow in the Reader right sidebar

Before

Screenshot 2024-12-04 at 18 46 16

After

Screenshot 2024-12-04 at 18 45 58

Why are these changes being made?

  • Tidy up UI

Testing Instructions

  • Go to /read on calypso live and confirm the subscribe button is not showing the label in the right sidebar.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@eoigal eoigal requested a review from a team as a code owner December 4, 2024 18:46
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/reader-subscribe-label on your sandbox.

Copy link
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:

Screen Shot 2024-12-04 at 2 13 06 PM Screen Shot 2024-12-04 at 2 12 00 PM

I saw this misalignment issue, but it's on staging too:

Screen Shot 2024-12-04 at 2 13 26 PM

@eoigal eoigal merged commit b8fba99 into trunk Dec 5, 2024
10 checks passed
@eoigal eoigal deleted the remove/reader-subscribe-label branch December 5, 2024 09:41
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
mehmoodak pushed a commit that referenced this pull request Dec 6, 2024
* Reader: remove subscribe label in sidebar

* revert change - not needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants