Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a tooltip to the campaign details chart #97075

Merged
merged 10 commits into from
Dec 6, 2024
Merged

Conversation

j6ll
Copy link
Member

@j6ll j6ll commented Dec 4, 2024

Proposed Changes

Here are the original designs.
Screenshot 2024-12-04 at 18 19 05

However, we discussed some changes with @bartoszbak

  • Snap to the selected point - so the tooltip reflects the data point
  • Sit the tooltip 16px above the point
  • Show the points permanently - but with a highlighted state
  • I've removed the grey line as it was causing an issue with the tooltip mouse position, but also no longer needed now the tooltip is fixed just above the point.

Testing Instructions

  • Hit the campaign details page and hover over the charts, here is an example:
Screen.Recording.2024-12-06.at.11.55.22.mov

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@j6ll j6ll marked this pull request as draft December 4, 2024 18:19
@matticbot
Copy link
Contributor

matticbot commented Dec 4, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~534 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
promote-post-i2      +1569 B  (+0.2%)     +534 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Dec 4, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug jamesgill23/chart-tooltips on your sandbox.

@j6ll j6ll changed the title WIP: Adds a tooltip to the campaign details chart Adds a tooltip to the campaign details chart Dec 5, 2024
@j6ll j6ll force-pushed the jamesgill23/chart-tooltips branch from de88211 to 8aa73f2 Compare December 6, 2024 10:44
@j6ll j6ll mentioned this pull request Dec 6, 2024
8 tasks
@j6ll j6ll force-pushed the jamesgill23/chart-tooltips branch from d9f3da8 to f035dfb Compare December 6, 2024 14:01
@j6ll j6ll marked this pull request as ready for review December 6, 2024 14:01
Copy link
Contributor

@therocket-gr therocket-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes.. LGTM

@j6ll j6ll merged commit 81cb36a into trunk Dec 6, 2024
11 checks passed
@j6ll j6ll deleted the jamesgill23/chart-tooltips branch December 6, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants