Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental UI for site identification step in the migration flow #97072

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

donnapep
Copy link
Contributor

@donnapep donnapep commented Dec 4, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/10025.
Resolves #96413.

Proposed Changes

  • Updates the "Why should you host with us?" section of the site identification step in the migration flow. These changes are currently behind a feature flag and will be launched as part of a future experiment.
  • Removes translation checks for some strings as those have now been translated.

Testing Instructions

  • Browse to the "Let’s find your site" step of the migration flow.
  • Ensure the UI is the same as it was before:

Screenshot 2024-12-04 at 12 14 19 PM

  • Enable the migration-flow/experiment feature flag in config/development.json.
  • Ensure the UI matches the new design (ay0fZYgdXxPDbZbgPlz3hu-fi-1_3446):

Screenshot 2024-12-05 at 8 34 20 AM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@donnapep donnapep self-assigned this Dec 4, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Dec 4, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/site-identification-copy on your sandbox.

@donnapep donnapep force-pushed the update/site-identification-copy branch from 29f21d4 to 6c72a73 Compare December 5, 2024 13:05
@donnapep donnapep added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Dec 5, 2024
@donnapep donnapep requested a review from a team December 5, 2024 13:19
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 5, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17048023

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @donnapep for including a screenshot in the description! This is really helpful for our translators.

Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. 🚢

Regular With feature flag
Screenshot 2024-12-05 at 17 19 31 Screenshot 2024-12-05 at 17 19 36

This will ensure tests don't fail when the feature flag is enabled.
@a8ci18n
Copy link

a8ci18n commented Dec 8, 2024

Translation for this Pull Request has now been finished.

@donnapep donnapep merged commit 8a2935b into trunk Dec 10, 2024
10 of 11 checks passed
@donnapep donnapep deleted the update/site-identification-copy branch December 10, 2024 13:04
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Migrations flow: "Why should you host with us?" section needs tightening
4 participants