e2e: fix correct title tag #97068
Open
e2e: fix correct title tag #97068
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
I might be missing something, but which issue this PR should be fixing? 🤔
Because when running the test (VIEWPORT_NAME=desktop TEST_ON_ATOMIC=false GUTENBERG_EDGE=true yarn jest specs/editor/editor__page-basic-flow.ts) with Simple Gutenberg edge site, it is failing and the selector should actually include H1 tag, not H2.
Looking at TeamCity, there is an issue with the different test: specs/editor/editor__post-basic-flow.ts instead. But again, maybe I missed what you meant to fix with the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
After switching to Gutenberg 19.8.0 we have incorrect selector for title. I checked it and it's indeed should be h2, since we have h1 as the main title
Testing Instructions
Visual review should suffice