Stats: Release new date filtering to production

[dognose24]

Related to https://github.com/Automattic/red-team/issues/274

Proposed Changes

• Enable the feature flag stats/new-date-filtering for all environments.

Why are these changes being made?

• Release the date filtering project by flipping the feature flag.

Testing Instructions

• Spin this change up with the Calypso Live branch.
• Navigate to Stats > Traffic page for any site.
• Ensure the Traffic page applies the new design and date filtering functionalities.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-126874

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-126874&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-126874&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~43 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats        +91 B  (+0.0%)      +26 B  (+0.0%)
home         +36 B  (+0.0%)      +17 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats_release_date_filtering on your sandbox.

[grbicsanja]

In the 'Yesterday' view, I'm unable to click on the Visitors/ Likes/ Comments tabs, see video:

Screen.Recording.2024-12-04.at.09.49.40.mov

[kangzj]

In the 'Yesterday' view, I'm unable to click on the Visitors/ Likes/ Comments tabs, see video:

@grbicsanja good catch! this is expected atm, because we don't have single day data to show for the chart. We removed the hovering effect if that's the case, which @ederrengifo suggested.

[grbicsanja]

In the 'Yesterday' view, I'm unable to click on the Visitors/ Likes/ Comments tabs, see video:

@grbicsanja good catch! this is expected atm, because we don't have single day data to show for the chart. We removed the hovering effect if that's the case, which @ederrengifo suggested.

Thanks @kangzj! Can we instead use the empty state that we usually show for other use cases? Is there a specific reason this view wouldn't work here?

[ederrengifo]

I initially suggested to communicate that the chart is unable within the tooltip, but it seems an empty state could do a be better job since it's a pattern we already use when there is no data to show. We would need to adjust the message though @kangzj cc @grbicsanja

[grbicsanja]

Here's the adjusted message:

No hourly data available
Try selecting a different time frame.

This will be the second use case. Visitors, comments, and likes were recorded that day, but hourly data is unavailable.

The first use case is an actual empty state where no data was recorded.

cc: @kangzj @ederrengifo
.

[ederrengifo]

I found a couple of issues:

• When I first load a site, I see lines go beyond the container. It fixes after refreshing the page. Could be something local?

• I notice we are still showing the visitors filter when selecting Today but visitors are not available in the graph. Should we just hide it for that date range?

[kangzj]

Let's do this 🕺

[kangzj]

Thanks for the final design review @ederrengifo and the improvements pointed out 👍

I notice we are still showing the visitors filter when selecting Today but visitors are not available in the graph. Should we just hide it for that date range?

Addressed

When I first load a site, I see lines go beyond the container. It fixes after refreshing the page. Could be something local?

This is due to some interim changes detecting whether a site is internal or not, and will not happen on production.

Feedback addressed