Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent Feed Overhaul - Remove extra padding in mobile view #97059

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

davemart-in
Copy link
Contributor

Description

Some additional padding snuck in that was affecting the mobile view. I've removed it in this PR.

Before

before

After

after

Testing

@davemart-in davemart-in self-assigned this Dec 4, 2024
@davemart-in davemart-in requested a review from a team as a code owner December 4, 2024 14:14
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

holdercp
holdercp previously approved these changes Dec 4, 2024
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good on mobile, but I think it's removing some helpful padding on desktop between 600 and 780px.

Screenshot 2024-12-04 at 8 27 49 AM Screenshot 2024-12-04 at 8 24 41 AM

@holdercp
Copy link
Contributor

holdercp commented Dec 4, 2024

It looks good on mobile, but I think it's removing some helpful padding on desktop between 600 and 780px.

Ah! Yeah, it's affecting the current view (the one not behind the feature flag).

@holdercp holdercp dismissed their stale review December 4, 2024 14:39

Regression on current (non-feature flag) view was discovered

@davemart-in
Copy link
Contributor Author

@DustyReagan nice catch! That should be fixed in 53d3c80

Copy link
Contributor

@holdercp holdercp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No regressions on current view and extra padding is removed on the new view.

@davemart-in davemart-in merged commit 13281f6 into trunk Dec 4, 2024
10 checks passed
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
@davemart-in davemart-in deleted the fix/reader-recent-mobile branch December 4, 2024 18:09
mehmoodak pushed a commit that referenced this pull request Dec 6, 2024
* Remove extra padding

* Only change 600px and smaller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants