-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Woo rebrand auth signin and magic link pages #97058
Conversation
…s for better keyboard navigation
… email signin link
{ `${ translate( 'Continue as', { | ||
context: 'Continue as an existing WordPress.com user', | ||
} ) } ${ userName }` } | ||
{ translate( 'Continue' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes meant outside of feature flag
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~26 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~25 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~25 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested well 👍 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 🚢
Related to #96945, #96947, #97056
Proposed Changes
Continue as user name
button in sign in (while logged in) pageTesting Instructions
development.json
, setwoocommerce/rebrand-2-0
totrue
yarn start
Sign in page
Email magic link
Email me a login link
Post-email magic link
Send link
Sign in page (while signed in)
Pre-merge Checklist