Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Add Hosting page v3 feature flag. #97057

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

jkguidaven
Copy link
Contributor

This PR introduces a new feature flag for the Hosting page v3. In addition, it includes a new HostingOverviewV3 component to facilitate testing, which will eventually contain the new implementation.

Screenshot 2024-12-04 at 9 16 32 PM

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1544

Proposed Changes

  • Add a4a-hosting-page-redesign-v3 and activate it in the Development and Horizon environments.
  • Add a HostingOverview3 component that will be loaded when the feature flag is enabled.

Why are these changes being made?

  • This is part of the 'In-product Hosting page v3' project.

Testing Instructions

  • Use the A4A live link and go to the /markplace/hosting page.
  • Confirm you see the empty page being loaded. See screenshot above.
  • Test that when adding ?flags=-a4a-hosting-page-redesign-v3 in the URL, the current design is loaded.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven requested a review from a team December 4, 2024 13:19
@jkguidaven jkguidaven self-assigned this Dec 4, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 4, 2024
@jkguidaven jkguidaven marked this pull request as ready for review December 4, 2024 13:20
@matticbot
Copy link
Contributor

matticbot commented Dec 4, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~109 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-marketplace       +810 B  (+0.1%)     +109 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a/hosting-page-v3-feature-flag on your sandbox.

Copy link
Contributor

@cleacos cleacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cleacos
Copy link
Contributor

cleacos commented Dec 4, 2024

It's approved, but I was wondering if we could add something to have both versions or a direct link to restore the previous version, deactivating the flag for the Horizon/Development environments. For example, we could need to update something quickly in the current version from the current version or maybe perform some tests for other tasks.

@jkguidaven jkguidaven force-pushed the add/a4a/hosting-page-v3-feature-flag branch from d4bd19f to c04f1da Compare December 5, 2024 05:29
@jkguidaven
Copy link
Contributor Author

jkguidaven commented Dec 5, 2024

It's approved, but I was wondering if we could add something to have both versions or a direct link to restore the previous version, deactivating the flag for the Horizon/Development environments. For example, we could need to update something quickly in the current version from the current version or maybe perform some tests for other tasks.

Good point! In case this becomes a problem, we could create a separate link for the new hosting page. For now, I'll leave this as is and avoid additional code we need to clean up later once we release the project.

@jkguidaven jkguidaven merged commit 62680f7 into trunk Dec 5, 2024
11 checks passed
@jkguidaven jkguidaven deleted the add/a4a/hosting-page-v3-feature-flag branch December 5, 2024 05:44
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
mehmoodak pushed a commit that referenced this pull request Dec 6, 2024
* Add 'a4a-hosting-page-redesign-v3' feature flag.

* Add Hosting Overview v3 component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants