-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: Add Hosting page v3 feature flag. #97057
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~109 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It's approved, but I was wondering if we could add something to have both versions or a direct link to restore the previous version, deactivating the flag for the Horizon/Development environments. For example, we could need to update something quickly in the current version from the current version or maybe perform some tests for other tasks. |
d4bd19f
to
c04f1da
Compare
Good point! In case this becomes a problem, we could create a separate link for the new hosting page. For now, I'll leave this as is and avoid additional code we need to clean up later once we release the project. |
* Add 'a4a-hosting-page-redesign-v3' feature flag. * Add Hosting Overview v3 component.
This PR introduces a new feature flag for the Hosting page v3. In addition, it includes a new HostingOverviewV3 component to facilitate testing, which will eventually contain the new implementation.
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1544
Proposed Changes
a4a-hosting-page-redesign-v3
and activate it in the Development and Horizon environments.HostingOverview3
component that will be loaded when the feature flag is enabled.Why are these changes being made?
Testing Instructions
/markplace/hosting
page.?flags=-a4a-hosting-page-redesign-v3
in the URL, the current design is loaded.Pre-merge Checklist