-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help Center: Add support for WP Support 3 tab component #96986
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~353 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -53,6 +55,66 @@ export const HelpCenterArticle = () => { | |||
} | |||
}, [ post, query, sectionName ] ); | |||
|
|||
const toggleTab = ( element: Element, show: boolean ) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to extract the tabbing functionality in a separate hook that we can call here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Let me check how I can refactor this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah, looks great now! Thanks Anthony
|
||
color: var( --blue-blue-50, #0675c4 ); | ||
/* stylelint-disable-next-line declaration-property-unit-allowed-list */ | ||
font-size: 16px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we don't need the
/* stylelint-disable-next-line declaration-property-unit-allowed-list */
And we can use $font-body;
Fixes: https://github.com/Automattic/dotcom-forge/issues/9818
Proposed Changes
Why are these changes being made?
Testing Instructions
home?flags=help-center-experience
and open the Help CenterUpload a theme
,Get more storage space
,Set the homepage
.Pre-merge Checklist