Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Center: Add support for WP Support 3 tab component #96986

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Dec 2, 2024

Fixes: https://github.com/Automattic/dotcom-forge/issues/9818

Proposed Changes

  • Add support for WPSupport 3 Tab component
CleanShot 2024-12-02 at 13 48 55@2x

Why are these changes being made?

  • WPSupport3 tab component is currently hidden. These changes add its functionality and make it appear on support docs within Help Center.

Testing Instructions

  • Checkout trunk or use live link
  • Navigate to home?flags=help-center-experience and open the Help Center
  • Find a support doc that uses the wpsupport3 tab component (Example articles to search for: Upload a theme, Get more storage space, Set the homepage.
  • Test its functionality
  • Bonus: Find more support docs with this components and try to break it.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@agrullon95 agrullon95 self-assigned this Dec 2, 2024
@agrullon95 agrullon95 requested a review from a team as a code owner December 2, 2024 18:48
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 2, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 2, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/wp-support3-tab-component on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 2, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~353 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
async-load-automattic-help-center       +943 B  (+0.1%)     +353 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -53,6 +55,66 @@ export const HelpCenterArticle = () => {
}
}, [ post, query, sectionName ] );

const toggleTab = ( element: Element, show: boolean ) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to extract the tabbing functionality in a separate hook that we can call here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Let me check how I can refactor this

@escapemanuele escapemanuele self-requested a review December 3, 2024 09:50
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, looks great now! Thanks Anthony


color: var( --blue-blue-50, #0675c4 );
/* stylelint-disable-next-line declaration-property-unit-allowed-list */
font-size: 16px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we don't need the
/* stylelint-disable-next-line declaration-property-unit-allowed-list */
And we can use $font-body;

@escapemanuele escapemanuele merged commit 08f6a66 into trunk Dec 3, 2024
11 checks passed
@escapemanuele escapemanuele deleted the fix/wp-support3-tab-component branch December 3, 2024 13:00
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants