Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Migration: Update "View Sites dashboard" button to point to site overview #96985

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

sixhours
Copy link
Contributor

@sixhours sixhours commented Dec 2, 2024

Fixes #96418

Proposed Changes

  • Instead of going to /sites, go to /sites/overview/siteSlug so users see the overview for their specific new site. Helpful for users who have more than one site and might get lost in the all sites view.
Screenshot 2024-12-02 at 1 34 49 PM

Why are these changes being made?

  • p58i-iHv-p2

Testing Instructions

  • Switch to this PR
  • Create a new site from /start
  • Choose import/migrate on the goals step
  • Go through the migration flow and choose "Do it for me"
  • Put in credentials or a migration file (you can input any URL for the migration file to work around this)
  • On the final page, the "View Sites dashboard" button should point to /sites/overview/yoursiteslug

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@sixhours sixhours added the [Feature] Site Migration Features related to site migrations to WPcom label Dec 2, 2024
@sixhours sixhours requested review from fditrapani and a team December 2, 2024 18:34
@sixhours sixhours self-assigned this Dec 2, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 2, 2024
@sixhours sixhours changed the title Site Migration: Update "View Sites dashboard" link to point to site overview a Site Migration: Update "View Sites dashboard" button to point to site overview Dec 2, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~7 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
import-hosted-site-flow        +12 B  (+0.0%)       +7 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/site-migration-forward on your sandbox.

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update! Works well!

@sixhours sixhours merged commit 391441c into trunk Dec 5, 2024
16 of 18 checks passed
@sixhours sixhours deleted the update/site-migration-forward branch December 5, 2024 16:26
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Migration Features related to site migrations to WPcom
Projects
None yet
4 participants